You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2014/08/12 20:19:04 UTC
Remove VERSION file from repos
Most of our repos have a package.json. It keeps track of versions. I think
we should work towards removing the VERSION files from the repos we can.
Thoughts?
This would require some changes to coho so it doesn't try to update the
version file when doing releases.
Re: Remove VERSION file from repos
Posted by Ian Clelland <ic...@chromium.org>.
On Tue, Aug 12, 2014 at 4:18 PM, Lorin Beer <lo...@gmail.com> wrote:
> the version scripts are just about the only thing about the platform
> scripts that are simple enough to rewrite trivially.
Which is why the Android version scripts are literally
console.log("whatever_the_version_was_when_we_updated_this_file")
We have a doc on this (
https://github.com/apache/cordova-coho/blob/master/docs/storing-repo-versions-design.md)
-- I had suggested a year ago that we modify all of the platforms to just
have their scripts echo a hard-coded value (Thread:
http://callback.markmail.org/thread/zepwjgokwwgdhuys).
I still think the proposal makes sense; there's no need to have any
complicated logic for a thing that should be changed once per release, and
shouldn't ever need to be generated at run-time.
Ian
> Leveraging a
> rewrite/refactor of the version script into a total rewrite of platform
> level scripts == 'lulz'
>
>
>
> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com> wrote:
>
> > the non-cordova cli path depends on node to install/uninstall plugins
> >
> > @purplecabbage
> > risingj.com
> >
> >
> > On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com> wrote:
> >
> > > Of course I considered nodejs, but no, this is for the non-cordova CLI
> > > path, which does not need another dependency.
> > >
> > > On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
> wrote:
> > > > Yeah, if you are going to replace bash, replace it with nodejs!
> > > >
> > > >
> > > > @purplecabbage
> > > > risingj.com
> > > >
> > > >
> > > > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> wrote:
> > > >
> > > >> Have you considered writing a small node script to pass the json?
> This
> > > >> would make it as simple as requiring in the package json an piping
> the
> > > >> relevant info to stdout
> > > >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> > > >>
> > > >> > Yeah I value life and my sanity - I'll probably replace the bash
> > > >> > script with python
> > > >> >
> > > >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> lorin.beer@gmail.com>
> > > >> wrote:
> > > >> > > one source for version information is better
> > > >> > >
> > > >> > > although parsing json with bash scripts seems janky
> > > >> > >
> > > >> > >
> > > >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> purplecabbage@gmail.com>
> > > >> wrote:
> > > >> > >
> > > >> > >> I think it still needs to exist in an output project ... which
> is
> > > not
> > > >> > >> (yet?) an npm project, and so does not have a package.json.
> > > >> > >>
> > > >> > >> The individual platform repos can get rid of it, they will just
> > > need
> > > >> to
> > > >> > >> modify the way they `create` new projects to read the value
> from
> > > >> > >> package.json and output it to NewProject/VERSION
> > > >> > >>
> > > >> > >>
> > > >> > >>
> > > >> > >>
> > > >> > >> @purplecabbage
> > > >> > >> risingj.com
> > > >> > >>
> > > >> > >>
> > > >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> > > wrote:
> > > >> > >>
> > > >> > >> > For iOS, the only file I can see that depends on this is:
> > > >> > >> >
> > > >> > >> > 1.
> > > >> > >> >
> > > >> > >>
> > > >> >
> > > >>
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > >> > >> >
> > > >> > >> > Not sure of the alternative.
> > > >> > >> >
> > > >> > >> > This references it but can be removed:
> > > >> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > >> > >> >
> > > >> > >> >
> > > >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > >> stevengill97@gmail.com
> > > >> > >
> > > >> > >> > wrote:
> > > >> > >> > > Most of our repos have a package.json. It keeps track of
> > > >> versions. I
> > > >> > >> > think
> > > >> > >> > > we should work towards removing the VERSION files from the
> > > repos
> > > >> we
> > > >> > >> can.
> > > >> > >> > >
> > > >> > >> > > Thoughts?
> > > >> > >> > >
> > > >> > >> > > This would require some changes to coho so it doesn't try
> to
> > > >> update
> > > >> > the
> > > >> > >> > > version file when doing releases.
> > > >> > >> >
> > > >> > >>
> > > >> >
> > > >>
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Lorin Beer <lo...@gmail.com>.
the version scripts are just about the only thing about the platform
scripts that are simple enough to rewrite trivially. Leveraging a
rewrite/refactor of the version script into a total rewrite of platform
level scripts == 'lulz'
On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com> wrote:
> the non-cordova cli path depends on node to install/uninstall plugins
>
> @purplecabbage
> risingj.com
>
>
> On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com> wrote:
>
> > Of course I considered nodejs, but no, this is for the non-cordova CLI
> > path, which does not need another dependency.
> >
> > On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com> wrote:
> > > Yeah, if you are going to replace bash, replace it with nodejs!
> > >
> > >
> > > @purplecabbage
> > > risingj.com
> > >
> > >
> > > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
> > >
> > >> Have you considered writing a small node script to pass the json? This
> > >> would make it as simple as requiring in the package json an piping the
> > >> relevant info to stdout
> > >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> > >>
> > >> > Yeah I value life and my sanity - I'll probably replace the bash
> > >> > script with python
> > >> >
> > >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com>
> > >> wrote:
> > >> > > one source for version information is better
> > >> > >
> > >> > > although parsing json with bash scripts seems janky
> > >> > >
> > >> > >
> > >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com>
> > >> wrote:
> > >> > >
> > >> > >> I think it still needs to exist in an output project ... which is
> > not
> > >> > >> (yet?) an npm project, and so does not have a package.json.
> > >> > >>
> > >> > >> The individual platform repos can get rid of it, they will just
> > need
> > >> to
> > >> > >> modify the way they `create` new projects to read the value from
> > >> > >> package.json and output it to NewProject/VERSION
> > >> > >>
> > >> > >>
> > >> > >>
> > >> > >>
> > >> > >> @purplecabbage
> > >> > >> risingj.com
> > >> > >>
> > >> > >>
> > >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> > wrote:
> > >> > >>
> > >> > >> > For iOS, the only file I can see that depends on this is:
> > >> > >> >
> > >> > >> > 1.
> > >> > >> >
> > >> > >>
> > >> >
> > >>
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > >> > >> >
> > >> > >> > Not sure of the alternative.
> > >> > >> >
> > >> > >> > This references it but can be removed:
> > >> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > >> > >> >
> > >> > >> >
> > >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > >> stevengill97@gmail.com
> > >> > >
> > >> > >> > wrote:
> > >> > >> > > Most of our repos have a package.json. It keeps track of
> > >> versions. I
> > >> > >> > think
> > >> > >> > > we should work towards removing the VERSION files from the
> > repos
> > >> we
> > >> > >> can.
> > >> > >> > >
> > >> > >> > > Thoughts?
> > >> > >> > >
> > >> > >> > > This would require some changes to coho so it doesn't try to
> > >> update
> > >> > the
> > >> > >> > > version file when doing releases.
> > >> > >> >
> > >> > >>
> > >> >
> > >>
> >
>
Re: Remove VERSION file from repos
Posted by Jesse <pu...@gmail.com>.
yeah, do what is easiest, and adds the least dependencies.
My point was just that I wonder if non-CLI paths still exist. #offtopic ...
@purplecabbage
risingj.com
On Tue, Aug 12, 2014 at 1:19 PM, Shazron <sh...@gmail.com> wrote:
> Not if they are installed manually. It's not worth having some
> dependency just to read a version, that's nuts.
>
> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com> wrote:
> > the non-cordova cli path depends on node to install/uninstall plugins
> >
> > @purplecabbage
> > risingj.com
> >
> >
> > On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com> wrote:
> >
> >> Of course I considered nodejs, but no, this is for the non-cordova CLI
> >> path, which does not need another dependency.
> >>
> >> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
> wrote:
> >> > Yeah, if you are going to replace bash, replace it with nodejs!
> >> >
> >> >
> >> > @purplecabbage
> >> > risingj.com
> >> >
> >> >
> >> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
> >> >
> >> >> Have you considered writing a small node script to pass the json?
> This
> >> >> would make it as simple as requiring in the package json an piping
> the
> >> >> relevant info to stdout
> >> >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> >> >>
> >> >> > Yeah I value life and my sanity - I'll probably replace the bash
> >> >> > script with python
> >> >> >
> >> >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lorin.beer@gmail.com
> >
> >> >> wrote:
> >> >> > > one source for version information is better
> >> >> > >
> >> >> > > although parsing json with bash scripts seems janky
> >> >> > >
> >> >> > >
> >> >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <purplecabbage@gmail.com
> >
> >> >> wrote:
> >> >> > >
> >> >> > >> I think it still needs to exist in an output project ... which
> is
> >> not
> >> >> > >> (yet?) an npm project, and so does not have a package.json.
> >> >> > >>
> >> >> > >> The individual platform repos can get rid of it, they will just
> >> need
> >> >> to
> >> >> > >> modify the way they `create` new projects to read the value from
> >> >> > >> package.json and output it to NewProject/VERSION
> >> >> > >>
> >> >> > >>
> >> >> > >>
> >> >> > >>
> >> >> > >> @purplecabbage
> >> >> > >> risingj.com
> >> >> > >>
> >> >> > >>
> >> >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> >> wrote:
> >> >> > >>
> >> >> > >> > For iOS, the only file I can see that depends on this is:
> >> >> > >> >
> >> >> > >> > 1.
> >> >> > >> >
> >> >> > >>
> >> >> >
> >> >>
> >>
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> >> >> > >> >
> >> >> > >> > Not sure of the alternative.
> >> >> > >> >
> >> >> > >> > This references it but can be removed:
> >> >> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> >> >> > >> >
> >> >> > >> >
> >> >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> >> >> stevengill97@gmail.com
> >> >> > >
> >> >> > >> > wrote:
> >> >> > >> > > Most of our repos have a package.json. It keeps track of
> >> >> versions. I
> >> >> > >> > think
> >> >> > >> > > we should work towards removing the VERSION files from the
> >> repos
> >> >> we
> >> >> > >> can.
> >> >> > >> > >
> >> >> > >> > > Thoughts?
> >> >> > >> > >
> >> >> > >> > > This would require some changes to coho so it doesn't try to
> >> >> update
> >> >> > the
> >> >> > >> > > version file when doing releases.
> >> >> > >> >
> >> >> > >>
> >> >> >
> >> >>
> >>
>
Re: Remove VERSION file from repos
Posted by Shazron <sh...@gmail.com>.
Resolved for iOS. sent PR for cordova-coho
On Fri, Aug 29, 2014 at 11:51 AM, Steven Gill <st...@gmail.com> wrote:
> I created one now. https://issues.apache.org/jira/browse/CB-7432
>
>
>
>
> On Thu, Aug 28, 2014 at 10:17 PM, Gorkem Ercan <go...@gmail.com>
> wrote:
>
>> Is there a JIRA to follow up on this change?
>> --
>> Gorkem
>>
>>
>> On Fri, Aug 29, 2014 at 3:16 AM, Steven Gill <st...@gmail.com>
>> wrote:
>>
>> > Just a quick update to this.
>> >
>> > Coho now updates the version script for the following platforms:
>> > Android
>> > Amazon-fireos
>> > Ubuntu
>> > Firefoxos
>> > Blackberry
>> >
>> > If coho is being used for releases, I think this is the way to go. iOS,
>> > windows and wp8 are the only remaining ones.
>> >
>> > Line to edit in coho:
>> >
>> >
>> https://github.com/apache/cordova-coho/blob/master/src/cadance-release.js#L124
>> > Sample version script:
>> >
>> >
>> https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/version
>> >
>> > Let me know if you are going to make this change for your platforms. I
>> will
>> > need to copy it over to my platform-release file which will replace
>> cadence
>> > release after 3.6.0:
>> >
>> >
>> https://github.com/stevengill/cordova-coho/blob/cb-7224/src/platform-release.js#L124
>> >
>> >
>> >
>> >
>> > On Thu, Aug 14, 2014 at 10:15 AM, purplecabbage <purplecabbage@gmail.com
>> >
>> > wrote:
>> >
>> > >
>> > >
>> > > > On Aug 14, 2014, at 4:09 AM, Ian Clelland <ic...@chromium.org>
>> > > wrote:
>> > > >
>> > > > +1 -- there's little value in trying to derive something at runtime
>> > that
>> > > > should just be hard-coded. (And even if we didn't have coho, we could
>> > set
>> > > > it manually without too much effort. :) )
>> > >
>> > > If we remember to.
>> > > +0
>> > >
>> > >
>> > > >
>> > > >
>> > > >> On Wed, Aug 13, 2014 at 8:28 PM, Steven Gill <
>> stevengill97@gmail.com>
>> > > wrote:
>> > > >>
>> > > >> Using android's method of doing this doesn't seem so bad to me.
>> > > >>
>> > > >> Version script has hard coded value that coho sets when doing a
>> > release.
>> > > >> Seems to be working fine as long as coho is used for releasing.
>> > > >>
>> > > >> Thoughts?
>> > > >>
>> > > >>
>> > > >> On Wed, Aug 13, 2014 at 1:44 PM, Carlos Santana <
>> csantana23@gmail.com
>> > >
>> > > >> wrote:
>> > > >>
>> > > >>> I think having the ios platform scripts in nodejs have a side
>> benefit
>> > > of
>> > > >>> being able to create ios platform on Linux and Windows.
>> > > >>>
>> > > >>> IBM Worklight customers use this use case, where they create ios
>> > > cordova
>> > > >>> app, and in Windows or Linux they use it for preview with MBS a
>> tool
>> > > >>> similar to Ripple, and generate a zip with the xcode project, they
>> > can
>> > > >> use
>> > > >>> on a Mac with XCode for final build.
>> > > >>>
>> > > >>> The use case is also similar to create an ios platform app and
>> > preview
>> > > in
>> > > >>> App Harness like PhoneGap Developer.
>> > > >>>
>> > > >>> just my two cents.
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>>> On Tue, Aug 12, 2014 at 4:46 PM, Shazron <sh...@gmail.com>
>> wrote:
>> > > >>>>
>> > > >>>> Believe me, I want to go all node -- but all in for all scripts --
>> > > >>>> which we don't have time to do yet (maybe 4.0?).
>> > > >>>> But seeing that it's just replacing the contents of the current
>> bash
>> > > >>>> script with python code, it's the path of least resistance, and
>> path
>> > > >>>> of least potential conflict imo. No one will notice.
>> > > >>>>
>> > > >>>>
>> > > >>>> On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <
>> mmocny@chromium.org>
>> > > >>> wrote:
>> > > >>>>> Shaz, that's technically true, but how many users actually use
>> that
>> > > >>> path
>> > > >>>>> these days?
>> > > >>>>>
>> > > >>>>> I thought the last stats overwhelmingly suggest our users are
>> > > >> drinking
>> > > >>>> the
>> > > >>>>> kool-aid and using cli, node, etc.
>> > > >>>>>
>> > > >>>>>
>> > > >>>>>> On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com>
>> > wrote:
>> > > >>>>>>
>> > > >>>>>> Not if they are installed manually. It's not worth having some
>> > > >>>>>> dependency just to read a version, that's nuts.
>> > > >>>>>>
>> > > >>>>>> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <purplecabbage@gmail.com
>> >
>> > > >>> wrote:
>> > > >>>>>>> the non-cordova cli path depends on node to install/uninstall
>> > > >>> plugins
>> > > >>>>>>>
>> > > >>>>>>> @purplecabbage
>> > > >>>>>>> risingj.com
>> > > >>>>>>>
>> > > >>>>>>>
>> > > >>>>>>> On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com>
>> > > >> wrote:
>> > > >>>>>>>
>> > > >>>>>>>> Of course I considered nodejs, but no, this is for the
>> > > >> non-cordova
>> > > >>>> CLI
>> > > >>>>>>>> path, which does not need another dependency.
>> > > >>>>>>>>
>> > > >>>>>>>> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <
>> > purplecabbage@gmail.com
>> > > >>>
>> > > >>>>>> wrote:
>> > > >>>>>>>>> Yeah, if you are going to replace bash, replace it with
>> nodejs!
>> > > >>>>>>>>>
>> > > >>>>>>>>>
>> > > >>>>>>>>> @purplecabbage
>> > > >>>>>>>>> risingj.com
>> > > >>>>>>>>>
>> > > >>>>>>>>>
>> > > >>>>>>>>> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <
>> myles@famo.us>
>> > > >>>> wrote:
>> > > >>>>>>>>>
>> > > >>>>>>>>>> Have you considered writing a small node script to pass the
>> > > >>> json?
>> > > >>>>>> This
>> > > >>>>>>>>>> would make it as simple as requiring in the package json an
>> > > >>> piping
>> > > >>>>>> the
>> > > >>>>>>>>>> relevant info to stdout
>> > > >>>>>>>>>> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com>
>> > > >> wrote:
>> > > >>>>>>>>>>
>> > > >>>>>>>>>>> Yeah I value life and my sanity - I'll probably replace the
>> > > >>> bash
>> > > >>>>>>>>>>> script with python
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>> On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
>> > > >>>> lorin.beer@gmail.com
>> > > >>>>>>>
>> > > >>>>>>>>>> wrote:
>> > > >>>>>>>>>>>> one source for version information is better
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>> although parsing json with bash scripts seems janky
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
>> > > >>>> purplecabbage@gmail.com
>> > > >>>>>>>
>> > > >>>>>>>>>> wrote:
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>>> I think it still needs to exist in an output project ...
>> > > >>>> which
>> > > >>>>>> is
>> > > >>>>>>>> not
>> > > >>>>>>>>>>>>> (yet?) an npm project, and so does not have a
>> > > >> package.json.
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>> The individual platform repos can get rid of it, they
>> > > >> will
>> > > >>>> just
>> > > >>>>>>>> need
>> > > >>>>>>>>>> to
>> > > >>>>>>>>>>>>> modify the way they `create` new projects to read the
>> > > >> value
>> > > >>>> from
>> > > >>>>>>>>>>>>> package.json and output it to NewProject/VERSION
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>> @purplecabbage
>> > > >>>>>>>>>>>>> risingj.com
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
>> > > >>> shazron@gmail.com
>> > > >>>>>
>> > > >>>>>>>> wrote:
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>> For iOS, the only file I can see that depends on this
>> > > >> is:
>> > > >>>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>> 1.
>> > > >>
>> > >
>> >
>> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>> > > >>>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>> Not sure of the alternative.
>> > > >>>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>> This references it but can be removed:
>> > > >>>> https://github.com/apache/cordova-ios/blob/master/bin/create
>> > > >>>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
>> > > >>>>>>>>>> stevengill97@gmail.com
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>>>> wrote:
>> > > >>>>>>>>>>>>>>> Most of our repos have a package.json. It keeps track
>> > > >>> of
>> > > >>>>>>>>>> versions. I
>> > > >>>>>>>>>>>>>> think
>> > > >>>>>>>>>>>>>>> we should work towards removing the VERSION files
>> > > >> from
>> > > >>>> the
>> > > >>>>>>>> repos
>> > > >>>>>>>>>> we
>> > > >>>>>>>>>>>>> can.
>> > > >>>>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>>> Thoughts?
>> > > >>>>>>>>>>>>>>>
>> > > >>>>>>>>>>>>>>> This would require some changes to coho so it doesn't
>> > > >>>> try to
>> > > >>>>>>>>>> update
>> > > >>>>>>>>>>> the
>> > > >>>>>>>>>>>>>>> version file when doing releases.
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>> --
>> > > >>> Carlos Santana
>> > > >>> <cs...@gmail.com>
>> > > >>
>> > >
>> >
>>
Re: Remove VERSION file from repos
Posted by Steven Gill <st...@gmail.com>.
I created one now. https://issues.apache.org/jira/browse/CB-7432
On Thu, Aug 28, 2014 at 10:17 PM, Gorkem Ercan <go...@gmail.com>
wrote:
> Is there a JIRA to follow up on this change?
> --
> Gorkem
>
>
> On Fri, Aug 29, 2014 at 3:16 AM, Steven Gill <st...@gmail.com>
> wrote:
>
> > Just a quick update to this.
> >
> > Coho now updates the version script for the following platforms:
> > Android
> > Amazon-fireos
> > Ubuntu
> > Firefoxos
> > Blackberry
> >
> > If coho is being used for releases, I think this is the way to go. iOS,
> > windows and wp8 are the only remaining ones.
> >
> > Line to edit in coho:
> >
> >
> https://github.com/apache/cordova-coho/blob/master/src/cadance-release.js#L124
> > Sample version script:
> >
> >
> https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/version
> >
> > Let me know if you are going to make this change for your platforms. I
> will
> > need to copy it over to my platform-release file which will replace
> cadence
> > release after 3.6.0:
> >
> >
> https://github.com/stevengill/cordova-coho/blob/cb-7224/src/platform-release.js#L124
> >
> >
> >
> >
> > On Thu, Aug 14, 2014 at 10:15 AM, purplecabbage <purplecabbage@gmail.com
> >
> > wrote:
> >
> > >
> > >
> > > > On Aug 14, 2014, at 4:09 AM, Ian Clelland <ic...@chromium.org>
> > > wrote:
> > > >
> > > > +1 -- there's little value in trying to derive something at runtime
> > that
> > > > should just be hard-coded. (And even if we didn't have coho, we could
> > set
> > > > it manually without too much effort. :) )
> > >
> > > If we remember to.
> > > +0
> > >
> > >
> > > >
> > > >
> > > >> On Wed, Aug 13, 2014 at 8:28 PM, Steven Gill <
> stevengill97@gmail.com>
> > > wrote:
> > > >>
> > > >> Using android's method of doing this doesn't seem so bad to me.
> > > >>
> > > >> Version script has hard coded value that coho sets when doing a
> > release.
> > > >> Seems to be working fine as long as coho is used for releasing.
> > > >>
> > > >> Thoughts?
> > > >>
> > > >>
> > > >> On Wed, Aug 13, 2014 at 1:44 PM, Carlos Santana <
> csantana23@gmail.com
> > >
> > > >> wrote:
> > > >>
> > > >>> I think having the ios platform scripts in nodejs have a side
> benefit
> > > of
> > > >>> being able to create ios platform on Linux and Windows.
> > > >>>
> > > >>> IBM Worklight customers use this use case, where they create ios
> > > cordova
> > > >>> app, and in Windows or Linux they use it for preview with MBS a
> tool
> > > >>> similar to Ripple, and generate a zip with the xcode project, they
> > can
> > > >> use
> > > >>> on a Mac with XCode for final build.
> > > >>>
> > > >>> The use case is also similar to create an ios platform app and
> > preview
> > > in
> > > >>> App Harness like PhoneGap Developer.
> > > >>>
> > > >>> just my two cents.
> > > >>>
> > > >>>
> > > >>>
> > > >>>> On Tue, Aug 12, 2014 at 4:46 PM, Shazron <sh...@gmail.com>
> wrote:
> > > >>>>
> > > >>>> Believe me, I want to go all node -- but all in for all scripts --
> > > >>>> which we don't have time to do yet (maybe 4.0?).
> > > >>>> But seeing that it's just replacing the contents of the current
> bash
> > > >>>> script with python code, it's the path of least resistance, and
> path
> > > >>>> of least potential conflict imo. No one will notice.
> > > >>>>
> > > >>>>
> > > >>>> On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <
> mmocny@chromium.org>
> > > >>> wrote:
> > > >>>>> Shaz, that's technically true, but how many users actually use
> that
> > > >>> path
> > > >>>>> these days?
> > > >>>>>
> > > >>>>> I thought the last stats overwhelmingly suggest our users are
> > > >> drinking
> > > >>>> the
> > > >>>>> kool-aid and using cli, node, etc.
> > > >>>>>
> > > >>>>>
> > > >>>>>> On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com>
> > wrote:
> > > >>>>>>
> > > >>>>>> Not if they are installed manually. It's not worth having some
> > > >>>>>> dependency just to read a version, that's nuts.
> > > >>>>>>
> > > >>>>>> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <purplecabbage@gmail.com
> >
> > > >>> wrote:
> > > >>>>>>> the non-cordova cli path depends on node to install/uninstall
> > > >>> plugins
> > > >>>>>>>
> > > >>>>>>> @purplecabbage
> > > >>>>>>> risingj.com
> > > >>>>>>>
> > > >>>>>>>
> > > >>>>>>> On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com>
> > > >> wrote:
> > > >>>>>>>
> > > >>>>>>>> Of course I considered nodejs, but no, this is for the
> > > >> non-cordova
> > > >>>> CLI
> > > >>>>>>>> path, which does not need another dependency.
> > > >>>>>>>>
> > > >>>>>>>> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <
> > purplecabbage@gmail.com
> > > >>>
> > > >>>>>> wrote:
> > > >>>>>>>>> Yeah, if you are going to replace bash, replace it with
> nodejs!
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>> @purplecabbage
> > > >>>>>>>>> risingj.com
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <
> myles@famo.us>
> > > >>>> wrote:
> > > >>>>>>>>>
> > > >>>>>>>>>> Have you considered writing a small node script to pass the
> > > >>> json?
> > > >>>>>> This
> > > >>>>>>>>>> would make it as simple as requiring in the package json an
> > > >>> piping
> > > >>>>>> the
> > > >>>>>>>>>> relevant info to stdout
> > > >>>>>>>>>> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com>
> > > >> wrote:
> > > >>>>>>>>>>
> > > >>>>>>>>>>> Yeah I value life and my sanity - I'll probably replace the
> > > >>> bash
> > > >>>>>>>>>>> script with python
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> > > >>>> lorin.beer@gmail.com
> > > >>>>>>>
> > > >>>>>>>>>> wrote:
> > > >>>>>>>>>>>> one source for version information is better
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> although parsing json with bash scripts seems janky
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> > > >>>> purplecabbage@gmail.com
> > > >>>>>>>
> > > >>>>>>>>>> wrote:
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>> I think it still needs to exist in an output project ...
> > > >>>> which
> > > >>>>>> is
> > > >>>>>>>> not
> > > >>>>>>>>>>>>> (yet?) an npm project, and so does not have a
> > > >> package.json.
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> The individual platform repos can get rid of it, they
> > > >> will
> > > >>>> just
> > > >>>>>>>> need
> > > >>>>>>>>>> to
> > > >>>>>>>>>>>>> modify the way they `create` new projects to read the
> > > >> value
> > > >>>> from
> > > >>>>>>>>>>>>> package.json and output it to NewProject/VERSION
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> @purplecabbage
> > > >>>>>>>>>>>>> risingj.com
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
> > > >>> shazron@gmail.com
> > > >>>>>
> > > >>>>>>>> wrote:
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>>> For iOS, the only file I can see that depends on this
> > > >> is:
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>> 1.
> > > >>
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>> Not sure of the alternative.
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>> This references it but can be removed:
> > > >>>> https://github.com/apache/cordova-ios/blob/master/bin/create
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > >>>>>>>>>> stevengill97@gmail.com
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>>> wrote:
> > > >>>>>>>>>>>>>>> Most of our repos have a package.json. It keeps track
> > > >>> of
> > > >>>>>>>>>> versions. I
> > > >>>>>>>>>>>>>> think
> > > >>>>>>>>>>>>>>> we should work towards removing the VERSION files
> > > >> from
> > > >>>> the
> > > >>>>>>>> repos
> > > >>>>>>>>>> we
> > > >>>>>>>>>>>>> can.
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> Thoughts?
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> This would require some changes to coho so it doesn't
> > > >>>> try to
> > > >>>>>>>>>> update
> > > >>>>>>>>>>> the
> > > >>>>>>>>>>>>>>> version file when doing releases.
> > > >>>
> > > >>>
> > > >>>
> > > >>> --
> > > >>> Carlos Santana
> > > >>> <cs...@gmail.com>
> > > >>
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Gorkem Ercan <go...@gmail.com>.
Is there a JIRA to follow up on this change?
--
Gorkem
On Fri, Aug 29, 2014 at 3:16 AM, Steven Gill <st...@gmail.com> wrote:
> Just a quick update to this.
>
> Coho now updates the version script for the following platforms:
> Android
> Amazon-fireos
> Ubuntu
> Firefoxos
> Blackberry
>
> If coho is being used for releases, I think this is the way to go. iOS,
> windows and wp8 are the only remaining ones.
>
> Line to edit in coho:
>
> https://github.com/apache/cordova-coho/blob/master/src/cadance-release.js#L124
> Sample version script:
>
> https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/version
>
> Let me know if you are going to make this change for your platforms. I will
> need to copy it over to my platform-release file which will replace cadence
> release after 3.6.0:
>
> https://github.com/stevengill/cordova-coho/blob/cb-7224/src/platform-release.js#L124
>
>
>
>
> On Thu, Aug 14, 2014 at 10:15 AM, purplecabbage <pu...@gmail.com>
> wrote:
>
> >
> >
> > > On Aug 14, 2014, at 4:09 AM, Ian Clelland <ic...@chromium.org>
> > wrote:
> > >
> > > +1 -- there's little value in trying to derive something at runtime
> that
> > > should just be hard-coded. (And even if we didn't have coho, we could
> set
> > > it manually without too much effort. :) )
> >
> > If we remember to.
> > +0
> >
> >
> > >
> > >
> > >> On Wed, Aug 13, 2014 at 8:28 PM, Steven Gill <st...@gmail.com>
> > wrote:
> > >>
> > >> Using android's method of doing this doesn't seem so bad to me.
> > >>
> > >> Version script has hard coded value that coho sets when doing a
> release.
> > >> Seems to be working fine as long as coho is used for releasing.
> > >>
> > >> Thoughts?
> > >>
> > >>
> > >> On Wed, Aug 13, 2014 at 1:44 PM, Carlos Santana <csantana23@gmail.com
> >
> > >> wrote:
> > >>
> > >>> I think having the ios platform scripts in nodejs have a side benefit
> > of
> > >>> being able to create ios platform on Linux and Windows.
> > >>>
> > >>> IBM Worklight customers use this use case, where they create ios
> > cordova
> > >>> app, and in Windows or Linux they use it for preview with MBS a tool
> > >>> similar to Ripple, and generate a zip with the xcode project, they
> can
> > >> use
> > >>> on a Mac with XCode for final build.
> > >>>
> > >>> The use case is also similar to create an ios platform app and
> preview
> > in
> > >>> App Harness like PhoneGap Developer.
> > >>>
> > >>> just my two cents.
> > >>>
> > >>>
> > >>>
> > >>>> On Tue, Aug 12, 2014 at 4:46 PM, Shazron <sh...@gmail.com> wrote:
> > >>>>
> > >>>> Believe me, I want to go all node -- but all in for all scripts --
> > >>>> which we don't have time to do yet (maybe 4.0?).
> > >>>> But seeing that it's just replacing the contents of the current bash
> > >>>> script with python code, it's the path of least resistance, and path
> > >>>> of least potential conflict imo. No one will notice.
> > >>>>
> > >>>>
> > >>>> On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <mm...@chromium.org>
> > >>> wrote:
> > >>>>> Shaz, that's technically true, but how many users actually use that
> > >>> path
> > >>>>> these days?
> > >>>>>
> > >>>>> I thought the last stats overwhelmingly suggest our users are
> > >> drinking
> > >>>> the
> > >>>>> kool-aid and using cli, node, etc.
> > >>>>>
> > >>>>>
> > >>>>>> On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com>
> wrote:
> > >>>>>>
> > >>>>>> Not if they are installed manually. It's not worth having some
> > >>>>>> dependency just to read a version, that's nuts.
> > >>>>>>
> > >>>>>> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com>
> > >>> wrote:
> > >>>>>>> the non-cordova cli path depends on node to install/uninstall
> > >>> plugins
> > >>>>>>>
> > >>>>>>> @purplecabbage
> > >>>>>>> risingj.com
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com>
> > >> wrote:
> > >>>>>>>
> > >>>>>>>> Of course I considered nodejs, but no, this is for the
> > >> non-cordova
> > >>>> CLI
> > >>>>>>>> path, which does not need another dependency.
> > >>>>>>>>
> > >>>>>>>> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <
> purplecabbage@gmail.com
> > >>>
> > >>>>>> wrote:
> > >>>>>>>>> Yeah, if you are going to replace bash, replace it with nodejs!
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> @purplecabbage
> > >>>>>>>>> risingj.com
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> > >>>> wrote:
> > >>>>>>>>>
> > >>>>>>>>>> Have you considered writing a small node script to pass the
> > >>> json?
> > >>>>>> This
> > >>>>>>>>>> would make it as simple as requiring in the package json an
> > >>> piping
> > >>>>>> the
> > >>>>>>>>>> relevant info to stdout
> > >>>>>>>>>> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com>
> > >> wrote:
> > >>>>>>>>>>
> > >>>>>>>>>>> Yeah I value life and my sanity - I'll probably replace the
> > >>> bash
> > >>>>>>>>>>> script with python
> > >>>>>>>>>>>
> > >>>>>>>>>>> On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> > >>>> lorin.beer@gmail.com
> > >>>>>>>
> > >>>>>>>>>> wrote:
> > >>>>>>>>>>>> one source for version information is better
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> although parsing json with bash scripts seems janky
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> > >>>> purplecabbage@gmail.com
> > >>>>>>>
> > >>>>>>>>>> wrote:
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>> I think it still needs to exist in an output project ...
> > >>>> which
> > >>>>>> is
> > >>>>>>>> not
> > >>>>>>>>>>>>> (yet?) an npm project, and so does not have a
> > >> package.json.
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> The individual platform repos can get rid of it, they
> > >> will
> > >>>> just
> > >>>>>>>> need
> > >>>>>>>>>> to
> > >>>>>>>>>>>>> modify the way they `create` new projects to read the
> > >> value
> > >>>> from
> > >>>>>>>>>>>>> package.json and output it to NewProject/VERSION
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> @purplecabbage
> > >>>>>>>>>>>>> risingj.com
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
> > >>> shazron@gmail.com
> > >>>>>
> > >>>>>>>> wrote:
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>>> For iOS, the only file I can see that depends on this
> > >> is:
> > >>>>>>>>>>>>>>
> > >>>>>>>>>>>>>> 1.
> > >>
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > >>>>>>>>>>>>>>
> > >>>>>>>>>>>>>> Not sure of the alternative.
> > >>>>>>>>>>>>>>
> > >>>>>>>>>>>>>> This references it but can be removed:
> > >>>> https://github.com/apache/cordova-ios/blob/master/bin/create
> > >>>>>>>>>>>>>>
> > >>>>>>>>>>>>>>
> > >>>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > >>>>>>>>>> stevengill97@gmail.com
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>>> wrote:
> > >>>>>>>>>>>>>>> Most of our repos have a package.json. It keeps track
> > >>> of
> > >>>>>>>>>> versions. I
> > >>>>>>>>>>>>>> think
> > >>>>>>>>>>>>>>> we should work towards removing the VERSION files
> > >> from
> > >>>> the
> > >>>>>>>> repos
> > >>>>>>>>>> we
> > >>>>>>>>>>>>> can.
> > >>>>>>>>>>>>>>>
> > >>>>>>>>>>>>>>> Thoughts?
> > >>>>>>>>>>>>>>>
> > >>>>>>>>>>>>>>> This would require some changes to coho so it doesn't
> > >>>> try to
> > >>>>>>>>>> update
> > >>>>>>>>>>> the
> > >>>>>>>>>>>>>>> version file when doing releases.
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Carlos Santana
> > >>> <cs...@gmail.com>
> > >>
> >
>
Re: Remove VERSION file from repos
Posted by Steven Gill <st...@gmail.com>.
Just a quick update to this.
Coho now updates the version script for the following platforms:
Android
Amazon-fireos
Ubuntu
Firefoxos
Blackberry
If coho is being used for releases, I think this is the way to go. iOS,
windows and wp8 are the only remaining ones.
Line to edit in coho:
https://github.com/apache/cordova-coho/blob/master/src/cadance-release.js#L124
Sample version script:
https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/version
Let me know if you are going to make this change for your platforms. I will
need to copy it over to my platform-release file which will replace cadence
release after 3.6.0:
https://github.com/stevengill/cordova-coho/blob/cb-7224/src/platform-release.js#L124
On Thu, Aug 14, 2014 at 10:15 AM, purplecabbage <pu...@gmail.com>
wrote:
>
>
> > On Aug 14, 2014, at 4:09 AM, Ian Clelland <ic...@chromium.org>
> wrote:
> >
> > +1 -- there's little value in trying to derive something at runtime that
> > should just be hard-coded. (And even if we didn't have coho, we could set
> > it manually without too much effort. :) )
>
> If we remember to.
> +0
>
>
> >
> >
> >> On Wed, Aug 13, 2014 at 8:28 PM, Steven Gill <st...@gmail.com>
> wrote:
> >>
> >> Using android's method of doing this doesn't seem so bad to me.
> >>
> >> Version script has hard coded value that coho sets when doing a release.
> >> Seems to be working fine as long as coho is used for releasing.
> >>
> >> Thoughts?
> >>
> >>
> >> On Wed, Aug 13, 2014 at 1:44 PM, Carlos Santana <cs...@gmail.com>
> >> wrote:
> >>
> >>> I think having the ios platform scripts in nodejs have a side benefit
> of
> >>> being able to create ios platform on Linux and Windows.
> >>>
> >>> IBM Worklight customers use this use case, where they create ios
> cordova
> >>> app, and in Windows or Linux they use it for preview with MBS a tool
> >>> similar to Ripple, and generate a zip with the xcode project, they can
> >> use
> >>> on a Mac with XCode for final build.
> >>>
> >>> The use case is also similar to create an ios platform app and preview
> in
> >>> App Harness like PhoneGap Developer.
> >>>
> >>> just my two cents.
> >>>
> >>>
> >>>
> >>>> On Tue, Aug 12, 2014 at 4:46 PM, Shazron <sh...@gmail.com> wrote:
> >>>>
> >>>> Believe me, I want to go all node -- but all in for all scripts --
> >>>> which we don't have time to do yet (maybe 4.0?).
> >>>> But seeing that it's just replacing the contents of the current bash
> >>>> script with python code, it's the path of least resistance, and path
> >>>> of least potential conflict imo. No one will notice.
> >>>>
> >>>>
> >>>> On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <mm...@chromium.org>
> >>> wrote:
> >>>>> Shaz, that's technically true, but how many users actually use that
> >>> path
> >>>>> these days?
> >>>>>
> >>>>> I thought the last stats overwhelmingly suggest our users are
> >> drinking
> >>>> the
> >>>>> kool-aid and using cli, node, etc.
> >>>>>
> >>>>>
> >>>>>> On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com> wrote:
> >>>>>>
> >>>>>> Not if they are installed manually. It's not worth having some
> >>>>>> dependency just to read a version, that's nuts.
> >>>>>>
> >>>>>> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com>
> >>> wrote:
> >>>>>>> the non-cordova cli path depends on node to install/uninstall
> >>> plugins
> >>>>>>>
> >>>>>>> @purplecabbage
> >>>>>>> risingj.com
> >>>>>>>
> >>>>>>>
> >>>>>>> On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com>
> >> wrote:
> >>>>>>>
> >>>>>>>> Of course I considered nodejs, but no, this is for the
> >> non-cordova
> >>>> CLI
> >>>>>>>> path, which does not need another dependency.
> >>>>>>>>
> >>>>>>>> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <purplecabbage@gmail.com
> >>>
> >>>>>> wrote:
> >>>>>>>>> Yeah, if you are going to replace bash, replace it with nodejs!
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> @purplecabbage
> >>>>>>>>> risingj.com
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> >>>> wrote:
> >>>>>>>>>
> >>>>>>>>>> Have you considered writing a small node script to pass the
> >>> json?
> >>>>>> This
> >>>>>>>>>> would make it as simple as requiring in the package json an
> >>> piping
> >>>>>> the
> >>>>>>>>>> relevant info to stdout
> >>>>>>>>>> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com>
> >> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> Yeah I value life and my sanity - I'll probably replace the
> >>> bash
> >>>>>>>>>>> script with python
> >>>>>>>>>>>
> >>>>>>>>>>> On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> >>>> lorin.beer@gmail.com
> >>>>>>>
> >>>>>>>>>> wrote:
> >>>>>>>>>>>> one source for version information is better
> >>>>>>>>>>>>
> >>>>>>>>>>>> although parsing json with bash scripts seems janky
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> >>>> purplecabbage@gmail.com
> >>>>>>>
> >>>>>>>>>> wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>>> I think it still needs to exist in an output project ...
> >>>> which
> >>>>>> is
> >>>>>>>> not
> >>>>>>>>>>>>> (yet?) an npm project, and so does not have a
> >> package.json.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> The individual platform repos can get rid of it, they
> >> will
> >>>> just
> >>>>>>>> need
> >>>>>>>>>> to
> >>>>>>>>>>>>> modify the way they `create` new projects to read the
> >> value
> >>>> from
> >>>>>>>>>>>>> package.json and output it to NewProject/VERSION
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> @purplecabbage
> >>>>>>>>>>>>> risingj.com
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
> >>> shazron@gmail.com
> >>>>>
> >>>>>>>> wrote:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>> For iOS, the only file I can see that depends on this
> >> is:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> 1.
> >>
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> Not sure of the alternative.
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> This references it but can be removed:
> >>>> https://github.com/apache/cordova-ios/blob/master/bin/create
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> >>>>>>>>>> stevengill97@gmail.com
> >>>>>>>>>>>>
> >>>>>>>>>>>>>> wrote:
> >>>>>>>>>>>>>>> Most of our repos have a package.json. It keeps track
> >>> of
> >>>>>>>>>> versions. I
> >>>>>>>>>>>>>> think
> >>>>>>>>>>>>>>> we should work towards removing the VERSION files
> >> from
> >>>> the
> >>>>>>>> repos
> >>>>>>>>>> we
> >>>>>>>>>>>>> can.
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Thoughts?
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> This would require some changes to coho so it doesn't
> >>>> try to
> >>>>>>>>>> update
> >>>>>>>>>>> the
> >>>>>>>>>>>>>>> version file when doing releases.
> >>>
> >>>
> >>>
> >>> --
> >>> Carlos Santana
> >>> <cs...@gmail.com>
> >>
>
Re: Remove VERSION file from repos
Posted by purplecabbage <pu...@gmail.com>.
> On Aug 14, 2014, at 4:09 AM, Ian Clelland <ic...@chromium.org> wrote:
>
> +1 -- there's little value in trying to derive something at runtime that
> should just be hard-coded. (And even if we didn't have coho, we could set
> it manually without too much effort. :) )
If we remember to.
+0
>
>
>> On Wed, Aug 13, 2014 at 8:28 PM, Steven Gill <st...@gmail.com> wrote:
>>
>> Using android's method of doing this doesn't seem so bad to me.
>>
>> Version script has hard coded value that coho sets when doing a release.
>> Seems to be working fine as long as coho is used for releasing.
>>
>> Thoughts?
>>
>>
>> On Wed, Aug 13, 2014 at 1:44 PM, Carlos Santana <cs...@gmail.com>
>> wrote:
>>
>>> I think having the ios platform scripts in nodejs have a side benefit of
>>> being able to create ios platform on Linux and Windows.
>>>
>>> IBM Worklight customers use this use case, where they create ios cordova
>>> app, and in Windows or Linux they use it for preview with MBS a tool
>>> similar to Ripple, and generate a zip with the xcode project, they can
>> use
>>> on a Mac with XCode for final build.
>>>
>>> The use case is also similar to create an ios platform app and preview in
>>> App Harness like PhoneGap Developer.
>>>
>>> just my two cents.
>>>
>>>
>>>
>>>> On Tue, Aug 12, 2014 at 4:46 PM, Shazron <sh...@gmail.com> wrote:
>>>>
>>>> Believe me, I want to go all node -- but all in for all scripts --
>>>> which we don't have time to do yet (maybe 4.0?).
>>>> But seeing that it's just replacing the contents of the current bash
>>>> script with python code, it's the path of least resistance, and path
>>>> of least potential conflict imo. No one will notice.
>>>>
>>>>
>>>> On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <mm...@chromium.org>
>>> wrote:
>>>>> Shaz, that's technically true, but how many users actually use that
>>> path
>>>>> these days?
>>>>>
>>>>> I thought the last stats overwhelmingly suggest our users are
>> drinking
>>>> the
>>>>> kool-aid and using cli, node, etc.
>>>>>
>>>>>
>>>>>> On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com> wrote:
>>>>>>
>>>>>> Not if they are installed manually. It's not worth having some
>>>>>> dependency just to read a version, that's nuts.
>>>>>>
>>>>>> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com>
>>> wrote:
>>>>>>> the non-cordova cli path depends on node to install/uninstall
>>> plugins
>>>>>>>
>>>>>>> @purplecabbage
>>>>>>> risingj.com
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com>
>> wrote:
>>>>>>>
>>>>>>>> Of course I considered nodejs, but no, this is for the
>> non-cordova
>>>> CLI
>>>>>>>> path, which does not need another dependency.
>>>>>>>>
>>>>>>>> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <purplecabbage@gmail.com
>>>
>>>>>> wrote:
>>>>>>>>> Yeah, if you are going to replace bash, replace it with nodejs!
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> @purplecabbage
>>>>>>>>> risingj.com
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Have you considered writing a small node script to pass the
>>> json?
>>>>>> This
>>>>>>>>>> would make it as simple as requiring in the package json an
>>> piping
>>>>>> the
>>>>>>>>>> relevant info to stdout
>>>>>>>>>> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com>
>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Yeah I value life and my sanity - I'll probably replace the
>>> bash
>>>>>>>>>>> script with python
>>>>>>>>>>>
>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
>>>> lorin.beer@gmail.com
>>>>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>>> one source for version information is better
>>>>>>>>>>>>
>>>>>>>>>>>> although parsing json with bash scripts seems janky
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
>>>> purplecabbage@gmail.com
>>>>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> I think it still needs to exist in an output project ...
>>>> which
>>>>>> is
>>>>>>>> not
>>>>>>>>>>>>> (yet?) an npm project, and so does not have a
>> package.json.
>>>>>>>>>>>>>
>>>>>>>>>>>>> The individual platform repos can get rid of it, they
>> will
>>>> just
>>>>>>>> need
>>>>>>>>>> to
>>>>>>>>>>>>> modify the way they `create` new projects to read the
>> value
>>>> from
>>>>>>>>>>>>> package.json and output it to NewProject/VERSION
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> @purplecabbage
>>>>>>>>>>>>> risingj.com
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
>>> shazron@gmail.com
>>>>>
>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> For iOS, the only file I can see that depends on this
>> is:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> 1.
>> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Not sure of the alternative.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> This references it but can be removed:
>>>> https://github.com/apache/cordova-ios/blob/master/bin/create
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
>>>>>>>>>> stevengill97@gmail.com
>>>>>>>>>>>>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>> Most of our repos have a package.json. It keeps track
>>> of
>>>>>>>>>> versions. I
>>>>>>>>>>>>>> think
>>>>>>>>>>>>>>> we should work towards removing the VERSION files
>> from
>>>> the
>>>>>>>> repos
>>>>>>>>>> we
>>>>>>>>>>>>> can.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Thoughts?
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> This would require some changes to coho so it doesn't
>>>> try to
>>>>>>>>>> update
>>>>>>>>>>> the
>>>>>>>>>>>>>>> version file when doing releases.
>>>
>>>
>>>
>>> --
>>> Carlos Santana
>>> <cs...@gmail.com>
>>
Re: Remove VERSION file from repos
Posted by Ian Clelland <ic...@chromium.org>.
+1 -- there's little value in trying to derive something at runtime that
should just be hard-coded. (And even if we didn't have coho, we could set
it manually without too much effort. :) )
On Wed, Aug 13, 2014 at 8:28 PM, Steven Gill <st...@gmail.com> wrote:
> Using android's method of doing this doesn't seem so bad to me.
>
> Version script has hard coded value that coho sets when doing a release.
> Seems to be working fine as long as coho is used for releasing.
>
> Thoughts?
>
>
> On Wed, Aug 13, 2014 at 1:44 PM, Carlos Santana <cs...@gmail.com>
> wrote:
>
> > I think having the ios platform scripts in nodejs have a side benefit of
> > being able to create ios platform on Linux and Windows.
> >
> > IBM Worklight customers use this use case, where they create ios cordova
> > app, and in Windows or Linux they use it for preview with MBS a tool
> > similar to Ripple, and generate a zip with the xcode project, they can
> use
> > on a Mac with XCode for final build.
> >
> > The use case is also similar to create an ios platform app and preview in
> > App Harness like PhoneGap Developer.
> >
> > just my two cents.
> >
> >
> >
> > On Tue, Aug 12, 2014 at 4:46 PM, Shazron <sh...@gmail.com> wrote:
> >
> > > Believe me, I want to go all node -- but all in for all scripts --
> > > which we don't have time to do yet (maybe 4.0?).
> > > But seeing that it's just replacing the contents of the current bash
> > > script with python code, it's the path of least resistance, and path
> > > of least potential conflict imo. No one will notice.
> > >
> > >
> > > On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <mm...@chromium.org>
> > wrote:
> > > > Shaz, that's technically true, but how many users actually use that
> > path
> > > > these days?
> > > >
> > > > I thought the last stats overwhelmingly suggest our users are
> drinking
> > > the
> > > > kool-aid and using cli, node, etc.
> > > >
> > > >
> > > > On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com> wrote:
> > > >
> > > >> Not if they are installed manually. It's not worth having some
> > > >> dependency just to read a version, that's nuts.
> > > >>
> > > >> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com>
> > wrote:
> > > >> > the non-cordova cli path depends on node to install/uninstall
> > plugins
> > > >> >
> > > >> > @purplecabbage
> > > >> > risingj.com
> > > >> >
> > > >> >
> > > >> > On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com>
> wrote:
> > > >> >
> > > >> >> Of course I considered nodejs, but no, this is for the
> non-cordova
> > > CLI
> > > >> >> path, which does not need another dependency.
> > > >> >>
> > > >> >> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <purplecabbage@gmail.com
> >
> > > >> wrote:
> > > >> >> > Yeah, if you are going to replace bash, replace it with nodejs!
> > > >> >> >
> > > >> >> >
> > > >> >> > @purplecabbage
> > > >> >> > risingj.com
> > > >> >> >
> > > >> >> >
> > > >> >> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> > > wrote:
> > > >> >> >
> > > >> >> >> Have you considered writing a small node script to pass the
> > json?
> > > >> This
> > > >> >> >> would make it as simple as requiring in the package json an
> > piping
> > > >> the
> > > >> >> >> relevant info to stdout
> > > >> >> >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com>
> wrote:
> > > >> >> >>
> > > >> >> >> > Yeah I value life and my sanity - I'll probably replace the
> > bash
> > > >> >> >> > script with python
> > > >> >> >> >
> > > >> >> >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> > > lorin.beer@gmail.com
> > > >> >
> > > >> >> >> wrote:
> > > >> >> >> > > one source for version information is better
> > > >> >> >> > >
> > > >> >> >> > > although parsing json with bash scripts seems janky
> > > >> >> >> > >
> > > >> >> >> > >
> > > >> >> >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> > > purplecabbage@gmail.com
> > > >> >
> > > >> >> >> wrote:
> > > >> >> >> > >
> > > >> >> >> > >> I think it still needs to exist in an output project ...
> > > which
> > > >> is
> > > >> >> not
> > > >> >> >> > >> (yet?) an npm project, and so does not have a
> package.json.
> > > >> >> >> > >>
> > > >> >> >> > >> The individual platform repos can get rid of it, they
> will
> > > just
> > > >> >> need
> > > >> >> >> to
> > > >> >> >> > >> modify the way they `create` new projects to read the
> value
> > > from
> > > >> >> >> > >> package.json and output it to NewProject/VERSION
> > > >> >> >> > >>
> > > >> >> >> > >>
> > > >> >> >> > >>
> > > >> >> >> > >>
> > > >> >> >> > >> @purplecabbage
> > > >> >> >> > >> risingj.com
> > > >> >> >> > >>
> > > >> >> >> > >>
> > > >> >> >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
> > shazron@gmail.com
> > > >
> > > >> >> wrote:
> > > >> >> >> > >>
> > > >> >> >> > >> > For iOS, the only file I can see that depends on this
> is:
> > > >> >> >> > >> >
> > > >> >> >> > >> > 1.
> > > >> >> >> > >> >
> > > >> >> >> > >>
> > > >> >> >> >
> > > >> >> >>
> > > >> >>
> > > >>
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > >> >> >> > >> >
> > > >> >> >> > >> > Not sure of the alternative.
> > > >> >> >> > >> >
> > > >> >> >> > >> > This references it but can be removed:
> > > >> >> >> > >> >
> > > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > >> >> >> > >> >
> > > >> >> >> > >> >
> > > >> >> >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > >> >> >> stevengill97@gmail.com
> > > >> >> >> > >
> > > >> >> >> > >> > wrote:
> > > >> >> >> > >> > > Most of our repos have a package.json. It keeps track
> > of
> > > >> >> >> versions. I
> > > >> >> >> > >> > think
> > > >> >> >> > >> > > we should work towards removing the VERSION files
> from
> > > the
> > > >> >> repos
> > > >> >> >> we
> > > >> >> >> > >> can.
> > > >> >> >> > >> > >
> > > >> >> >> > >> > > Thoughts?
> > > >> >> >> > >> > >
> > > >> >> >> > >> > > This would require some changes to coho so it doesn't
> > > try to
> > > >> >> >> update
> > > >> >> >> > the
> > > >> >> >> > >> > > version file when doing releases.
> > > >> >> >> > >> >
> > > >> >> >> > >>
> > > >> >> >> >
> > > >> >> >>
> > > >> >>
> > > >>
> > >
> >
> >
> >
> > --
> > Carlos Santana
> > <cs...@gmail.com>
> >
>
Re: Remove VERSION file from repos
Posted by Steven Gill <st...@gmail.com>.
Using android's method of doing this doesn't seem so bad to me.
Version script has hard coded value that coho sets when doing a release.
Seems to be working fine as long as coho is used for releasing.
Thoughts?
On Wed, Aug 13, 2014 at 1:44 PM, Carlos Santana <cs...@gmail.com>
wrote:
> I think having the ios platform scripts in nodejs have a side benefit of
> being able to create ios platform on Linux and Windows.
>
> IBM Worklight customers use this use case, where they create ios cordova
> app, and in Windows or Linux they use it for preview with MBS a tool
> similar to Ripple, and generate a zip with the xcode project, they can use
> on a Mac with XCode for final build.
>
> The use case is also similar to create an ios platform app and preview in
> App Harness like PhoneGap Developer.
>
> just my two cents.
>
>
>
> On Tue, Aug 12, 2014 at 4:46 PM, Shazron <sh...@gmail.com> wrote:
>
> > Believe me, I want to go all node -- but all in for all scripts --
> > which we don't have time to do yet (maybe 4.0?).
> > But seeing that it's just replacing the contents of the current bash
> > script with python code, it's the path of least resistance, and path
> > of least potential conflict imo. No one will notice.
> >
> >
> > On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> > > Shaz, that's technically true, but how many users actually use that
> path
> > > these days?
> > >
> > > I thought the last stats overwhelmingly suggest our users are drinking
> > the
> > > kool-aid and using cli, node, etc.
> > >
> > >
> > > On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com> wrote:
> > >
> > >> Not if they are installed manually. It's not worth having some
> > >> dependency just to read a version, that's nuts.
> > >>
> > >> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com>
> wrote:
> > >> > the non-cordova cli path depends on node to install/uninstall
> plugins
> > >> >
> > >> > @purplecabbage
> > >> > risingj.com
> > >> >
> > >> >
> > >> > On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com> wrote:
> > >> >
> > >> >> Of course I considered nodejs, but no, this is for the non-cordova
> > CLI
> > >> >> path, which does not need another dependency.
> > >> >>
> > >> >> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
> > >> wrote:
> > >> >> > Yeah, if you are going to replace bash, replace it with nodejs!
> > >> >> >
> > >> >> >
> > >> >> > @purplecabbage
> > >> >> > risingj.com
> > >> >> >
> > >> >> >
> > >> >> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> > wrote:
> > >> >> >
> > >> >> >> Have you considered writing a small node script to pass the
> json?
> > >> This
> > >> >> >> would make it as simple as requiring in the package json an
> piping
> > >> the
> > >> >> >> relevant info to stdout
> > >> >> >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> > >> >> >>
> > >> >> >> > Yeah I value life and my sanity - I'll probably replace the
> bash
> > >> >> >> > script with python
> > >> >> >> >
> > >> >> >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> > lorin.beer@gmail.com
> > >> >
> > >> >> >> wrote:
> > >> >> >> > > one source for version information is better
> > >> >> >> > >
> > >> >> >> > > although parsing json with bash scripts seems janky
> > >> >> >> > >
> > >> >> >> > >
> > >> >> >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> > purplecabbage@gmail.com
> > >> >
> > >> >> >> wrote:
> > >> >> >> > >
> > >> >> >> > >> I think it still needs to exist in an output project ...
> > which
> > >> is
> > >> >> not
> > >> >> >> > >> (yet?) an npm project, and so does not have a package.json.
> > >> >> >> > >>
> > >> >> >> > >> The individual platform repos can get rid of it, they will
> > just
> > >> >> need
> > >> >> >> to
> > >> >> >> > >> modify the way they `create` new projects to read the value
> > from
> > >> >> >> > >> package.json and output it to NewProject/VERSION
> > >> >> >> > >>
> > >> >> >> > >>
> > >> >> >> > >>
> > >> >> >> > >>
> > >> >> >> > >> @purplecabbage
> > >> >> >> > >> risingj.com
> > >> >> >> > >>
> > >> >> >> > >>
> > >> >> >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
> shazron@gmail.com
> > >
> > >> >> wrote:
> > >> >> >> > >>
> > >> >> >> > >> > For iOS, the only file I can see that depends on this is:
> > >> >> >> > >> >
> > >> >> >> > >> > 1.
> > >> >> >> > >> >
> > >> >> >> > >>
> > >> >> >> >
> > >> >> >>
> > >> >>
> > >>
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > >> >> >> > >> >
> > >> >> >> > >> > Not sure of the alternative.
> > >> >> >> > >> >
> > >> >> >> > >> > This references it but can be removed:
> > >> >> >> > >> >
> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > >> >> >> > >> >
> > >> >> >> > >> >
> > >> >> >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > >> >> >> stevengill97@gmail.com
> > >> >> >> > >
> > >> >> >> > >> > wrote:
> > >> >> >> > >> > > Most of our repos have a package.json. It keeps track
> of
> > >> >> >> versions. I
> > >> >> >> > >> > think
> > >> >> >> > >> > > we should work towards removing the VERSION files from
> > the
> > >> >> repos
> > >> >> >> we
> > >> >> >> > >> can.
> > >> >> >> > >> > >
> > >> >> >> > >> > > Thoughts?
> > >> >> >> > >> > >
> > >> >> >> > >> > > This would require some changes to coho so it doesn't
> > try to
> > >> >> >> update
> > >> >> >> > the
> > >> >> >> > >> > > version file when doing releases.
> > >> >> >> > >> >
> > >> >> >> > >>
> > >> >> >> >
> > >> >> >>
> > >> >>
> > >>
> >
>
>
>
> --
> Carlos Santana
> <cs...@gmail.com>
>
Re: Remove VERSION file from repos
Posted by Carlos Santana <cs...@gmail.com>.
I think having the ios platform scripts in nodejs have a side benefit of
being able to create ios platform on Linux and Windows.
IBM Worklight customers use this use case, where they create ios cordova
app, and in Windows or Linux they use it for preview with MBS a tool
similar to Ripple, and generate a zip with the xcode project, they can use
on a Mac with XCode for final build.
The use case is also similar to create an ios platform app and preview in
App Harness like PhoneGap Developer.
just my two cents.
On Tue, Aug 12, 2014 at 4:46 PM, Shazron <sh...@gmail.com> wrote:
> Believe me, I want to go all node -- but all in for all scripts --
> which we don't have time to do yet (maybe 4.0?).
> But seeing that it's just replacing the contents of the current bash
> script with python code, it's the path of least resistance, and path
> of least potential conflict imo. No one will notice.
>
>
> On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <mm...@chromium.org> wrote:
> > Shaz, that's technically true, but how many users actually use that path
> > these days?
> >
> > I thought the last stats overwhelmingly suggest our users are drinking
> the
> > kool-aid and using cli, node, etc.
> >
> >
> > On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com> wrote:
> >
> >> Not if they are installed manually. It's not worth having some
> >> dependency just to read a version, that's nuts.
> >>
> >> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com> wrote:
> >> > the non-cordova cli path depends on node to install/uninstall plugins
> >> >
> >> > @purplecabbage
> >> > risingj.com
> >> >
> >> >
> >> > On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com> wrote:
> >> >
> >> >> Of course I considered nodejs, but no, this is for the non-cordova
> CLI
> >> >> path, which does not need another dependency.
> >> >>
> >> >> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
> >> wrote:
> >> >> > Yeah, if you are going to replace bash, replace it with nodejs!
> >> >> >
> >> >> >
> >> >> > @purplecabbage
> >> >> > risingj.com
> >> >> >
> >> >> >
> >> >> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> wrote:
> >> >> >
> >> >> >> Have you considered writing a small node script to pass the json?
> >> This
> >> >> >> would make it as simple as requiring in the package json an piping
> >> the
> >> >> >> relevant info to stdout
> >> >> >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> >> >> >>
> >> >> >> > Yeah I value life and my sanity - I'll probably replace the bash
> >> >> >> > script with python
> >> >> >> >
> >> >> >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> lorin.beer@gmail.com
> >> >
> >> >> >> wrote:
> >> >> >> > > one source for version information is better
> >> >> >> > >
> >> >> >> > > although parsing json with bash scripts seems janky
> >> >> >> > >
> >> >> >> > >
> >> >> >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> purplecabbage@gmail.com
> >> >
> >> >> >> wrote:
> >> >> >> > >
> >> >> >> > >> I think it still needs to exist in an output project ...
> which
> >> is
> >> >> not
> >> >> >> > >> (yet?) an npm project, and so does not have a package.json.
> >> >> >> > >>
> >> >> >> > >> The individual platform repos can get rid of it, they will
> just
> >> >> need
> >> >> >> to
> >> >> >> > >> modify the way they `create` new projects to read the value
> from
> >> >> >> > >> package.json and output it to NewProject/VERSION
> >> >> >> > >>
> >> >> >> > >>
> >> >> >> > >>
> >> >> >> > >>
> >> >> >> > >> @purplecabbage
> >> >> >> > >> risingj.com
> >> >> >> > >>
> >> >> >> > >>
> >> >> >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <shazron@gmail.com
> >
> >> >> wrote:
> >> >> >> > >>
> >> >> >> > >> > For iOS, the only file I can see that depends on this is:
> >> >> >> > >> >
> >> >> >> > >> > 1.
> >> >> >> > >> >
> >> >> >> > >>
> >> >> >> >
> >> >> >>
> >> >>
> >>
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> >> >> >> > >> >
> >> >> >> > >> > Not sure of the alternative.
> >> >> >> > >> >
> >> >> >> > >> > This references it but can be removed:
> >> >> >> > >> >
> https://github.com/apache/cordova-ios/blob/master/bin/create
> >> >> >> > >> >
> >> >> >> > >> >
> >> >> >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> >> >> >> stevengill97@gmail.com
> >> >> >> > >
> >> >> >> > >> > wrote:
> >> >> >> > >> > > Most of our repos have a package.json. It keeps track of
> >> >> >> versions. I
> >> >> >> > >> > think
> >> >> >> > >> > > we should work towards removing the VERSION files from
> the
> >> >> repos
> >> >> >> we
> >> >> >> > >> can.
> >> >> >> > >> > >
> >> >> >> > >> > > Thoughts?
> >> >> >> > >> > >
> >> >> >> > >> > > This would require some changes to coho so it doesn't
> try to
> >> >> >> update
> >> >> >> > the
> >> >> >> > >> > > version file when doing releases.
> >> >> >> > >> >
> >> >> >> > >>
> >> >> >> >
> >> >> >>
> >> >>
> >>
>
--
Carlos Santana
<cs...@gmail.com>
Re: Remove VERSION file from repos
Posted by Shazron <sh...@gmail.com>.
Believe me, I want to go all node -- but all in for all scripts --
which we don't have time to do yet (maybe 4.0?).
But seeing that it's just replacing the contents of the current bash
script with python code, it's the path of least resistance, and path
of least potential conflict imo. No one will notice.
On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <mm...@chromium.org> wrote:
> Shaz, that's technically true, but how many users actually use that path
> these days?
>
> I thought the last stats overwhelmingly suggest our users are drinking the
> kool-aid and using cli, node, etc.
>
>
> On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com> wrote:
>
>> Not if they are installed manually. It's not worth having some
>> dependency just to read a version, that's nuts.
>>
>> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com> wrote:
>> > the non-cordova cli path depends on node to install/uninstall plugins
>> >
>> > @purplecabbage
>> > risingj.com
>> >
>> >
>> > On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com> wrote:
>> >
>> >> Of course I considered nodejs, but no, this is for the non-cordova CLI
>> >> path, which does not need another dependency.
>> >>
>> >> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
>> wrote:
>> >> > Yeah, if you are going to replace bash, replace it with nodejs!
>> >> >
>> >> >
>> >> > @purplecabbage
>> >> > risingj.com
>> >> >
>> >> >
>> >> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
>> >> >
>> >> >> Have you considered writing a small node script to pass the json?
>> This
>> >> >> would make it as simple as requiring in the package json an piping
>> the
>> >> >> relevant info to stdout
>> >> >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
>> >> >>
>> >> >> > Yeah I value life and my sanity - I'll probably replace the bash
>> >> >> > script with python
>> >> >> >
>> >> >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lorin.beer@gmail.com
>> >
>> >> >> wrote:
>> >> >> > > one source for version information is better
>> >> >> > >
>> >> >> > > although parsing json with bash scripts seems janky
>> >> >> > >
>> >> >> > >
>> >> >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <purplecabbage@gmail.com
>> >
>> >> >> wrote:
>> >> >> > >
>> >> >> > >> I think it still needs to exist in an output project ... which
>> is
>> >> not
>> >> >> > >> (yet?) an npm project, and so does not have a package.json.
>> >> >> > >>
>> >> >> > >> The individual platform repos can get rid of it, they will just
>> >> need
>> >> >> to
>> >> >> > >> modify the way they `create` new projects to read the value from
>> >> >> > >> package.json and output it to NewProject/VERSION
>> >> >> > >>
>> >> >> > >>
>> >> >> > >>
>> >> >> > >>
>> >> >> > >> @purplecabbage
>> >> >> > >> risingj.com
>> >> >> > >>
>> >> >> > >>
>> >> >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
>> >> wrote:
>> >> >> > >>
>> >> >> > >> > For iOS, the only file I can see that depends on this is:
>> >> >> > >> >
>> >> >> > >> > 1.
>> >> >> > >> >
>> >> >> > >>
>> >> >> >
>> >> >>
>> >>
>> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>> >> >> > >> >
>> >> >> > >> > Not sure of the alternative.
>> >> >> > >> >
>> >> >> > >> > This references it but can be removed:
>> >> >> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
>> >> >> > >> >
>> >> >> > >> >
>> >> >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
>> >> >> stevengill97@gmail.com
>> >> >> > >
>> >> >> > >> > wrote:
>> >> >> > >> > > Most of our repos have a package.json. It keeps track of
>> >> >> versions. I
>> >> >> > >> > think
>> >> >> > >> > > we should work towards removing the VERSION files from the
>> >> repos
>> >> >> we
>> >> >> > >> can.
>> >> >> > >> > >
>> >> >> > >> > > Thoughts?
>> >> >> > >> > >
>> >> >> > >> > > This would require some changes to coho so it doesn't try to
>> >> >> update
>> >> >> > the
>> >> >> > >> > > version file when doing releases.
>> >> >> > >> >
>> >> >> > >>
>> >> >> >
>> >> >>
>> >>
>>
Re: Remove VERSION file from repos
Posted by Michal Mocny <mm...@chromium.org>.
Shaz, that's technically true, but how many users actually use that path
these days?
I thought the last stats overwhelmingly suggest our users are drinking the
kool-aid and using cli, node, etc.
On Tue, Aug 12, 2014 at 4:19 PM, Shazron <sh...@gmail.com> wrote:
> Not if they are installed manually. It's not worth having some
> dependency just to read a version, that's nuts.
>
> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com> wrote:
> > the non-cordova cli path depends on node to install/uninstall plugins
> >
> > @purplecabbage
> > risingj.com
> >
> >
> > On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com> wrote:
> >
> >> Of course I considered nodejs, but no, this is for the non-cordova CLI
> >> path, which does not need another dependency.
> >>
> >> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
> wrote:
> >> > Yeah, if you are going to replace bash, replace it with nodejs!
> >> >
> >> >
> >> > @purplecabbage
> >> > risingj.com
> >> >
> >> >
> >> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
> >> >
> >> >> Have you considered writing a small node script to pass the json?
> This
> >> >> would make it as simple as requiring in the package json an piping
> the
> >> >> relevant info to stdout
> >> >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> >> >>
> >> >> > Yeah I value life and my sanity - I'll probably replace the bash
> >> >> > script with python
> >> >> >
> >> >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lorin.beer@gmail.com
> >
> >> >> wrote:
> >> >> > > one source for version information is better
> >> >> > >
> >> >> > > although parsing json with bash scripts seems janky
> >> >> > >
> >> >> > >
> >> >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <purplecabbage@gmail.com
> >
> >> >> wrote:
> >> >> > >
> >> >> > >> I think it still needs to exist in an output project ... which
> is
> >> not
> >> >> > >> (yet?) an npm project, and so does not have a package.json.
> >> >> > >>
> >> >> > >> The individual platform repos can get rid of it, they will just
> >> need
> >> >> to
> >> >> > >> modify the way they `create` new projects to read the value from
> >> >> > >> package.json and output it to NewProject/VERSION
> >> >> > >>
> >> >> > >>
> >> >> > >>
> >> >> > >>
> >> >> > >> @purplecabbage
> >> >> > >> risingj.com
> >> >> > >>
> >> >> > >>
> >> >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> >> wrote:
> >> >> > >>
> >> >> > >> > For iOS, the only file I can see that depends on this is:
> >> >> > >> >
> >> >> > >> > 1.
> >> >> > >> >
> >> >> > >>
> >> >> >
> >> >>
> >>
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> >> >> > >> >
> >> >> > >> > Not sure of the alternative.
> >> >> > >> >
> >> >> > >> > This references it but can be removed:
> >> >> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> >> >> > >> >
> >> >> > >> >
> >> >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> >> >> stevengill97@gmail.com
> >> >> > >
> >> >> > >> > wrote:
> >> >> > >> > > Most of our repos have a package.json. It keeps track of
> >> >> versions. I
> >> >> > >> > think
> >> >> > >> > > we should work towards removing the VERSION files from the
> >> repos
> >> >> we
> >> >> > >> can.
> >> >> > >> > >
> >> >> > >> > > Thoughts?
> >> >> > >> > >
> >> >> > >> > > This would require some changes to coho so it doesn't try to
> >> >> update
> >> >> > the
> >> >> > >> > > version file when doing releases.
> >> >> > >> >
> >> >> > >>
> >> >> >
> >> >>
> >>
>
Re: Remove VERSION file from repos
Posted by Shazron <sh...@gmail.com>.
Not if they are installed manually. It's not worth having some
dependency just to read a version, that's nuts.
On Tue, Aug 12, 2014 at 1:15 PM, Jesse <pu...@gmail.com> wrote:
> the non-cordova cli path depends on node to install/uninstall plugins
>
> @purplecabbage
> risingj.com
>
>
> On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com> wrote:
>
>> Of course I considered nodejs, but no, this is for the non-cordova CLI
>> path, which does not need another dependency.
>>
>> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com> wrote:
>> > Yeah, if you are going to replace bash, replace it with nodejs!
>> >
>> >
>> > @purplecabbage
>> > risingj.com
>> >
>> >
>> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
>> >
>> >> Have you considered writing a small node script to pass the json? This
>> >> would make it as simple as requiring in the package json an piping the
>> >> relevant info to stdout
>> >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
>> >>
>> >> > Yeah I value life and my sanity - I'll probably replace the bash
>> >> > script with python
>> >> >
>> >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com>
>> >> wrote:
>> >> > > one source for version information is better
>> >> > >
>> >> > > although parsing json with bash scripts seems janky
>> >> > >
>> >> > >
>> >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com>
>> >> wrote:
>> >> > >
>> >> > >> I think it still needs to exist in an output project ... which is
>> not
>> >> > >> (yet?) an npm project, and so does not have a package.json.
>> >> > >>
>> >> > >> The individual platform repos can get rid of it, they will just
>> need
>> >> to
>> >> > >> modify the way they `create` new projects to read the value from
>> >> > >> package.json and output it to NewProject/VERSION
>> >> > >>
>> >> > >>
>> >> > >>
>> >> > >>
>> >> > >> @purplecabbage
>> >> > >> risingj.com
>> >> > >>
>> >> > >>
>> >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
>> wrote:
>> >> > >>
>> >> > >> > For iOS, the only file I can see that depends on this is:
>> >> > >> >
>> >> > >> > 1.
>> >> > >> >
>> >> > >>
>> >> >
>> >>
>> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>> >> > >> >
>> >> > >> > Not sure of the alternative.
>> >> > >> >
>> >> > >> > This references it but can be removed:
>> >> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
>> >> > >> >
>> >> > >> >
>> >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
>> >> stevengill97@gmail.com
>> >> > >
>> >> > >> > wrote:
>> >> > >> > > Most of our repos have a package.json. It keeps track of
>> >> versions. I
>> >> > >> > think
>> >> > >> > > we should work towards removing the VERSION files from the
>> repos
>> >> we
>> >> > >> can.
>> >> > >> > >
>> >> > >> > > Thoughts?
>> >> > >> > >
>> >> > >> > > This would require some changes to coho so it doesn't try to
>> >> update
>> >> > the
>> >> > >> > > version file when doing releases.
>> >> > >> >
>> >> > >>
>> >> >
>> >>
>>
Re: Remove VERSION file from repos
Posted by Jesse <pu...@gmail.com>.
the non-cordova cli path depends on node to install/uninstall plugins
@purplecabbage
risingj.com
On Tue, Aug 12, 2014 at 1:08 PM, Shazron <sh...@gmail.com> wrote:
> Of course I considered nodejs, but no, this is for the non-cordova CLI
> path, which does not need another dependency.
>
> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com> wrote:
> > Yeah, if you are going to replace bash, replace it with nodejs!
> >
> >
> > @purplecabbage
> > risingj.com
> >
> >
> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
> >
> >> Have you considered writing a small node script to pass the json? This
> >> would make it as simple as requiring in the package json an piping the
> >> relevant info to stdout
> >> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> >>
> >> > Yeah I value life and my sanity - I'll probably replace the bash
> >> > script with python
> >> >
> >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com>
> >> wrote:
> >> > > one source for version information is better
> >> > >
> >> > > although parsing json with bash scripts seems janky
> >> > >
> >> > >
> >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com>
> >> wrote:
> >> > >
> >> > >> I think it still needs to exist in an output project ... which is
> not
> >> > >> (yet?) an npm project, and so does not have a package.json.
> >> > >>
> >> > >> The individual platform repos can get rid of it, they will just
> need
> >> to
> >> > >> modify the way they `create` new projects to read the value from
> >> > >> package.json and output it to NewProject/VERSION
> >> > >>
> >> > >>
> >> > >>
> >> > >>
> >> > >> @purplecabbage
> >> > >> risingj.com
> >> > >>
> >> > >>
> >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> wrote:
> >> > >>
> >> > >> > For iOS, the only file I can see that depends on this is:
> >> > >> >
> >> > >> > 1.
> >> > >> >
> >> > >>
> >> >
> >>
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> >> > >> >
> >> > >> > Not sure of the alternative.
> >> > >> >
> >> > >> > This references it but can be removed:
> >> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> >> > >> >
> >> > >> >
> >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> >> stevengill97@gmail.com
> >> > >
> >> > >> > wrote:
> >> > >> > > Most of our repos have a package.json. It keeps track of
> >> versions. I
> >> > >> > think
> >> > >> > > we should work towards removing the VERSION files from the
> repos
> >> we
> >> > >> can.
> >> > >> > >
> >> > >> > > Thoughts?
> >> > >> > >
> >> > >> > > This would require some changes to coho so it doesn't try to
> >> update
> >> > the
> >> > >> > > version file when doing releases.
> >> > >> >
> >> > >>
> >> >
> >>
>
Re: Remove VERSION file from repos
Posted by Shazron <sh...@gmail.com>.
Of course I considered nodejs, but no, this is for the non-cordova CLI
path, which does not need another dependency.
On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com> wrote:
> Yeah, if you are going to replace bash, replace it with nodejs!
>
>
> @purplecabbage
> risingj.com
>
>
> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
>
>> Have you considered writing a small node script to pass the json? This
>> would make it as simple as requiring in the package json an piping the
>> relevant info to stdout
>> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
>>
>> > Yeah I value life and my sanity - I'll probably replace the bash
>> > script with python
>> >
>> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com>
>> wrote:
>> > > one source for version information is better
>> > >
>> > > although parsing json with bash scripts seems janky
>> > >
>> > >
>> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com>
>> wrote:
>> > >
>> > >> I think it still needs to exist in an output project ... which is not
>> > >> (yet?) an npm project, and so does not have a package.json.
>> > >>
>> > >> The individual platform repos can get rid of it, they will just need
>> to
>> > >> modify the way they `create` new projects to read the value from
>> > >> package.json and output it to NewProject/VERSION
>> > >>
>> > >>
>> > >>
>> > >>
>> > >> @purplecabbage
>> > >> risingj.com
>> > >>
>> > >>
>> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com> wrote:
>> > >>
>> > >> > For iOS, the only file I can see that depends on this is:
>> > >> >
>> > >> > 1.
>> > >> >
>> > >>
>> >
>> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>> > >> >
>> > >> > Not sure of the alternative.
>> > >> >
>> > >> > This references it but can be removed:
>> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
>> > >> >
>> > >> >
>> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
>> stevengill97@gmail.com
>> > >
>> > >> > wrote:
>> > >> > > Most of our repos have a package.json. It keeps track of
>> versions. I
>> > >> > think
>> > >> > > we should work towards removing the VERSION files from the repos
>> we
>> > >> can.
>> > >> > >
>> > >> > > Thoughts?
>> > >> > >
>> > >> > > This would require some changes to coho so it doesn't try to
>> update
>> > the
>> > >> > > version file when doing releases.
>> > >> >
>> > >>
>> >
>>
Re: Remove VERSION file from repos
Posted by Myles Borins <my...@famo.us>.
But what should we store in the shed?
On Aug 12, 2014 12:33 PM, "Brian LeRoux" <b...@brian.io> wrote:
> In another life I'd love to paint that shed.
>
>
>
> On Tue, Aug 12, 2014 at 12:25 PM, Jesse <pu...@gmail.com> wrote:
>
> > Michal, exactly!
> > Brian, hilarious, I was implying rewrite ALL the platform scripts in
> nodejs
> > ... as was recently done for cordova-windows. May be more work than it is
> > worth though.
> >
> > @purplecabbage
> > risingj.com
> >
> >
> > On Tue, Aug 12, 2014 at 12:17 PM, Myles Borins <my...@famo.us> wrote:
> >
> > > Ahhhh, I forgot to shim my path with a sense of humor... Oops!
> > > On Aug 12, 2014 12:16 PM, "Brian LeRoux" <b...@brian.io> wrote:
> > >
> > > > main benefit was humor though an argument could be made for other
> ones
> > ;)
> > > >
> > > >
> > > >
> > > > On Tue, Aug 12, 2014 at 12:06 PM, Myles Borins <my...@famo.us>
> wrote:
> > > >
> > > > > Brian, would there be any benefit to using bash to call node rather
> > > than
> > > > a
> > > > > script that started with #! /bin/env node?
> > > > > On Aug 12, 2014 12:01 PM, "Brian LeRoux" <b...@brian.io> wrote:
> > > > >
> > > > > > OR BOTH
> > > > > >
> > > > > > #!/bin/sh
> > > > > > node -e 'console.log(require("./package.json").version)'
> > > > > >
> > > > > >
> > > > > > On Tue, Aug 12, 2014 at 11:52 AM, Jesse <purplecabbage@gmail.com
> >
> > > > wrote:
> > > > > >
> > > > > > > Yeah, if you are going to replace bash, replace it with nodejs!
> > > > > > >
> > > > > > >
> > > > > > > @purplecabbage
> > > > > > > risingj.com
> > > > > > >
> > > > > > >
> > > > > > > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> > > > wrote:
> > > > > > >
> > > > > > > > Have you considered writing a small node script to pass the
> > json?
> > > > > This
> > > > > > > > would make it as simple as requiring in the package json an
> > > piping
> > > > > the
> > > > > > > > relevant info to stdout
> > > > > > > > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com>
> wrote:
> > > > > > > >
> > > > > > > > > Yeah I value life and my sanity - I'll probably replace the
> > > bash
> > > > > > > > > script with python
> > > > > > > > >
> > > > > > > > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> > > > lorin.beer@gmail.com
> > > > > >
> > > > > > > > wrote:
> > > > > > > > > > one source for version information is better
> > > > > > > > > >
> > > > > > > > > > although parsing json with bash scripts seems janky
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> > > > purplecabbage@gmail.com
> > > > > >
> > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > >> I think it still needs to exist in an output project ...
> > > which
> > > > > is
> > > > > > > not
> > > > > > > > > >> (yet?) an npm project, and so does not have a
> > package.json.
> > > > > > > > > >>
> > > > > > > > > >> The individual platform repos can get rid of it, they
> will
> > > > just
> > > > > > need
> > > > > > > > to
> > > > > > > > > >> modify the way they `create` new projects to read the
> > value
> > > > from
> > > > > > > > > >> package.json and output it to NewProject/VERSION
> > > > > > > > > >>
> > > > > > > > > >>
> > > > > > > > > >>
> > > > > > > > > >>
> > > > > > > > > >> @purplecabbage
> > > > > > > > > >> risingj.com
> > > > > > > > > >>
> > > > > > > > > >>
> > > > > > > > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
> > > shazron@gmail.com>
> > > > > > > wrote:
> > > > > > > > > >>
> > > > > > > > > >> > For iOS, the only file I can see that depends on this
> > is:
> > > > > > > > > >> >
> > > > > > > > > >> > 1.
> > > > > > > > > >> >
> > > > > > > > > >>
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > > > > > > > >> >
> > > > > > > > > >> > Not sure of the alternative.
> > > > > > > > > >> >
> > > > > > > > > >> > This references it but can be removed:
> > > > > > > > > >> >
> > > > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > > > > > > > >> >
> > > > > > > > > >> >
> > > > > > > > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > > > > > > stevengill97@gmail.com
> > > > > > > > > >
> > > > > > > > > >> > wrote:
> > > > > > > > > >> > > Most of our repos have a package.json. It keeps
> track
> > of
> > > > > > > > versions. I
> > > > > > > > > >> > think
> > > > > > > > > >> > > we should work towards removing the VERSION files
> from
> > > the
> > > > > > repos
> > > > > > > > we
> > > > > > > > > >> can.
> > > > > > > > > >> > >
> > > > > > > > > >> > > Thoughts?
> > > > > > > > > >> > >
> > > > > > > > > >> > > This would require some changes to coho so it
> doesn't
> > > try
> > > > to
> > > > > > > > update
> > > > > > > > > the
> > > > > > > > > >> > > version file when doing releases.
> > > > > > > > > >> >
> > > > > > > > > >>
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Brian LeRoux <b...@brian.io>.
In another life I'd love to paint that shed.
On Tue, Aug 12, 2014 at 12:25 PM, Jesse <pu...@gmail.com> wrote:
> Michal, exactly!
> Brian, hilarious, I was implying rewrite ALL the platform scripts in nodejs
> ... as was recently done for cordova-windows. May be more work than it is
> worth though.
>
> @purplecabbage
> risingj.com
>
>
> On Tue, Aug 12, 2014 at 12:17 PM, Myles Borins <my...@famo.us> wrote:
>
> > Ahhhh, I forgot to shim my path with a sense of humor... Oops!
> > On Aug 12, 2014 12:16 PM, "Brian LeRoux" <b...@brian.io> wrote:
> >
> > > main benefit was humor though an argument could be made for other ones
> ;)
> > >
> > >
> > >
> > > On Tue, Aug 12, 2014 at 12:06 PM, Myles Borins <my...@famo.us> wrote:
> > >
> > > > Brian, would there be any benefit to using bash to call node rather
> > than
> > > a
> > > > script that started with #! /bin/env node?
> > > > On Aug 12, 2014 12:01 PM, "Brian LeRoux" <b...@brian.io> wrote:
> > > >
> > > > > OR BOTH
> > > > >
> > > > > #!/bin/sh
> > > > > node -e 'console.log(require("./package.json").version)'
> > > > >
> > > > >
> > > > > On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
> > > wrote:
> > > > >
> > > > > > Yeah, if you are going to replace bash, replace it with nodejs!
> > > > > >
> > > > > >
> > > > > > @purplecabbage
> > > > > > risingj.com
> > > > > >
> > > > > >
> > > > > > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> > > wrote:
> > > > > >
> > > > > > > Have you considered writing a small node script to pass the
> json?
> > > > This
> > > > > > > would make it as simple as requiring in the package json an
> > piping
> > > > the
> > > > > > > relevant info to stdout
> > > > > > > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> > > > > > >
> > > > > > > > Yeah I value life and my sanity - I'll probably replace the
> > bash
> > > > > > > > script with python
> > > > > > > >
> > > > > > > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> > > lorin.beer@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > > > > one source for version information is better
> > > > > > > > >
> > > > > > > > > although parsing json with bash scripts seems janky
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> > > purplecabbage@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > > > >
> > > > > > > > >> I think it still needs to exist in an output project ...
> > which
> > > > is
> > > > > > not
> > > > > > > > >> (yet?) an npm project, and so does not have a
> package.json.
> > > > > > > > >>
> > > > > > > > >> The individual platform repos can get rid of it, they will
> > > just
> > > > > need
> > > > > > > to
> > > > > > > > >> modify the way they `create` new projects to read the
> value
> > > from
> > > > > > > > >> package.json and output it to NewProject/VERSION
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >> @purplecabbage
> > > > > > > > >> risingj.com
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
> > shazron@gmail.com>
> > > > > > wrote:
> > > > > > > > >>
> > > > > > > > >> > For iOS, the only file I can see that depends on this
> is:
> > > > > > > > >> >
> > > > > > > > >> > 1.
> > > > > > > > >> >
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > > > > > > >> >
> > > > > > > > >> > Not sure of the alternative.
> > > > > > > > >> >
> > > > > > > > >> > This references it but can be removed:
> > > > > > > > >> >
> > > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > > > > > > >> >
> > > > > > > > >> >
> > > > > > > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > > > > > stevengill97@gmail.com
> > > > > > > > >
> > > > > > > > >> > wrote:
> > > > > > > > >> > > Most of our repos have a package.json. It keeps track
> of
> > > > > > > versions. I
> > > > > > > > >> > think
> > > > > > > > >> > > we should work towards removing the VERSION files from
> > the
> > > > > repos
> > > > > > > we
> > > > > > > > >> can.
> > > > > > > > >> > >
> > > > > > > > >> > > Thoughts?
> > > > > > > > >> > >
> > > > > > > > >> > > This would require some changes to coho so it doesn't
> > try
> > > to
> > > > > > > update
> > > > > > > > the
> > > > > > > > >> > > version file when doing releases.
> > > > > > > > >> >
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Jesse <pu...@gmail.com>.
Michal, exactly!
Brian, hilarious, I was implying rewrite ALL the platform scripts in nodejs
... as was recently done for cordova-windows. May be more work than it is
worth though.
@purplecabbage
risingj.com
On Tue, Aug 12, 2014 at 12:17 PM, Myles Borins <my...@famo.us> wrote:
> Ahhhh, I forgot to shim my path with a sense of humor... Oops!
> On Aug 12, 2014 12:16 PM, "Brian LeRoux" <b...@brian.io> wrote:
>
> > main benefit was humor though an argument could be made for other ones ;)
> >
> >
> >
> > On Tue, Aug 12, 2014 at 12:06 PM, Myles Borins <my...@famo.us> wrote:
> >
> > > Brian, would there be any benefit to using bash to call node rather
> than
> > a
> > > script that started with #! /bin/env node?
> > > On Aug 12, 2014 12:01 PM, "Brian LeRoux" <b...@brian.io> wrote:
> > >
> > > > OR BOTH
> > > >
> > > > #!/bin/sh
> > > > node -e 'console.log(require("./package.json").version)'
> > > >
> > > >
> > > > On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
> > wrote:
> > > >
> > > > > Yeah, if you are going to replace bash, replace it with nodejs!
> > > > >
> > > > >
> > > > > @purplecabbage
> > > > > risingj.com
> > > > >
> > > > >
> > > > > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> > wrote:
> > > > >
> > > > > > Have you considered writing a small node script to pass the json?
> > > This
> > > > > > would make it as simple as requiring in the package json an
> piping
> > > the
> > > > > > relevant info to stdout
> > > > > > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> > > > > >
> > > > > > > Yeah I value life and my sanity - I'll probably replace the
> bash
> > > > > > > script with python
> > > > > > >
> > > > > > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> > lorin.beer@gmail.com
> > > >
> > > > > > wrote:
> > > > > > > > one source for version information is better
> > > > > > > >
> > > > > > > > although parsing json with bash scripts seems janky
> > > > > > > >
> > > > > > > >
> > > > > > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> > purplecabbage@gmail.com
> > > >
> > > > > > wrote:
> > > > > > > >
> > > > > > > >> I think it still needs to exist in an output project ...
> which
> > > is
> > > > > not
> > > > > > > >> (yet?) an npm project, and so does not have a package.json.
> > > > > > > >>
> > > > > > > >> The individual platform repos can get rid of it, they will
> > just
> > > > need
> > > > > > to
> > > > > > > >> modify the way they `create` new projects to read the value
> > from
> > > > > > > >> package.json and output it to NewProject/VERSION
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> @purplecabbage
> > > > > > > >> risingj.com
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
> shazron@gmail.com>
> > > > > wrote:
> > > > > > > >>
> > > > > > > >> > For iOS, the only file I can see that depends on this is:
> > > > > > > >> >
> > > > > > > >> > 1.
> > > > > > > >> >
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > > > > > >> >
> > > > > > > >> > Not sure of the alternative.
> > > > > > > >> >
> > > > > > > >> > This references it but can be removed:
> > > > > > > >> >
> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > > > > > >> >
> > > > > > > >> >
> > > > > > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > > > > stevengill97@gmail.com
> > > > > > > >
> > > > > > > >> > wrote:
> > > > > > > >> > > Most of our repos have a package.json. It keeps track of
> > > > > > versions. I
> > > > > > > >> > think
> > > > > > > >> > > we should work towards removing the VERSION files from
> the
> > > > repos
> > > > > > we
> > > > > > > >> can.
> > > > > > > >> > >
> > > > > > > >> > > Thoughts?
> > > > > > > >> > >
> > > > > > > >> > > This would require some changes to coho so it doesn't
> try
> > to
> > > > > > update
> > > > > > > the
> > > > > > > >> > > version file when doing releases.
> > > > > > > >> >
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Brian LeRoux <b...@brian.io>.
=)
I'm a bit of a bash nerd but in seriousness we have many Windows users so
keeping it pure Node is probably the best idea.
On Tue, Aug 12, 2014 at 12:17 PM, Myles Borins <my...@famo.us> wrote:
> Ahhhh, I forgot to shim my path with a sense of humor... Oops!
> On Aug 12, 2014 12:16 PM, "Brian LeRoux" <b...@brian.io> wrote:
>
> > main benefit was humor though an argument could be made for other ones ;)
> >
> >
> >
> > On Tue, Aug 12, 2014 at 12:06 PM, Myles Borins <my...@famo.us> wrote:
> >
> > > Brian, would there be any benefit to using bash to call node rather
> than
> > a
> > > script that started with #! /bin/env node?
> > > On Aug 12, 2014 12:01 PM, "Brian LeRoux" <b...@brian.io> wrote:
> > >
> > > > OR BOTH
> > > >
> > > > #!/bin/sh
> > > > node -e 'console.log(require("./package.json").version)'
> > > >
> > > >
> > > > On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
> > wrote:
> > > >
> > > > > Yeah, if you are going to replace bash, replace it with nodejs!
> > > > >
> > > > >
> > > > > @purplecabbage
> > > > > risingj.com
> > > > >
> > > > >
> > > > > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> > wrote:
> > > > >
> > > > > > Have you considered writing a small node script to pass the json?
> > > This
> > > > > > would make it as simple as requiring in the package json an
> piping
> > > the
> > > > > > relevant info to stdout
> > > > > > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> > > > > >
> > > > > > > Yeah I value life and my sanity - I'll probably replace the
> bash
> > > > > > > script with python
> > > > > > >
> > > > > > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> > lorin.beer@gmail.com
> > > >
> > > > > > wrote:
> > > > > > > > one source for version information is better
> > > > > > > >
> > > > > > > > although parsing json with bash scripts seems janky
> > > > > > > >
> > > > > > > >
> > > > > > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> > purplecabbage@gmail.com
> > > >
> > > > > > wrote:
> > > > > > > >
> > > > > > > >> I think it still needs to exist in an output project ...
> which
> > > is
> > > > > not
> > > > > > > >> (yet?) an npm project, and so does not have a package.json.
> > > > > > > >>
> > > > > > > >> The individual platform repos can get rid of it, they will
> > just
> > > > need
> > > > > > to
> > > > > > > >> modify the way they `create` new projects to read the value
> > from
> > > > > > > >> package.json and output it to NewProject/VERSION
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> @purplecabbage
> > > > > > > >> risingj.com
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <
> shazron@gmail.com>
> > > > > wrote:
> > > > > > > >>
> > > > > > > >> > For iOS, the only file I can see that depends on this is:
> > > > > > > >> >
> > > > > > > >> > 1.
> > > > > > > >> >
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > > > > > >> >
> > > > > > > >> > Not sure of the alternative.
> > > > > > > >> >
> > > > > > > >> > This references it but can be removed:
> > > > > > > >> >
> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > > > > > >> >
> > > > > > > >> >
> > > > > > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > > > > stevengill97@gmail.com
> > > > > > > >
> > > > > > > >> > wrote:
> > > > > > > >> > > Most of our repos have a package.json. It keeps track of
> > > > > > versions. I
> > > > > > > >> > think
> > > > > > > >> > > we should work towards removing the VERSION files from
> the
> > > > repos
> > > > > > we
> > > > > > > >> can.
> > > > > > > >> > >
> > > > > > > >> > > Thoughts?
> > > > > > > >> > >
> > > > > > > >> > > This would require some changes to coho so it doesn't
> try
> > to
> > > > > > update
> > > > > > > the
> > > > > > > >> > > version file when doing releases.
> > > > > > > >> >
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Myles Borins <my...@famo.us>.
Ahhhh, I forgot to shim my path with a sense of humor... Oops!
On Aug 12, 2014 12:16 PM, "Brian LeRoux" <b...@brian.io> wrote:
> main benefit was humor though an argument could be made for other ones ;)
>
>
>
> On Tue, Aug 12, 2014 at 12:06 PM, Myles Borins <my...@famo.us> wrote:
>
> > Brian, would there be any benefit to using bash to call node rather than
> a
> > script that started with #! /bin/env node?
> > On Aug 12, 2014 12:01 PM, "Brian LeRoux" <b...@brian.io> wrote:
> >
> > > OR BOTH
> > >
> > > #!/bin/sh
> > > node -e 'console.log(require("./package.json").version)'
> > >
> > >
> > > On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com>
> wrote:
> > >
> > > > Yeah, if you are going to replace bash, replace it with nodejs!
> > > >
> > > >
> > > > @purplecabbage
> > > > risingj.com
> > > >
> > > >
> > > > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us>
> wrote:
> > > >
> > > > > Have you considered writing a small node script to pass the json?
> > This
> > > > > would make it as simple as requiring in the package json an piping
> > the
> > > > > relevant info to stdout
> > > > > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> > > > >
> > > > > > Yeah I value life and my sanity - I'll probably replace the bash
> > > > > > script with python
> > > > > >
> > > > > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> lorin.beer@gmail.com
> > >
> > > > > wrote:
> > > > > > > one source for version information is better
> > > > > > >
> > > > > > > although parsing json with bash scripts seems janky
> > > > > > >
> > > > > > >
> > > > > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> purplecabbage@gmail.com
> > >
> > > > > wrote:
> > > > > > >
> > > > > > >> I think it still needs to exist in an output project ... which
> > is
> > > > not
> > > > > > >> (yet?) an npm project, and so does not have a package.json.
> > > > > > >>
> > > > > > >> The individual platform repos can get rid of it, they will
> just
> > > need
> > > > > to
> > > > > > >> modify the way they `create` new projects to read the value
> from
> > > > > > >> package.json and output it to NewProject/VERSION
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >> @purplecabbage
> > > > > > >> risingj.com
> > > > > > >>
> > > > > > >>
> > > > > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> > > > wrote:
> > > > > > >>
> > > > > > >> > For iOS, the only file I can see that depends on this is:
> > > > > > >> >
> > > > > > >> > 1.
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > > > > >> >
> > > > > > >> > Not sure of the alternative.
> > > > > > >> >
> > > > > > >> > This references it but can be removed:
> > > > > > >> >
> https://github.com/apache/cordova-ios/blob/master/bin/create
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > > > stevengill97@gmail.com
> > > > > > >
> > > > > > >> > wrote:
> > > > > > >> > > Most of our repos have a package.json. It keeps track of
> > > > > versions. I
> > > > > > >> > think
> > > > > > >> > > we should work towards removing the VERSION files from the
> > > repos
> > > > > we
> > > > > > >> can.
> > > > > > >> > >
> > > > > > >> > > Thoughts?
> > > > > > >> > >
> > > > > > >> > > This would require some changes to coho so it doesn't try
> to
> > > > > update
> > > > > > the
> > > > > > >> > > version file when doing releases.
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Brian LeRoux <b...@brian.io>.
main benefit was humor though an argument could be made for other ones ;)
On Tue, Aug 12, 2014 at 12:06 PM, Myles Borins <my...@famo.us> wrote:
> Brian, would there be any benefit to using bash to call node rather than a
> script that started with #! /bin/env node?
> On Aug 12, 2014 12:01 PM, "Brian LeRoux" <b...@brian.io> wrote:
>
> > OR BOTH
> >
> > #!/bin/sh
> > node -e 'console.log(require("./package.json").version)'
> >
> >
> > On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com> wrote:
> >
> > > Yeah, if you are going to replace bash, replace it with nodejs!
> > >
> > >
> > > @purplecabbage
> > > risingj.com
> > >
> > >
> > > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
> > >
> > > > Have you considered writing a small node script to pass the json?
> This
> > > > would make it as simple as requiring in the package json an piping
> the
> > > > relevant info to stdout
> > > > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> > > >
> > > > > Yeah I value life and my sanity - I'll probably replace the bash
> > > > > script with python
> > > > >
> > > > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lorin.beer@gmail.com
> >
> > > > wrote:
> > > > > > one source for version information is better
> > > > > >
> > > > > > although parsing json with bash scripts seems janky
> > > > > >
> > > > > >
> > > > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <purplecabbage@gmail.com
> >
> > > > wrote:
> > > > > >
> > > > > >> I think it still needs to exist in an output project ... which
> is
> > > not
> > > > > >> (yet?) an npm project, and so does not have a package.json.
> > > > > >>
> > > > > >> The individual platform repos can get rid of it, they will just
> > need
> > > > to
> > > > > >> modify the way they `create` new projects to read the value from
> > > > > >> package.json and output it to NewProject/VERSION
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> @purplecabbage
> > > > > >> risingj.com
> > > > > >>
> > > > > >>
> > > > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> > > wrote:
> > > > > >>
> > > > > >> > For iOS, the only file I can see that depends on this is:
> > > > > >> >
> > > > > >> > 1.
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > > > >> >
> > > > > >> > Not sure of the alternative.
> > > > > >> >
> > > > > >> > This references it but can be removed:
> > > > > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > > > >> >
> > > > > >> >
> > > > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > > stevengill97@gmail.com
> > > > > >
> > > > > >> > wrote:
> > > > > >> > > Most of our repos have a package.json. It keeps track of
> > > > versions. I
> > > > > >> > think
> > > > > >> > > we should work towards removing the VERSION files from the
> > repos
> > > > we
> > > > > >> can.
> > > > > >> > >
> > > > > >> > > Thoughts?
> > > > > >> > >
> > > > > >> > > This would require some changes to coho so it doesn't try to
> > > > update
> > > > > the
> > > > > >> > > version file when doing releases.
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Myles Borins <my...@famo.us>.
Brian, would there be any benefit to using bash to call node rather than a
script that started with #! /bin/env node?
On Aug 12, 2014 12:01 PM, "Brian LeRoux" <b...@brian.io> wrote:
> OR BOTH
>
> #!/bin/sh
> node -e 'console.log(require("./package.json").version)'
>
>
> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com> wrote:
>
> > Yeah, if you are going to replace bash, replace it with nodejs!
> >
> >
> > @purplecabbage
> > risingj.com
> >
> >
> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
> >
> > > Have you considered writing a small node script to pass the json? This
> > > would make it as simple as requiring in the package json an piping the
> > > relevant info to stdout
> > > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> > >
> > > > Yeah I value life and my sanity - I'll probably replace the bash
> > > > script with python
> > > >
> > > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com>
> > > wrote:
> > > > > one source for version information is better
> > > > >
> > > > > although parsing json with bash scripts seems janky
> > > > >
> > > > >
> > > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com>
> > > wrote:
> > > > >
> > > > >> I think it still needs to exist in an output project ... which is
> > not
> > > > >> (yet?) an npm project, and so does not have a package.json.
> > > > >>
> > > > >> The individual platform repos can get rid of it, they will just
> need
> > > to
> > > > >> modify the way they `create` new projects to read the value from
> > > > >> package.json and output it to NewProject/VERSION
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >> @purplecabbage
> > > > >> risingj.com
> > > > >>
> > > > >>
> > > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> > wrote:
> > > > >>
> > > > >> > For iOS, the only file I can see that depends on this is:
> > > > >> >
> > > > >> > 1.
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > > >> >
> > > > >> > Not sure of the alternative.
> > > > >> >
> > > > >> > This references it but can be removed:
> > > > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > > >> >
> > > > >> >
> > > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > > stevengill97@gmail.com
> > > > >
> > > > >> > wrote:
> > > > >> > > Most of our repos have a package.json. It keeps track of
> > > versions. I
> > > > >> > think
> > > > >> > > we should work towards removing the VERSION files from the
> repos
> > > we
> > > > >> can.
> > > > >> > >
> > > > >> > > Thoughts?
> > > > >> > >
> > > > >> > > This would require some changes to coho so it doesn't try to
> > > update
> > > > the
> > > > >> > > version file when doing releases.
> > > > >> >
> > > > >>
> > > >
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Brian LeRoux <b...@brian.io>.
OR BOTH
#!/bin/sh
node -e 'console.log(require("./package.json").version)'
On Tue, Aug 12, 2014 at 11:52 AM, Jesse <pu...@gmail.com> wrote:
> Yeah, if you are going to replace bash, replace it with nodejs!
>
>
> @purplecabbage
> risingj.com
>
>
> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
>
> > Have you considered writing a small node script to pass the json? This
> > would make it as simple as requiring in the package json an piping the
> > relevant info to stdout
> > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> >
> > > Yeah I value life and my sanity - I'll probably replace the bash
> > > script with python
> > >
> > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com>
> > wrote:
> > > > one source for version information is better
> > > >
> > > > although parsing json with bash scripts seems janky
> > > >
> > > >
> > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com>
> > wrote:
> > > >
> > > >> I think it still needs to exist in an output project ... which is
> not
> > > >> (yet?) an npm project, and so does not have a package.json.
> > > >>
> > > >> The individual platform repos can get rid of it, they will just need
> > to
> > > >> modify the way they `create` new projects to read the value from
> > > >> package.json and output it to NewProject/VERSION
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> @purplecabbage
> > > >> risingj.com
> > > >>
> > > >>
> > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> wrote:
> > > >>
> > > >> > For iOS, the only file I can see that depends on this is:
> > > >> >
> > > >> > 1.
> > > >> >
> > > >>
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > >> >
> > > >> > Not sure of the alternative.
> > > >> >
> > > >> > This references it but can be removed:
> > > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > >> >
> > > >> >
> > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > stevengill97@gmail.com
> > > >
> > > >> > wrote:
> > > >> > > Most of our repos have a package.json. It keeps track of
> > versions. I
> > > >> > think
> > > >> > > we should work towards removing the VERSION files from the repos
> > we
> > > >> can.
> > > >> > >
> > > >> > > Thoughts?
> > > >> > >
> > > >> > > This would require some changes to coho so it doesn't try to
> > update
> > > the
> > > >> > > version file when doing releases.
> > > >> >
> > > >>
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Michal Mocny <mm...@chromium.org>.
..re reading your email, I think thats exactly what you mean and also
suggested the same solution :P alrighty!
On Tue, Aug 12, 2014 at 3:00 PM, Michal Mocny <mm...@chromium.org> wrote:
> Jesse what did you mean about output projects and package.json?
>
> Do you mean the result of running cordova create / ./create script? If
> the intention is to know what version of the platform was used to create
> the project, then we can either copy the source package.json to the root of
> the platform files, or just continue to create a VERSION file in the output
> of the create script for now.
>
> -Michal
>
>
>
> On Tue, Aug 12, 2014 at 2:52 PM, Jesse <pu...@gmail.com> wrote:
>
>> Yeah, if you are going to replace bash, replace it with nodejs!
>>
>>
>> @purplecabbage
>> risingj.com
>>
>>
>> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
>>
>> > Have you considered writing a small node script to pass the json? This
>> > would make it as simple as requiring in the package json an piping the
>> > relevant info to stdout
>> > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
>> >
>> > > Yeah I value life and my sanity - I'll probably replace the bash
>> > > script with python
>> > >
>> > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com>
>> > wrote:
>> > > > one source for version information is better
>> > > >
>> > > > although parsing json with bash scripts seems janky
>> > > >
>> > > >
>> > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com>
>> > wrote:
>> > > >
>> > > >> I think it still needs to exist in an output project ... which is
>> not
>> > > >> (yet?) an npm project, and so does not have a package.json.
>> > > >>
>> > > >> The individual platform repos can get rid of it, they will just
>> need
>> > to
>> > > >> modify the way they `create` new projects to read the value from
>> > > >> package.json and output it to NewProject/VERSION
>> > > >>
>> > > >>
>> > > >>
>> > > >>
>> > > >> @purplecabbage
>> > > >> risingj.com
>> > > >>
>> > > >>
>> > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
>> wrote:
>> > > >>
>> > > >> > For iOS, the only file I can see that depends on this is:
>> > > >> >
>> > > >> > 1.
>> > > >> >
>> > > >>
>> > >
>> >
>> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>> > > >> >
>> > > >> > Not sure of the alternative.
>> > > >> >
>> > > >> > This references it but can be removed:
>> > > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
>> > > >> >
>> > > >> >
>> > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
>> > stevengill97@gmail.com
>> > > >
>> > > >> > wrote:
>> > > >> > > Most of our repos have a package.json. It keeps track of
>> > versions. I
>> > > >> > think
>> > > >> > > we should work towards removing the VERSION files from the
>> repos
>> > we
>> > > >> can.
>> > > >> > >
>> > > >> > > Thoughts?
>> > > >> > >
>> > > >> > > This would require some changes to coho so it doesn't try to
>> > update
>> > > the
>> > > >> > > version file when doing releases.
>> > > >> >
>> > > >>
>> > >
>> >
>>
>
>
Re: Remove VERSION file from repos
Posted by Michal Mocny <mm...@chromium.org>.
Jesse what did you mean about output projects and package.json?
Do you mean the result of running cordova create / ./create script? If the
intention is to know what version of the platform was used to create the
project, then we can either copy the source package.json to the root of the
platform files, or just continue to create a VERSION file in the output of
the create script for now.
-Michal
On Tue, Aug 12, 2014 at 2:52 PM, Jesse <pu...@gmail.com> wrote:
> Yeah, if you are going to replace bash, replace it with nodejs!
>
>
> @purplecabbage
> risingj.com
>
>
> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
>
> > Have you considered writing a small node script to pass the json? This
> > would make it as simple as requiring in the package json an piping the
> > relevant info to stdout
> > On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> >
> > > Yeah I value life and my sanity - I'll probably replace the bash
> > > script with python
> > >
> > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com>
> > wrote:
> > > > one source for version information is better
> > > >
> > > > although parsing json with bash scripts seems janky
> > > >
> > > >
> > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com>
> > wrote:
> > > >
> > > >> I think it still needs to exist in an output project ... which is
> not
> > > >> (yet?) an npm project, and so does not have a package.json.
> > > >>
> > > >> The individual platform repos can get rid of it, they will just need
> > to
> > > >> modify the way they `create` new projects to read the value from
> > > >> package.json and output it to NewProject/VERSION
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> @purplecabbage
> > > >> risingj.com
> > > >>
> > > >>
> > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com>
> wrote:
> > > >>
> > > >> > For iOS, the only file I can see that depends on this is:
> > > >> >
> > > >> > 1.
> > > >> >
> > > >>
> > >
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > > >> >
> > > >> > Not sure of the alternative.
> > > >> >
> > > >> > This references it but can be removed:
> > > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > > >> >
> > > >> >
> > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> > stevengill97@gmail.com
> > > >
> > > >> > wrote:
> > > >> > > Most of our repos have a package.json. It keeps track of
> > versions. I
> > > >> > think
> > > >> > > we should work towards removing the VERSION files from the repos
> > we
> > > >> can.
> > > >> > >
> > > >> > > Thoughts?
> > > >> > >
> > > >> > > This would require some changes to coho so it doesn't try to
> > update
> > > the
> > > >> > > version file when doing releases.
> > > >> >
> > > >>
> > >
> >
>
Re: Remove VERSION file from repos
Posted by Jesse <pu...@gmail.com>.
Yeah, if you are going to replace bash, replace it with nodejs!
@purplecabbage
risingj.com
On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote:
> Have you considered writing a small node script to pass the json? This
> would make it as simple as requiring in the package json an piping the
> relevant info to stdout
> On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
>
> > Yeah I value life and my sanity - I'll probably replace the bash
> > script with python
> >
> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com>
> wrote:
> > > one source for version information is better
> > >
> > > although parsing json with bash scripts seems janky
> > >
> > >
> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com>
> wrote:
> > >
> > >> I think it still needs to exist in an output project ... which is not
> > >> (yet?) an npm project, and so does not have a package.json.
> > >>
> > >> The individual platform repos can get rid of it, they will just need
> to
> > >> modify the way they `create` new projects to read the value from
> > >> package.json and output it to NewProject/VERSION
> > >>
> > >>
> > >>
> > >>
> > >> @purplecabbage
> > >> risingj.com
> > >>
> > >>
> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com> wrote:
> > >>
> > >> > For iOS, the only file I can see that depends on this is:
> > >> >
> > >> > 1.
> > >> >
> > >>
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > >> >
> > >> > Not sure of the alternative.
> > >> >
> > >> > This references it but can be removed:
> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > >> >
> > >> >
> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
> stevengill97@gmail.com
> > >
> > >> > wrote:
> > >> > > Most of our repos have a package.json. It keeps track of
> versions. I
> > >> > think
> > >> > > we should work towards removing the VERSION files from the repos
> we
> > >> can.
> > >> > >
> > >> > > Thoughts?
> > >> > >
> > >> > > This would require some changes to coho so it doesn't try to
> update
> > the
> > >> > > version file when doing releases.
> > >> >
> > >>
> >
>
Re: Remove VERSION file from repos
Posted by Myles Borins <my...@famo.us>.
Have you considered writing a small node script to pass the json? This
would make it as simple as requiring in the package json an piping the
relevant info to stdout
On Aug 12, 2014 11:47 AM, "Shazron" <sh...@gmail.com> wrote:
> Yeah I value life and my sanity - I'll probably replace the bash
> script with python
>
> On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com> wrote:
> > one source for version information is better
> >
> > although parsing json with bash scripts seems janky
> >
> >
> > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com> wrote:
> >
> >> I think it still needs to exist in an output project ... which is not
> >> (yet?) an npm project, and so does not have a package.json.
> >>
> >> The individual platform repos can get rid of it, they will just need to
> >> modify the way they `create` new projects to read the value from
> >> package.json and output it to NewProject/VERSION
> >>
> >>
> >>
> >>
> >> @purplecabbage
> >> risingj.com
> >>
> >>
> >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com> wrote:
> >>
> >> > For iOS, the only file I can see that depends on this is:
> >> >
> >> > 1.
> >> >
> >>
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> >> >
> >> > Not sure of the alternative.
> >> >
> >> > This references it but can be removed:
> >> > https://github.com/apache/cordova-ios/blob/master/bin/create
> >> >
> >> >
> >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <stevengill97@gmail.com
> >
> >> > wrote:
> >> > > Most of our repos have a package.json. It keeps track of versions. I
> >> > think
> >> > > we should work towards removing the VERSION files from the repos we
> >> can.
> >> > >
> >> > > Thoughts?
> >> > >
> >> > > This would require some changes to coho so it doesn't try to update
> the
> >> > > version file when doing releases.
> >> >
> >>
>
Re: Remove VERSION file from repos
Posted by Shazron <sh...@gmail.com>.
Yeah I value life and my sanity - I'll probably replace the bash
script with python
On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lo...@gmail.com> wrote:
> one source for version information is better
>
> although parsing json with bash scripts seems janky
>
>
> On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com> wrote:
>
>> I think it still needs to exist in an output project ... which is not
>> (yet?) an npm project, and so does not have a package.json.
>>
>> The individual platform repos can get rid of it, they will just need to
>> modify the way they `create` new projects to read the value from
>> package.json and output it to NewProject/VERSION
>>
>>
>>
>>
>> @purplecabbage
>> risingj.com
>>
>>
>> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com> wrote:
>>
>> > For iOS, the only file I can see that depends on this is:
>> >
>> > 1.
>> >
>> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>> >
>> > Not sure of the alternative.
>> >
>> > This references it but can be removed:
>> > https://github.com/apache/cordova-ios/blob/master/bin/create
>> >
>> >
>> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <st...@gmail.com>
>> > wrote:
>> > > Most of our repos have a package.json. It keeps track of versions. I
>> > think
>> > > we should work towards removing the VERSION files from the repos we
>> can.
>> > >
>> > > Thoughts?
>> > >
>> > > This would require some changes to coho so it doesn't try to update the
>> > > version file when doing releases.
>> >
>>
Re: Remove VERSION file from repos
Posted by Lorin Beer <lo...@gmail.com>.
one source for version information is better
although parsing json with bash scripts seems janky
On Tue, Aug 12, 2014 at 11:31 AM, Jesse <pu...@gmail.com> wrote:
> I think it still needs to exist in an output project ... which is not
> (yet?) an npm project, and so does not have a package.json.
>
> The individual platform repos can get rid of it, they will just need to
> modify the way they `create` new projects to read the value from
> package.json and output it to NewProject/VERSION
>
>
>
>
> @purplecabbage
> risingj.com
>
>
> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com> wrote:
>
> > For iOS, the only file I can see that depends on this is:
> >
> > 1.
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> >
> > Not sure of the alternative.
> >
> > This references it but can be removed:
> > https://github.com/apache/cordova-ios/blob/master/bin/create
> >
> >
> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <st...@gmail.com>
> > wrote:
> > > Most of our repos have a package.json. It keeps track of versions. I
> > think
> > > we should work towards removing the VERSION files from the repos we
> can.
> > >
> > > Thoughts?
> > >
> > > This would require some changes to coho so it doesn't try to update the
> > > version file when doing releases.
> >
>
Re: Remove VERSION file from repos
Posted by Jesse <pu...@gmail.com>.
I think it still needs to exist in an output project ... which is not
(yet?) an npm project, and so does not have a package.json.
The individual platform repos can get rid of it, they will just need to
modify the way they `create` new projects to read the value from
package.json and output it to NewProject/VERSION
@purplecabbage
risingj.com
On Tue, Aug 12, 2014 at 11:25 AM, Shazron <sh...@gmail.com> wrote:
> For iOS, the only file I can see that depends on this is:
>
> 1.
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>
> Not sure of the alternative.
>
> This references it but can be removed:
> https://github.com/apache/cordova-ios/blob/master/bin/create
>
>
> On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <st...@gmail.com>
> wrote:
> > Most of our repos have a package.json. It keeps track of versions. I
> think
> > we should work towards removing the VERSION files from the repos we can.
> >
> > Thoughts?
> >
> > This would require some changes to coho so it doesn't try to update the
> > version file when doing releases.
>
Re: Remove VERSION file from repos
Posted by Shazron <sh...@gmail.com>.
Heh now I have to read up on how to parse json using bash O_o
On Tue, Aug 12, 2014 at 11:30 AM, Ian Clelland <ic...@chromium.org> wrote:
> I presume that the alternative would be for the version scripts to parse
> package.json instead. I think that Android used to work the same way, but
> now its version script just reports a hard-coded number (which coho
> updates).
>
> As long as the package.json files are included in the release artifacts,
> and aren't just in the npm packages, then I'm +1 on this. Simplify the
> distribution.
>
>
> On Tue, Aug 12, 2014 at 2:25 PM, Shazron <sh...@gmail.com> wrote:
>
>> For iOS, the only file I can see that depends on this is:
>>
>> 1.
>> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>>
>> Not sure of the alternative.
>>
>> This references it but can be removed:
>> https://github.com/apache/cordova-ios/blob/master/bin/create
>>
>>
>> On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <st...@gmail.com>
>> wrote:
>> > Most of our repos have a package.json. It keeps track of versions. I
>> think
>> > we should work towards removing the VERSION files from the repos we can.
>> >
>> > Thoughts?
>> >
>> > This would require some changes to coho so it doesn't try to update the
>> > version file when doing releases.
>>
Re: Remove VERSION file from repos
Posted by Ian Clelland <ic...@chromium.org>.
I presume that the alternative would be for the version scripts to parse
package.json instead. I think that Android used to work the same way, but
now its version script just reports a hard-coded number (which coho
updates).
As long as the package.json files are included in the release artifacts,
and aren't just in the npm packages, then I'm +1 on this. Simplify the
distribution.
On Tue, Aug 12, 2014 at 2:25 PM, Shazron <sh...@gmail.com> wrote:
> For iOS, the only file I can see that depends on this is:
>
> 1.
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>
> Not sure of the alternative.
>
> This references it but can be removed:
> https://github.com/apache/cordova-ios/blob/master/bin/create
>
>
> On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <st...@gmail.com>
> wrote:
> > Most of our repos have a package.json. It keeps track of versions. I
> think
> > we should work towards removing the VERSION files from the repos we can.
> >
> > Thoughts?
> >
> > This would require some changes to coho so it doesn't try to update the
> > version file when doing releases.
>
Re: Remove VERSION file from repos
Posted by Shazron <sh...@gmail.com>.
For iOS, the only file I can see that depends on this is:
1. https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
Not sure of the alternative.
This references it but can be removed:
https://github.com/apache/cordova-ios/blob/master/bin/create
On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <st...@gmail.com> wrote:
> Most of our repos have a package.json. It keeps track of versions. I think
> we should work towards removing the VERSION files from the repos we can.
>
> Thoughts?
>
> This would require some changes to coho so it doesn't try to update the
> version file when doing releases.