[GitHub] eolivelli commented on a change in pull request #1323: Improve "Failed to resolve network location" logging

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1323: Improve "Failed to resolve network location" logging
URL: https://github.com/apache/bookkeeper/pull/1323#discussion_r180024928
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java
 ##########
 @@ -81,7 +81,8 @@ public InetSocketAddress getSocketAddress() {
      * Maps the socketAddress to a "local" address.
      */
     public LocalAddress getLocalAddress() {
-        return new LocalAddress(socketAddress.toString());
+        // for local address, we just need "port" to differentiate different addresses.
+        return new LocalAddress("" + port);
 
 Review comment:
   @sijie This change seems unrelated. Could you please tell why you need this change ?
   I am fine with it, but I am curious as I am an user of LocalAddresses.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services