[jira] [Commented] (S2GRAPH-117) Cleaner logging library usage

["DOYUNG YOON (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560070#comment-15560070 ] 

DOYUNG YOON commented on S2GRAPH-117:
-------------------------------------

[~jongwook]
Following is what I understand from your comments.

# All project except s2rest_play
{noformat}
Include
"org.slf4j" % "slf4j-api" % "1.7.21"
"org.slf4j" % "slf4j-log4j12" % "1.7.21"
"log4j" % "log4j" % "1.2.17"

Exclude
moduleId.exclude("ch.qos.logback", "logback-*").exclude("org.slf4j", "log4j-over-slf4j")
{noformat}

# s2rest_play
{noformat}
Include
"org.slf4j" % "slf4j-api" % "1.7.21"
"org.slf4j" % "log4j-over-slf4j" % "1.7.21"
"ch.qos.logback" % "logback-classic" % "1.1.2"

Exclude
"org.slf4j" % "slf4j-log4j12" % "1.7.21"
"log4j" % "log4j" % "1.2.17"
{noformat}

Please correct me if I am wrong. If this is correct, I am going to working on fix dependencies on build.sbt files on all projects. 


> Cleaner logging library usage
> -----------------------------
>
>                 Key: S2GRAPH-117
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-117
>             Project: S2Graph
>          Issue Type: Improvement
>            Reporter: Jong Wook Kim
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Our SBT project is currently dependent on both log4j and logback, while using two logging backends is not ideal.
> Furthermore, there has been report that in some configuration we have both slf4j-log4j12 and log4j-over-slf4j in the classpath which leads to StackOverflowError.
> The current codebase is not written with a clean usage of logging library in mind, and I propose the following improvements to make our logging usage conform with the de-facto standard of slf4j.
> - Figure out how the dependencies are using slf4j, log4j, and logback.
> - Use slf4j-api everywhere, named with the fully qualified class names.
> - Exclude slf4j backends from the library projects
> - Add either log4j or logback backends to the application projects, preferably log4j.
> - Add a test case checking that the classpath has the correct configuration of jars.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)