You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/25 00:18:29 UTC
[GitHub] [airflow] potiuk opened a new pull request #14995: Fixes broken asset compilation in Docker images
potiuk opened a new pull request #14995:
URL: https://github.com/apache/airflow/pull/14995
The change #14911 had a bug - when PYTHON_MINOR_MAJOR_VERSION
was removed from the imge args, the replacement `python -m site`
expression missed `/airflow/` suffix. Unfortunately it was not
flagged as an error because the recompiling script silently
skipped recompilation step in such case.
This change:
* fixes the error
* removes the silent-skipping if check (the recompilation will
fail in case it is wrongly set)
* adds check at image verification whether dist/manifest.json is
present.
Fixes: #14991
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14995: Fixes broken asset compilation in Docker images
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14995:
URL: https://github.com/apache/airflow/pull/14995#issuecomment-806272510
[The Workflow run](https://github.com/apache/airflow/actions/runs/684858808) is cancelling this PR. Building image for the PR has been cancelled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14995: Fixes broken asset compilation in Docker images
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14995:
URL: https://github.com/apache/airflow/pull/14995#issuecomment-806272219
[The Workflow run](https://github.com/apache/airflow/actions/runs/684888410) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14995: Fixes broken asset compilation in Docker images
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14995:
URL: https://github.com/apache/airflow/pull/14995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14995: Fixes broken asset compilation in Docker images
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14995:
URL: https://github.com/apache/airflow/pull/14995#issuecomment-806272050
:( test is failing, this is the same error as https://github.com/apache/airflow/pull/14968#issuecomment-806260779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14995: Fixes broken asset compilation in Docker images
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14995:
URL: https://github.com/apache/airflow/pull/14995#issuecomment-806270606
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14995: Fixes broken asset compilation in Docker images
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14995:
URL: https://github.com/apache/airflow/pull/14995#issuecomment-806266943
This one will need to be cherry-picked to 2.0.2 as well @kaxil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14995: Fixes broken asset compilation in Docker images
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14995:
URL: https://github.com/apache/airflow/pull/14995#issuecomment-806335480
[The Workflow run](https://github.com/apache/airflow/actions/runs/685188450) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org