You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 23:36:33 UTC

[GitHub] [arrow] saethlin opened a new pull request #8042: ARROW-9845: [Rust] [Parquet] serde_json is only used in tests but isn't in dev-dependencies

saethlin opened a new pull request #8042:
URL: https://github.com/apache/arrow/pull/8042


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #8042: ARROW-9845: [Rust] [Parquet] serde_json is only used in tests but isn't in dev-dependencies

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8042:
URL: https://github.com/apache/arrow/pull/8042#issuecomment-686109533


   Thanks @saethlin this was merged in https://github.com/apache/arrow/pull/8087


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #8042: ARROW-9845: [Rust] [Parquet] serde_json is only used in tests but isn't in dev-dependencies

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8042:
URL: https://github.com/apache/arrow/pull/8042#issuecomment-683797840


   For what it is worth, I cherry-picked this diff locally and ran the rust tests and everything passed for me. I suggest we merge it @andygrove.
   
   If it would help, I can prepare a PR against the latest master with this change to get a clean CI run


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8042: ARROW-9845: [Rust] [Parquet] serde_json is only used in tests but isn't in dev-dependencies

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8042:
URL: https://github.com/apache/arrow/pull/8042#issuecomment-679421435


   https://issues.apache.org/jira/browse/ARROW-9845


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove closed pull request #8042: ARROW-9845: [Rust] [Parquet] serde_json is only used in tests but isn't in dev-dependencies

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8042:
URL: https://github.com/apache/arrow/pull/8042


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #8042: ARROW-9845: [Rust] [Parquet] serde_json is only used in tests but isn't in dev-dependencies

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8042:
URL: https://github.com/apache/arrow/pull/8042#issuecomment-684045930


   > Thanks @alamb that would be great.
   
   https://github.com/apache/arrow/pull/8087


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #8042: ARROW-9845: [Rust] [Parquet] serde_json is only used in tests but isn't in dev-dependencies

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8042:
URL: https://github.com/apache/arrow/pull/8042#issuecomment-679470478


   Build failure is unrelated to these changes - see https://issues.apache.org/jira/browse/ARROW-9846


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #8042: ARROW-9845: [Rust] [Parquet] serde_json is only used in tests but isn't in dev-dependencies

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8042:
URL: https://github.com/apache/arrow/pull/8042#issuecomment-683812509


   Thanks @alamb that would be great.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org