You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/09 04:53:39 UTC

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #850: Adding message to deleteKubernetesSupportedVersion

davidjumani opened a new pull request #850:
URL: https://github.com/apache/cloudstack-primate/pull/850


   ![Screenshot from 2020-11-09 10-22-30](https://user-images.githubusercontent.com/8244774/98501535-83a3cc00-2275-11eb-9705-801cf264dacb.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-primate] rhtyd merged pull request #850: Adding message to deleteKubernetesSupportedVersion

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #850:
URL: https://github.com/apache/cloudstack-primate/pull/850


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #850: Adding message to deleteKubernetesSupportedVersion

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #850:
URL: https://github.com/apache/cloudstack-primate/pull/850#discussion_r519556241



##########
File path: src/locales/en.json
##########
@@ -2897,6 +2897,7 @@
 "message.kubernetes.cluster.start": "Please confirm that you want to start the cluster",
 "message.kubernetes.cluster.stop": "Please confirm that you want to stop the cluster",
 "message.kubernetes.cluster.upgrade": "Please select new kubernetes version",
+"message.kubernetes.version.delete": "Please confirm that you want to delete this kubernetes version",

Review comment:
       ```suggestion
   "message.kubernetes.version.delete": "Please confirm that you want to delete this Kubernetes version",
   ```

##########
File path: src/locales/en.json
##########
@@ -2897,6 +2897,7 @@
 "message.kubernetes.cluster.start": "Please confirm that you want to start the cluster",
 "message.kubernetes.cluster.stop": "Please confirm that you want to stop the cluster",
 "message.kubernetes.cluster.upgrade": "Please select new kubernetes version",

Review comment:
       ```suggestion
   "message.kubernetes.cluster.upgrade": "Please select new Kubernetes version",
   ```
   @davidjumani can you please change this as well




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-primate] davidjumani commented on pull request #850: Adding message to deleteKubernetesSupportedVersion

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #850:
URL: https://github.com/apache/cloudstack-primate/pull/850#issuecomment-723752864


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org