You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/07 04:10:32 UTC
[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao opened a new pull request #174: [YUNIKORN-349] Remove installCRD option during helm install for e2e test
HuangTing-Yao opened a new pull request #174:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/174
remove installCRD option during helm install.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao commented on pull request #174: [YUNIKORN-349] Remove installCRD option during helm install for e2e test
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on pull request #174:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/174#issuecomment-670377321
@yangwwei please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #174: [YUNIKORN-349] Remove installCRD option during helm install for e2e test
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #174:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/174#issuecomment-671569927
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=h1) Report
> Merging [#174](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/657c62c92687614bf4f089cfaff6b7f5a0db9ad8&el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 57.62% 57.24% -0.39%
==========================================
Files 32 32
Lines 3155 3155
==========================================
- Hits 1818 1806 -12
- Misses 1268 1279 +11
- Partials 69 70 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `67.78% <0.00%> (-4.19%)` | :arrow_down: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174/diff?src=pr&el=tree#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `85.32% <0.00%> (-1.84%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=footer). Last update [657c62c...a2f1364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #174: [YUNIKORN-349] Remove installCRD option during helm install for e2e test
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #174:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/174#issuecomment-671569927
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=h1) Report
> Merging [#174](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/657c62c92687614bf4f089cfaff6b7f5a0db9ad8&el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 57.62% 57.24% -0.39%
==========================================
Files 32 32
Lines 3155 3155
==========================================
- Hits 1818 1806 -12
- Misses 1268 1279 +11
- Partials 69 70 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `67.78% <0.00%> (-4.19%)` | :arrow_down: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174/diff?src=pr&el=tree#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `85.32% <0.00%> (-1.84%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=footer). Last update [657c62c...a2f1364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #174: [YUNIKORN-349] Remove installCRD option during helm install for e2e test
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #174:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #174: [YUNIKORN-349] Remove installCRD option during helm install for e2e test
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #174:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/174#issuecomment-670651348
Change looks good, but I guess the e2e test fails because we haven't updated the helm chart package in the helm hub repo.
Let's get that done first and then I will trigger the job again. Thanks @HuangTing-Yao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org