You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/30 14:47:43 UTC
[GitHub] [dolphinscheduler] DarkAssassinator opened a new issue, #11705: [Clean code] reduce code specification warnings
DarkAssassinator opened a new issue, #11705:
URL: https://github.com/apache/dolphinscheduler/issues/11705
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when add some fields in some entity, found that there are many code warninng in `org.apache.dolphinscheduler.dao.entity.*`, becauase these long code can replaceabled by `Objects.equals()` expression
**And i think there are some issue, why it will return false when `Objects.equals(environmentCode, command.environmentCode)`**
### What you expected to happen
clean code
### How to reproduce
just review the source code, such as `org.apache.dolphinscheduler.dao.entity.Command`
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on issue #11705: [Clean code] reduce code specification warnings
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on issue #11705:
URL: https://github.com/apache/dolphinscheduler/issues/11705#issuecomment-1232868627
Hi @SbloodyS do u know if there is any special consideration for such these conditions, because I didn't find it in the source code. it will return false when Objects.equals(environmentCode, command.environmentCode)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11705: [Clean code] reduce code specification warnings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11705:
URL: https://github.com/apache/dolphinscheduler/issues/11705#issuecomment-1231774203
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement][Dao] reduce code specification warnings [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11705:
URL: https://github.com/apache/dolphinscheduler/issues/11705#issuecomment-1751874132
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement][Dao] reduce code specification warnings [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #11705: [Improvement][Dao] reduce code specification warnings
URL: https://github.com/apache/dolphinscheduler/issues/11705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement][Dao] reduce code specification warnings [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11705:
URL: https://github.com/apache/dolphinscheduler/issues/11705#issuecomment-1763217994
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org