You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/25 23:12:15 UTC

[GitHub] williaster commented on a change in pull request #5087: [dashboard v2] logging updates

williaster commented on a change in pull request #5087: [dashboard v2] logging updates
URL: https://github.com/apache/incubator-superset/pull/5087#discussion_r191027931
 
 

 ##########
 File path: superset/assets/spec/javascripts/dashboard/reducers/dashboardState_spec.js
 ##########
 @@ -3,11 +3,10 @@ import { expect } from 'chai';
 
 import {
   ADD_SLICE,
-  ADD_FILTER,
+  CHANGE_FILTER,
 
 Review comment:
   note that this was changed because `ADD_FILTER` was really used for both adding and removing filters. `REMOVE_FILTER ` was never used by anything in the dashboard app.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org