You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2016/03/10 19:37:14 UTC
svn commit: r1734442 - in
/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5:
http/impl/io/ http/nio/entity/ util/
Author: ggregory
Date: Thu Mar 10 18:37:13 2016
New Revision: 1734442
URL: http://svn.apache.org/viewvc?rev=1734442&view=rev
Log:
https://github.com/apache/httpcore/pull/24 - Code quality fix - Array designators "[]" should be on the type, not the variable.
Modified:
httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedInputStream.java
httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java
httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ContentLengthInputStream.java
httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/ContentInputStream.java
httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/ByteArrayBuffer.java
httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharArrayBuffer.java
Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedInputStream.java?rev=1734442&r1=1734441&r2=1734442&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedInputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedInputStream.java Thu Mar 10 18:37:13 2016
@@ -309,7 +309,7 @@ public class ChunkedInputStream extends
try {
if (!eof && state != CHUNK_INVALID) {
// read and discard the remainder of the message
- final byte buff[] = new byte[BUFFER_SIZE];
+ final byte[] buff = new byte[BUFFER_SIZE];
while (read(buff) >= 0) {
}
}
Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java?rev=1734442&r1=1734441&r2=1734442&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java Thu Mar 10 18:37:13 2016
@@ -113,7 +113,7 @@ public class ChunkedOutputStream extends
* Writes the cache and bufferToAppend to the underlying stream
* as one large chunk
*/
- private void flushCacheWithAppend(final byte bufferToAppend[], final int off, final int len) throws IOException {
+ private void flushCacheWithAppend(final byte[] bufferToAppend, final int off, final int len) throws IOException {
this.lineBuffer.clear();
this.lineBuffer.append(Integer.toHexString(this.cachePosition + len));
this.buffer.writeLine(this.lineBuffer, this.outputStream);
@@ -182,7 +182,7 @@ public class ChunkedOutputStream extends
* not split, but rather written out as one large chunk.
*/
@Override
- public void write(final byte b[]) throws IOException {
+ public void write(final byte[] b) throws IOException {
write(b, 0, b.length);
}
@@ -191,7 +191,7 @@ public class ChunkedOutputStream extends
* not split, but rather written out as one large chunk.
*/
@Override
- public void write(final byte src[], final int off, final int len) throws IOException {
+ public void write(final byte[] src, final int off, final int len) throws IOException {
if (this.closed) {
throw new IOException("Attempted write to closed stream.");
}
Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ContentLengthInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ContentLengthInputStream.java?rev=1734442&r1=1734441&r2=1734442&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ContentLengthInputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ContentLengthInputStream.java Thu Mar 10 18:37:13 2016
@@ -98,7 +98,7 @@ public class ContentLengthInputStream ex
if (!closed) {
try {
if (pos < contentLength) {
- final byte buffer[] = new byte[BUFFER_SIZE];
+ final byte[] buffer = new byte[BUFFER_SIZE];
while (read(buffer) >= 0) {
}
}
Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/ContentInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/ContentInputStream.java?rev=1734442&r1=1734441&r2=1734442&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/ContentInputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/ContentInputStream.java Thu Mar 10 18:37:13 2016
@@ -76,7 +76,7 @@ public class ContentInputStream extends
@Override
public void close() throws IOException {
// read and discard the remainder of the message
- final byte tmp[] = new byte[1024];
+ final byte[] tmp = new byte[1024];
while (this.buffer.read(tmp, 0, tmp.length) >= 0) {
}
super.close();
Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/ByteArrayBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/ByteArrayBuffer.java?rev=1734442&r1=1734441&r2=1734442&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/ByteArrayBuffer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/ByteArrayBuffer.java Thu Mar 10 18:37:13 2016
@@ -57,7 +57,7 @@ public final class ByteArrayBuffer imple
}
private void expand(final int newlen) {
- final byte newbuffer[] = new byte[Math.max(this.buffer.length << 1, newlen)];
+ final byte[] newbuffer = new byte[Math.max(this.buffer.length << 1, newlen)];
System.arraycopy(this.buffer, 0, newbuffer, 0, this.len);
this.buffer = newbuffer;
}
Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharArrayBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharArrayBuffer.java?rev=1734442&r1=1734441&r2=1734442&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharArrayBuffer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharArrayBuffer.java Thu Mar 10 18:37:13 2016
@@ -59,7 +59,7 @@ public final class CharArrayBuffer imple
}
private void expand(final int newlen) {
- final char newbuffer[] = new char[Math.max(this.buffer.length << 1, newlen)];
+ final char[] newbuffer = new char[Math.max(this.buffer.length << 1, newlen)];
System.arraycopy(this.buffer, 0, newbuffer, 0, this.len);
this.buffer = newbuffer;
}