You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/06 07:06:46 UTC
[GitHub] [spark] BryanCutler opened a new pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
BryanCutler opened a new pull request #29951:
URL: https://github.com/apache/spark/pull/29951
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This improves error handling when a failure in conversion from Pandas to Arrow occurs. And fixes tests to be compatible with upcoming Arrow 2.0.0 release.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Current tests will fail with Arrow 2.0.0 because of a change in error message when the schema is invalid. For these cases, the current error message also includes information on disabling safe conversion config, which is mainly meant for floating point truncation and overflow. The tests have been updated to use a message that is show for past Arrow versions, and upcoming.
If the user enters an invalid schema, the error produced by pyarrow is not consistent and either `TypeError` or ArrowInvalid`, with the latter being caught, and raised as a `RuntimeError` with the extra info.
The error handling is improved by:
- narrowing the exception type to `TypeError`s, which `ArrowInvalid` is a subclass and what is raised on safe conversion failures.
- The exception is only raised with additional information on disabling "spark.sql.execution.pandas.convertToArrowArraySafely" if it is enabled in the first place.
- The original exception is chained to better show it to the user.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, the error re-raised changes from a RuntimeError to a ValueError, which better categorizes this type of error and in-line with the original Arrow error.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing tests, using pyarrow 1.0.1 and 2.0.0-snapshot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704616719
Could you take a look at that please?
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-3.0-test-sbt-hadoop-2.7-hive-1.2/876/console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704087509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] BryanCutler commented on a change in pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on a change in pull request #29951:
URL: https://github.com/apache/spark/pull/29951#discussion_r500050618
##########
File path: python/pyspark/sql/pandas/serializers.py
##########
@@ -153,13 +153,16 @@ def create_array(s, t):
s = s.astype(s.dtypes.categories.dtype)
try:
array = pa.Array.from_pandas(s, mask=mask, type=t, safe=self._safecheck)
- except pa.ArrowException as e:
- error_msg = "Exception thrown when converting pandas.Series (%s) to Arrow " + \
- "Array (%s). It can be caused by overflows or other unsafe " + \
- "conversions warned by Arrow. Arrow safe type check can be " + \
- "disabled by using SQL config " + \
- "`spark.sql.execution.pandas.convertToArrowArraySafely`."
- raise RuntimeError(error_msg % (s.dtype, t), e)
+ except ValueError as e:
Review comment:
errors during safe conversion will be `ArrowInvalid`, which subclasses ValueError
##########
File path: python/pyspark/sql/pandas/serializers.py
##########
@@ -153,13 +153,16 @@ def create_array(s, t):
s = s.astype(s.dtypes.categories.dtype)
try:
array = pa.Array.from_pandas(s, mask=mask, type=t, safe=self._safecheck)
- except pa.ArrowException as e:
- error_msg = "Exception thrown when converting pandas.Series (%s) to Arrow " + \
- "Array (%s). It can be caused by overflows or other unsafe " + \
- "conversions warned by Arrow. Arrow safe type check can be " + \
- "disabled by using SQL config " + \
- "`spark.sql.execution.pandas.convertToArrowArraySafely`."
- raise RuntimeError(error_msg % (s.dtype, t), e)
+ except ValueError as e:
+ if self._safecheck:
+ error_msg = "Exception thrown when converting pandas.Series (%s) to " + \
+ "Arrow Array (%s). It can be caused by overflows or other " + \
+ "unsafe conversions warned by Arrow. Arrow safe type check " + \
+ "can be disabled by using SQL config " + \
+ "`spark.sql.execution.pandas.convertToArrowArraySafely`."
+ raise ValueError(error_msg % (s.dtype, t)) from e
Review comment:
Now that we dropped Python 2, this seems more appropriate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon removed a comment on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704138891
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704617216
I'll actually revert this out of branch-3.0, and leave it to @BryanCutler to open a PR to backport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704087175
**[Test build #129437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129437/testReport)** for PR 29951 at commit [`e7a09e9`](https://github.com/apache/spark/commit/e7a09e9dce49f6246957cb1965c26dbe846acbe8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704105115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704087509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704139163
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704078067
**[Test build #129437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129437/testReport)** for PR 29951 at commit [`e7a09e9`](https://github.com/apache/spark/commit/e7a09e9dce49f6246957cb1965c26dbe846acbe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] BryanCutler commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704696121
Shoot, sorry about that. Exception chaining is only a Python 3 thing. I'll fix this up for branch-3.0 since that is still testing with Python 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704616370
Hi, @BryanCutler and @HyukjinKwon . This seems to break branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] BryanCutler commented on a change in pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on a change in pull request #29951:
URL: https://github.com/apache/spark/pull/29951#discussion_r500051665
##########
File path: python/pyspark/sql/tests/test_arrow.py
##########
@@ -264,11 +264,12 @@ def test_createDataFrame_with_schema(self):
def test_createDataFrame_with_incorrect_schema(self):
pdf = self.create_pandas_data_frame()
fields = list(self.schema)
- fields[0], fields[1] = fields[1], fields[0] # swap str with int
+ fields[5], fields[6] = fields[6], fields[5] # swap decimal with date
wrong_schema = StructType(fields)
- with QuietTest(self.sc):
- with self.assertRaisesRegexp(Exception, "integer.*required"):
- self.spark.createDataFrame(pdf, schema=wrong_schema)
+ with self.sql_conf({"spark.sql.execution.pandas.convertToArrowArraySafely": False}):
Review comment:
The error here is a `TypeError`, but in case it gets changed to an `ArrowInvalid`, we do not want to have the original error chained because the assert does not include it when checking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704616719
Could you take a look at that please?
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-3.0-test-sbt-hadoop-2.7-hive-1.2/876/console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704696892
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704653810
Thank you for swift fix, @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704096262
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34044/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29951:
URL: https://github.com/apache/spark/pull/29951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29951:
URL: https://github.com/apache/spark/pull/29951#discussion_r500663540
##########
File path: python/pyspark/sql/pandas/serializers.py
##########
@@ -153,13 +153,16 @@ def create_array(s, t):
s = s.astype(s.dtypes.categories.dtype)
try:
array = pa.Array.from_pandas(s, mask=mask, type=t, safe=self._safecheck)
- except pa.ArrowException as e:
- error_msg = "Exception thrown when converting pandas.Series (%s) to Arrow " + \
- "Array (%s). It can be caused by overflows or other unsafe " + \
- "conversions warned by Arrow. Arrow safe type check can be " + \
- "disabled by using SQL config " + \
- "`spark.sql.execution.pandas.convertToArrowArraySafely`."
- raise RuntimeError(error_msg % (s.dtype, t), e)
+ except ValueError as e:
+ if self._safecheck:
+ error_msg = "Exception thrown when converting pandas.Series (%s) to " + \
+ "Arrow Array (%s). It can be caused by overflows or other " + \
+ "unsafe conversions warned by Arrow. Arrow safe type check " + \
+ "can be disabled by using SQL config " + \
+ "`spark.sql.execution.pandas.convertToArrowArraySafely`."
+ raise ValueError(error_msg % (s.dtype, t)) from e
Review comment:
In `branch-3.0`.
```
File "/home/jenkins/workspace/spark-branch-3.0-test-sbt-hadoop-2.7-hive-1.2/python/pyspark/sql/pandas/serializers.py", line 166
raise ValueError(error_msg % (s.dtype, t)) from e
^
SyntaxError: invalid syntax
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704078067
**[Test build #129437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129437/testReport)** for PR 29951 at commit [`e7a09e9`](https://github.com/apache/spark/commit/e7a09e9dce49f6246957cb1965c26dbe846acbe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704138333
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] BryanCutler commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704079948
Thanks @HyukjinKwon , you're fast :grin:
This will help get the Spark integration tests passing in https://github.com/apache/arrow/pull/8352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704618056
Reverted from branch-3.0. @BryanCutler would you mind opening a PR to port back?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704617124
Sure!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704105115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704138891
@BryanCutler, It would need a separate PR to port back - seems it conflicts in the branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704138333
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29951: [SPARK-33073][PYTHON] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29951:
URL: https://github.com/apache/spark/pull/29951#issuecomment-704105088
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34044/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org