You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/05/11 14:09:43 UTC

[GitHub] [zookeeper] seuCHENGHQ opened a new pull request #1694: ZOOKEEPER-4029: improve the log of FileTxnLog#append method

seuCHENGHQ opened a new pull request #1694:
URL: https://github.com/apache/zookeeper/pull/1694


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on pull request #1694: ZOOKEEPER-4029: improve the log of FileTxnLog#append method

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1694:
URL: https://github.com/apache/zookeeper/pull/1694#issuecomment-841767185


   - The CI has passed and I check the log format:  `Current zxid 6708720 is <= 6708720 for create.`. `Maybe "zxid 0x{} ", Long.toHexString(hdr.getZxid()) is better`  :)
   - @seuCHENGHQ Thanks for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] asfgit closed pull request #1694: ZOOKEEPER-4029: improve the log of FileTxnLog#append method

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1694:
URL: https://github.com/apache/zookeeper/pull/1694


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] seuCHENGHQ closed pull request #1694: ZOOKEEPER-4029: improve the log of FileTxnLog#append method

Posted by GitBox <gi...@apache.org>.
seuCHENGHQ closed pull request #1694:
URL: https://github.com/apache/zookeeper/pull/1694


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] asfgit closed pull request #1694: ZOOKEEPER-4029: improve the log of FileTxnLog#append method

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1694:
URL: https://github.com/apache/zookeeper/pull/1694


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on pull request #1694: ZOOKEEPER-4029: improve the log of FileTxnLog#append method

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1694:
URL: https://github.com/apache/zookeeper/pull/1694#issuecomment-841767185


   - The CI has passed and I check the log format:  `Current zxid 6708720 is <= 6708720 for create.`. `Maybe "zxid 0x{} ", Long.toHexString(hdr.getZxid()) is better`  :)
   - @seuCHENGHQ Thanks for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] seuCHENGHQ closed pull request #1694: ZOOKEEPER-4029: improve the log of FileTxnLog#append method

Posted by GitBox <gi...@apache.org>.
seuCHENGHQ closed pull request #1694:
URL: https://github.com/apache/zookeeper/pull/1694


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org