[jira] [Commented] (OAK-5161) Improve logging of compaction cycles

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693691#comment-15693691 ] 

Michael Dürig commented on OAK-5161:
------------------------------------

Thanks for the patch. Makes sense. Apart from 

{code}

@@ -1110,7 +1120,7 @@ public class FileStore extends AbstractFileStore {
            for (TarReader oldReader : oldReaders) {
                closeAndLogOnFail(oldReader);
                File file = oldReader.getFile();
-                gcListener.info("TarMK GC #{}: cleanup marking file for deletion: {}", GC_COUNT, file.getName());
+                gcListener.info("cleanup marking file for deletion: {}", GC_COUNT, file.getName());
                toRemove.addLast(file);
            }
{code}

which I don't understand. Is this an accident or what is the intention?


> Improve logging of compaction cycles
> ------------------------------------
>
>                 Key: OAK-5161
>                 URL: https://issues.apache.org/jira/browse/OAK-5161
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Valentin Olteanu
>            Assignee: Michael Dürig
>            Priority: Minor
>             Fix For: 1.5.15
>
>         Attachments: OAK-5161.patch
>
>
> It would be useful to have logs with more info related to the compaction cycles, e.g. how much each takes, show if force compact was successful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)