You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by graben <gi...@git.apache.org> on 2016/11/16 09:09:21 UTC
[GitHub] activemq-artemis pull request #889: ARTEMIS-852: Add PK and index to create ...
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/889
ARTEMIS-852: Add PK and index to create journal table DDL script
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq-artemis ARTEMIS-852
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/889.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #889
----
commit 95e88dd22f68c27c57664cc5aec129f7f9175472
Author: Benjamin Graf <be...@gmx.net>
Date: 2016-11-16T09:08:10Z
ARTEMIS-852: Add PK and index to create journal table DDL script
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #889: ARTEMIS-852: Add PK and index to create ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/889#discussion_r88242343
--- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/mysql/MySQLSQLProvider.java ---
@@ -36,8 +36,10 @@ private MySQLSQLProvider(String tName) {
"(ID INTEGER NOT NULL AUTO_INCREMENT," +
"FILENAME VARCHAR(255), EXTENSION VARCHAR(10), DATA LONGBLOB, PRIMARY KEY(ID)) ENGINE=InnoDB;";
- createJournalTableSQL = "CREATE TABLE " + tableName +
- "(id BIGINT,recordType SMALLINT,compactCount SMALLINT,txId BIGINT,userRecordType SMALLINT,variableSize INTEGER,record LONGBLOB,txDataSize INTEGER,txData LONGBLOB,txCheckNoRecords INTEGER,seq BIGINT) ENGINE=InnoDB;";
+ createJournalTableSQL = new String[] {
+ "CREATE TABLE " + tableName + "(id BIGINT,recordType SMALLINT,compactCount SMALLINT,txId BIGINT,userRecordType SMALLINT,variableSize INTEGER,record LONGBLOB,txDataSize INTEGER,txData LONGBLOB,txCheckNoRecords INTEGER,seq BIGINT) ENGINE=InnoDB;",
+ "CREATE INDEX " + tableName + "_IDX ON " + tableName + " (id)"
--- End diff --
great idea to use arrays
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #889: ARTEMIS-852: Add PK and index to create journal...
Posted by graben <gi...@git.apache.org>.
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/889
to be honest, array idea is taken from ActiveMQ :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #889: ARTEMIS-852: Add PK and index to create ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/889
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---