You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Rishi Verma <ri...@apache.org> on 2014/06/13 15:09:54 UTC
Review Request 22575: Simplify OODT RADiX setup: provide pre-configured
RADiX via Vagrant
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22575/
-----------------------------------------------------------
Review request for oodt.
Repository: oodt
Description
-------
Please see: https://issues.apache.org/jira/browse/OODT-676
Diffs
-----
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/README.txt PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/conf/terminal/bashrc PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh PRE-CREATION
Diff: https://reviews.apache.org/r/22575/diff/
Testing
-------
Locally tested from fresh install of tar-ball: https://issues.apache.org/jira/secure/attachment/12650125/radix-vagrant.tar
Results: OODT RADiX running filemgr, resmgr, workflow mgr, and tomcat - accessible from OPSUI webapp.
Thanks,
Rishi Verma
Re: Review Request 22575: Simplify OODT RADiX setup: provide pre-configured
RADiX via Vagrant
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22575/#review45802
-----------------------------------------------------------
Ship it!
Ship It!
- Chris Mattmann
On June 16, 2014, 7:30 p.m., Rishi Verma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22575/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 7:30 p.m.)
>
>
> Review request for oodt.
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Please see: https://issues.apache.org/jira/browse/OODT-676
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/README.txt PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/conf/terminal/bashrc PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22575/diff/
>
>
> Testing
> -------
>
> Locally tested from fresh install of tar-ball: https://issues.apache.org/jira/secure/attachment/12650125/radix-vagrant.tar
> Results: OODT RADiX running filemgr, resmgr, workflow mgr, and tomcat - accessible from OPSUI webapp.
>
>
> Thanks,
>
> Rishi Verma
>
>
Re: Review Request 22575: Simplify OODT RADiX setup: provide pre-configured
RADiX via Vagrant
Posted by Rishi Verma <ri...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22575/
-----------------------------------------------------------
(Updated June 16, 2014, 7:30 p.m.)
Review request for oodt.
Changes
-------
All suggestions implemented.
Repository: oodt
Description
-------
Please see: https://issues.apache.org/jira/browse/OODT-676
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/README.txt PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/conf/terminal/bashrc PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh PRE-CREATION
Diff: https://reviews.apache.org/r/22575/diff/
Testing
-------
Locally tested from fresh install of tar-ball: https://issues.apache.org/jira/secure/attachment/12650125/radix-vagrant.tar
Results: OODT RADiX running filemgr, resmgr, workflow mgr, and tomcat - accessible from OPSUI webapp.
Thanks,
Rishi Verma
Re: Review Request 22575: Simplify OODT RADiX setup: provide pre-configured
RADiX via Vagrant
Posted by Rishi Verma <ri...@apache.org>.
> On June 13, 2014, 11:37 p.m., Sheryl John wrote:
> > http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh, line 49
> > <https://reviews.apache.org/r/22575/diff/1/?file=609379#file609379line49>
> >
> > Should this be BUILD_FLAGS from the env.sh?
> >
Sheryl, wow NICE CATCH!! Thanks so much for your help with reviewing this, its been awesome.
I've applied your suggested correction. Will ship the whole patch later today.
Thanks,
Rishi
- Rishi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22575/#review45677
-----------------------------------------------------------
On June 13, 2014, 1:09 p.m., Rishi Verma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22575/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 1:09 p.m.)
>
>
> Review request for oodt.
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Please see: https://issues.apache.org/jira/browse/OODT-676
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/README.txt PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/conf/terminal/bashrc PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22575/diff/
>
>
> Testing
> -------
>
> Locally tested from fresh install of tar-ball: https://issues.apache.org/jira/secure/attachment/12650125/radix-vagrant.tar
> Results: OODT RADiX running filemgr, resmgr, workflow mgr, and tomcat - accessible from OPSUI webapp.
>
>
> Thanks,
>
> Rishi Verma
>
>
Re: Review Request 22575: Simplify OODT RADiX setup: provide pre-configured
RADiX via Vagrant
Posted by Sheryl John <sh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22575/#review45677
-----------------------------------------------------------
Ship it!
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh
<https://reviews.apache.org/r/22575/#comment80596>
Should this be BUILD_FLAGS from the env.sh?
- Sheryl John
On June 13, 2014, 6:09 a.m., Rishi Verma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22575/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 6:09 a.m.)
>
>
> Review request for oodt.
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Please see: https://issues.apache.org/jira/browse/OODT-676
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/README.txt PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/conf/terminal/bashrc PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22575/diff/
>
>
> Testing
> -------
>
> Locally tested from fresh install of tar-ball: https://issues.apache.org/jira/secure/attachment/12650125/radix-vagrant.tar
> Results: OODT RADiX running filemgr, resmgr, workflow mgr, and tomcat - accessible from OPSUI webapp.
>
>
> Thanks,
>
> Rishi Verma
>
>
Re: Review Request 22575: Simplify OODT RADiX setup: provide pre-configured
RADiX via Vagrant
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22575/#review45624
-----------------------------------------------------------
Ship it!
Ship It!
- Chris Mattmann
On June 13, 2014, 1:09 p.m., Rishi Verma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22575/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 1:09 p.m.)
>
>
> Review request for oodt.
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Please see: https://issues.apache.org/jira/browse/OODT-676
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/README.txt PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/conf/terminal/bashrc PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22575/diff/
>
>
> Testing
> -------
>
> Locally tested from fresh install of tar-ball: https://issues.apache.org/jira/secure/attachment/12650125/radix-vagrant.tar
> Results: OODT RADiX running filemgr, resmgr, workflow mgr, and tomcat - accessible from OPSUI webapp.
>
>
> Thanks,
>
> Rishi Verma
>
>
Re: Review Request 22575: Simplify OODT RADiX setup: provide pre-configured
RADiX via Vagrant
Posted by Rishi Verma <ri...@apache.org>.
> On June 13, 2014, 4:08 p.m., Chris Mattmann wrote:
> > http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh, line 12
> > <https://reviews.apache.org/r/22575/diff/1/?file=609378#file609378line12>
> >
> > this is OpenJDK, right?
Yes!
vagrant@vagrant:~$ java -version
java version "1.7.0_55"
OpenJDK Runtime Environment (IcedTea 2.4.7) (7u55-2.4.7-1ubuntu1~0.13.10.1)
OpenJDK 64-Bit Server VM (build 24.51-b03, mixed mode)
> On June 13, 2014, 4:08 p.m., Chris Mattmann wrote:
> > http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile, line 83
> > <https://reviews.apache.org/r/22575/diff/1/?file=609376#file609376line83>
> >
> > How about: "Welcome to Apache OODT Radix! Built by Vagrant, managed by Puppet."
Hey Chris,
This line is commented out by default (and not visible upon startup) because most people will just be using a combination of Vagrant & VirtualBox. I'll add that in there though in case people deploy through puppet.
> On June 13, 2014, 4:08 p.m., Chris Mattmann wrote:
> > http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh, line 37
> > <https://reviews.apache.org/r/22575/diff/1/?file=609379#file609379line37>
> >
> > maybe call it "oodt-${version}" instead of "oodt-trunk"
I like it. Will add. Thanks.
- Rishi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22575/#review45622
-----------------------------------------------------------
On June 13, 2014, 1:09 p.m., Rishi Verma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22575/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 1:09 p.m.)
>
>
> Review request for oodt.
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Please see: https://issues.apache.org/jira/browse/OODT-676
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/README.txt PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/conf/terminal/bashrc PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22575/diff/
>
>
> Testing
> -------
>
> Locally tested from fresh install of tar-ball: https://issues.apache.org/jira/secure/attachment/12650125/radix-vagrant.tar
> Results: OODT RADiX running filemgr, resmgr, workflow mgr, and tomcat - accessible from OPSUI webapp.
>
>
> Thanks,
>
> Rishi Verma
>
>
Re: Review Request 22575: Simplify OODT RADiX setup: provide pre-configured
RADiX via Vagrant
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22575/#review45622
-----------------------------------------------------------
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile
<https://reviews.apache.org/r/22575/#comment80494>
How about: "Welcome to Apache OODT Radix! Built by Vagrant, managed by Puppet."
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh
<https://reviews.apache.org/r/22575/#comment80495>
this is OpenJDK, right?
http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh
<https://reviews.apache.org/r/22575/#comment80496>
maybe call it "oodt-${version}" instead of "oodt-trunk"
- Chris Mattmann
On June 13, 2014, 1:09 p.m., Rishi Verma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22575/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 1:09 p.m.)
>
>
> Review request for oodt.
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Please see: https://issues.apache.org/jira/browse/OODT-676
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/README.txt PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/Vagrantfile PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/conf/terminal/bashrc PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/env.sh PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/vagrant/radix/vagrant/provision.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22575/diff/
>
>
> Testing
> -------
>
> Locally tested from fresh install of tar-ball: https://issues.apache.org/jira/secure/attachment/12650125/radix-vagrant.tar
> Results: OODT RADiX running filemgr, resmgr, workflow mgr, and tomcat - accessible from OPSUI webapp.
>
>
> Thanks,
>
> Rishi Verma
>
>