You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2025/01/04 14:12:12 UTC
[PR] Require Java 17 [maven-site]
slachiewicz opened a new pull request, #626:
URL: https://github.com/apache/maven-site/pull/626
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 [maven-site]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #626:
URL: https://github.com/apache/maven-site/pull/626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #626:
URL: https://github.com/apache/maven-site/pull/626#discussion_r1903118492
##########
pom.xml:
##########
@@ -144,54 +144,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-enforcer-plugin</artifactId>
- <version>3.5.0</version>
- <dependencies>
- <dependency>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>extra-enforcer-rules</artifactId>
- <version>1.9.0</version>
- </dependency>
- </dependencies>
- <executions>
- <execution>
- <id>enforce-java8</id>
- <goals>
- <goal>enforce</goal>
- </goals>
- <phase>site</phase>
- <configuration>
- <rules>
- <requireJavaVersion>
- <version>1.8</version>
Review Comment:
Why not keep the enforcer and also update it to require at least 17?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 [maven-site]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #626:
URL: https://github.com/apache/maven-site/pull/626#discussion_r1903119212
##########
pom.xml:
##########
@@ -144,54 +144,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-enforcer-plugin</artifactId>
- <version>3.5.0</version>
- <dependencies>
- <dependency>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>extra-enforcer-rules</artifactId>
- <version>1.9.0</version>
- </dependency>
- </dependencies>
- <executions>
- <execution>
- <id>enforce-java8</id>
- <goals>
- <goal>enforce</goal>
- </goals>
- <phase>site</phase>
- <configuration>
- <rules>
- <requireJavaVersion>
- <version>1.8</version>
Review Comment:
Enforcer rule is already defined in parent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org