You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by va...@apache.org on 2015/09/17 19:18:30 UTC
spark git commit: [SPARK-10172] [CORE] disable sort in HistoryServer
webUI
Repository: spark
Updated Branches:
refs/heads/master 136c77d8b -> 81b4db374
[SPARK-10172] [CORE] disable sort in HistoryServer webUI
This pull request is to address the JIRA SPARK-10172 (History Server web UI gets messed up when sorting on any column).
The content of the table gets messed up due to the rowspan attribute of the table data(cell) during sorting.
The current table sort library used in SparkUI (sorttable.js) doesn't support/handle cells(td) with rowspans.
The fix will disable the table sort in the web UI, when there are jobs listed with multiple attempts.
Author: Josiah Samuel <jo...@in.ibm.com>
Closes #8506 from josiahsams/SPARK-10172.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/81b4db37
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/81b4db37
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/81b4db37
Branch: refs/heads/master
Commit: 81b4db374dd61b6f1c30511c70b6ab2a52c68faa
Parents: 136c77d
Author: Josiah Samuel <jo...@in.ibm.com>
Authored: Thu Sep 17 10:18:21 2015 -0700
Committer: Marcelo Vanzin <va...@cloudera.com>
Committed: Thu Sep 17 10:18:21 2015 -0700
----------------------------------------------------------------------
.../scala/org/apache/spark/deploy/history/HistoryPage.scala | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/81b4db37/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala b/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
index 0830cc1..b347cb3 100644
--- a/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
@@ -51,7 +51,10 @@ private[history] class HistoryPage(parent: HistoryServer) extends WebUIPage("")
val hasMultipleAttempts = appsToShow.exists(_.attempts.size > 1)
val appTable =
if (hasMultipleAttempts) {
- UIUtils.listingTable(appWithAttemptHeader, appWithAttemptRow, appsToShow)
+ // Sorting is disable here as table sort on rowspan has issues.
+ // ref. SPARK-10172
+ UIUtils.listingTable(appWithAttemptHeader, appWithAttemptRow,
+ appsToShow, sortable = false)
} else {
UIUtils.listingTable(appHeader, appRow, appsToShow)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org