[GitHub] [incubator-tvm] tqchen edited a comment on issue #5047: [Runtime] Python String container interface

[GitBox <gi...@apache.org>]

tqchen edited a comment on issue #5047: [Runtime] Python String container interface
URL: https://github.com/apache/incubator-tvm/issues/5047#issuecomment-601287957
 
 
   I can see the following steps:
   
   - Introduce the string container
      - We need to think about how to make the String object works like a normal python string(possibly subclass str?, I haven't dig deep)
      - At this stage users can pass and return String but need to explicitly do so
   - Add automatic conversion from TVMArgValue to String, when the argument is c string pointer and bytes, automatically convert to a String container(via copy).
   - Change the original usage of StringImm to use String instead
   - Change automatic object conversion(tvm.convert) https://github.com/apache/incubator-tvm/blob/master/python/tvm/runtime/object_generic.py#L59 to convert python str to String object
   - Remove constructor of Expr from std::string(as it will no longer be needed), we will use Array<String> for most cases
   - Add reflection support to serialize a String (so we can dump a String object to json).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services