You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/06/02 20:18:44 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #6435: VPC VR: fix /etc/network/interfaces is misconfigured
weizhouapache opened a new pull request, #6435:
URL: https://github.com/apache/cloudstack/pull/6435
### Description
This PR fixes that the /etc/network/interfaces is misconfigured in VPC VR startup, therefore VPC VR is stuck for 1 minue.
severity: to be discussed.
This requires a new systemvm template.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145742838
<b>Trillian Build Failed (tid-4292)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1190113998
ping @weizhouapache any update on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1344175427
> @weizhouapache @shwstppr does this require a new systemvmtemplate or are the changes patches and run after the patching process? @blueorangutan package
@rohityadavcloud
yes, it requires a new systemvm template
Actually, any change with init.sh and bootstrap.sh requires a new systemvm template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1344134568
@weizhouapache @shwstppr does this require a new systemvmtemplate or are the changes patches and run after the patching process?
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145655583
<b>Trillian Build Failed (tid-4285)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1219422783
Based on discussion with @weizhouapache moving this to the next milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#discussion_r1043333526
##########
systemvm/debian/opt/cloud/bin/setup/init.sh:
##########
@@ -188,6 +188,7 @@ setup_interface_sshd() {
setup_sshd $ETH1_IP "eth1"
elif [ "$TYPE" == "vpcrouter" ]; then
+ init_interfaces "eth0"
Review Comment:
@shwstppr it should be ok.
If only eth0 is passed, it is same as
```
cat > /etc/network/interfaces << EOF
auto lo eth0
iface lo inet loopback
EOF
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145685782
<b>Trillian Build Failed (tid-4288)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1150598083
<b>Trillian test result (tid-4313)</b>
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 35606 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4313-kvm-ubuntu22.zip
Smoke tests completed. 97 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a diff in pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on code in PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#discussion_r904767558
##########
systemvm/debian/opt/cloud/bin/setup/init.sh:
##########
@@ -188,6 +188,7 @@ setup_interface_sshd() {
setup_sshd $ETH1_IP "eth1"
elif [ "$TYPE" == "vpcrouter" ]; then
+ init_interfaces "eth0"
Review Comment:
With the new approach the IP on the interfaces need to be available right at the time of VM boot up, so that we can perform the scp operation , so, I am not sure moving this to a separate script would eliminated the need to build a new systemVM template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145518137
<b>Trillian Build Failed (tid-4281)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145390442
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145696871
<b>Trillian Build Failed (tid-4289)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1362786511
Prior to this change
with this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145662488
<b>Trillian Build Failed (tid-4286)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1150913954
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1150033828
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#discussion_r904796609
##########
systemvm/debian/opt/cloud/bin/setup/init.sh:
##########
@@ -188,6 +188,7 @@ setup_interface_sshd() {
setup_sshd $ETH1_IP "eth1"
elif [ "$TYPE" == "vpcrouter" ]; then
+ init_interfaces "eth0"
Review Comment:
@rohityadavcloud
in my opinion, it might be possible.
`init.sh` needs to (1) get cmdline; (2) configure link-local interface; (3) setup ssh.
The rest (init and configure public and guest nics, etc) can be moved to other scripts and executed after `scp`.
is it right ? @Pearl1594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1146687921
<b>Trillian test result (tid-4300)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53311 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4300-kvm-centos7.zip
Smoke tests completed. 94 look OK, 3 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_arping_in_ssvm | `Failure` | 5.15 | test_diagnostics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 337.49 | test_vpc_redundant.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3601.43 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3606.31 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 85.68 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145767687
<b>Trillian Build Failed (tid-4293)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1344220780
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#discussion_r904754621
##########
systemvm/debian/opt/cloud/bin/setup/init.sh:
##########
@@ -188,6 +188,7 @@ setup_interface_sshd() {
setup_sshd $ETH1_IP "eth1"
elif [ "$TYPE" == "vpcrouter" ]; then
+ init_interfaces "eth0"
Review Comment:
why not move this entirely to the appliance/type specific script cc @weizhouapache @Pearl1594 ? This would avoid requiring new systemvmtemplate anytime the init (or early-config?) script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1344135134
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145420214
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145725185
<b>Trillian Build Failed (tid-4290)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145548775
<b>Trillian Build Failed (tid-4282)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a diff in pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on code in PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#discussion_r904806542
##########
systemvm/debian/opt/cloud/bin/setup/init.sh:
##########
@@ -188,6 +188,7 @@ setup_interface_sshd() {
setup_sshd $ETH1_IP "eth1"
elif [ "$TYPE" == "vpcrouter" ]; then
+ init_interfaces "eth0"
Review Comment:
Yup, if the control IP is set and ssh comes up fine, then yes I guess it could work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1146466136
<b>Trillian test result (tid-4296)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50014 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4296-kvm-centos7.zip
Smoke tests completed. 95 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3610.74 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3611.80 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 81.90 | test_kubernetes_clusters.py
ContextSuite context=TestSharedNetwork>:setup | `Error` | 45.32 | test_network.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#discussion_r904788442
##########
systemvm/debian/opt/cloud/bin/setup/init.sh:
##########
@@ -188,6 +188,7 @@ setup_interface_sshd() {
setup_sshd $ETH1_IP "eth1"
elif [ "$TYPE" == "vpcrouter" ]; then
+ init_interfaces "eth0"
Review Comment:
I suppose the question is - is there a way to refactor the script/sequence in a way that avoids building a new template everytime the first-run scripts (such as init.sh or cloud-early-config) are changed? This would improve the maintainability of the systemvmtemplates. @Pearl1594 @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1190136750
> ping @weizhouapache any update on this?
@rohityadavcloud
I did not work on this recently.
based on our previous dicsussion, it looks better to create another PR to configure only control IP in init.sh (the change in this PR can be added to the new PR as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1151570264
<b>Trillian test result (tid-4315)</b>
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 35494 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4315-kvm-ubuntu22.zip
Smoke tests completed. 97 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a diff in pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
shwstppr commented on code in PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#discussion_r1043325593
##########
systemvm/debian/opt/cloud/bin/setup/init.sh:
##########
@@ -188,6 +188,7 @@ setup_interface_sshd() {
setup_sshd $ETH1_IP "eth1"
elif [ "$TYPE" == "vpcrouter" ]; then
+ init_interfaces "eth0"
Review Comment:
@weizhouapache `init_interfaces` method in common.sh expects 3 arguments. Will there be an issue with this call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1344233053
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145391231
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145737740
<b>Trillian Build Failed (tid-4291)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1145620915
<b>Trillian Build Failed (tid-4283)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1146871355
<b>Trillian test result (tid-4301)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49075 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4301-kvm-centos7.zip
Smoke tests completed. 95 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 341.68 | test_vpc_redundant.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3614.53 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3612.07 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 79.94 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1150871429
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1150870182
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435#issuecomment-1344176950
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
@rohityadavcloud
yes, it requires a new systemvm template
Actually, any change with init.sh and bootstrap.sh requires a new systemvm template SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6435: VPC VR: fix /etc/network/interfaces is misconfigured
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6435:
URL: https://github.com/apache/cloudstack/pull/6435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org