You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/22 18:35:02 UTC
[GitHub] [superset] prosdev0107 opened a new pull request #19316: fix(explore): make to convert null to N/A in view results
prosdev0107 opened a new pull request #19316:
URL: https://github.com/apache/superset/pull/19316
### SUMMARY
NULL values not showing up in View Results in Explore
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
BEFORE:
AFTER:
### TESTING INSTRUCTIONS
How to reproduce the issue
1. Go to Chart Table. (can try with cleaned_sales_data datasets)
2. Set the Group BY as territorry field
3. Set the Metrics as SUM(price_each)
4. Run the chart
5. Table has the null value, this is displayed as N/A
6. But in View results, Table don't show null value as N/A like viz chart table.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] prosdev0107 commented on a change in pull request #19316: fix(explore): make to convert null to N/A in view results
Posted by GitBox <gi...@apache.org>.
prosdev0107 commented on a change in pull request #19316:
URL: https://github.com/apache/superset/pull/19316#discussion_r832546712
##########
File path: superset-frontend/src/explore/components/DataTableControl/index.tsx
##########
@@ -49,6 +50,10 @@ import {
unsetTimeFormattedColumn,
} from 'src/explore/actions/exploreActions';
+export const CellNull = styled('span')`
Review comment:
it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] prosdev0107 commented on a change in pull request #19316: fix(explore): make to convert null to N/A in view results
Posted by GitBox <gi...@apache.org>.
prosdev0107 commented on a change in pull request #19316:
URL: https://github.com/apache/superset/pull/19316#discussion_r832543536
##########
File path: superset-frontend/src/explore/components/DataTableControl/index.tsx
##########
@@ -306,6 +311,9 @@ export const useTableColumns = (
if (timeFormattedColumnIndex > -1) {
return timeFormatter(value);
}
+ if (value === null) {
Review comment:
@diegomedina248
Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a change in pull request #19316: fix(explore): make to convert null to N/A in view results
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on a change in pull request #19316:
URL: https://github.com/apache/superset/pull/19316#discussion_r832531519
##########
File path: superset-frontend/src/explore/components/DataTableControl/index.tsx
##########
@@ -49,6 +50,10 @@ import {
unsetTimeFormattedColumn,
} from 'src/explore/actions/exploreActions';
+export const CellNull = styled('span')`
Review comment:
`styled.span` should work
##########
File path: superset-frontend/src/explore/components/DataTableControl/index.tsx
##########
@@ -306,6 +311,9 @@ export const useTableColumns = (
if (timeFormattedColumnIndex > -1) {
return timeFormatter(value);
}
+ if (value === null) {
Review comment:
I think this should be before the timeFormatter, if the value is NULL it might crash it.
Can you test it out? (pass null directly or force it somehow, to see what happens there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #19316: fix(explore): make to convert null to N/A in view results
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #19316:
URL: https://github.com/apache/superset/pull/19316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19316: fix(explore): make to convert null to N/A in view results
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19316:
URL: https://github.com/apache/superset/pull/19316#issuecomment-1075590099
# [Codecov](https://codecov.io/gh/apache/superset/pull/19316?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19316](https://codecov.io/gh/apache/superset/pull/19316?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (308e39c) into [master](https://codecov.io/gh/apache/superset/commit/d10a3d8bbad9efec53b372c1962cf8e1eab9d7ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d10a3d8) will **decrease** coverage by `0.00%`.
> The diff coverage is `25.00%`.
```diff
@@ Coverage Diff @@
## master #19316 +/- ##
==========================================
- Coverage 66.65% 66.65% -0.01%
==========================================
Files 1672 1672
Lines 64611 64615 +4
Branches 6505 6506 +1
==========================================
+ Hits 43066 43067 +1
- Misses 19862 19864 +2
- Partials 1683 1684 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.33% <25.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/DataTableControl/index.tsx](https://codecov.io/gh/apache/superset/pull/19316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sL2luZGV4LnRzeA==) | `71.62% <25.00%> (-2.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19316?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19316?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d10a3d8...308e39c](https://codecov.io/gh/apache/superset/pull/19316?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org