[jira] [Commented] (HADOOP-13201) Print the directory paths when ViewFs denies the rename operation on internal dirs

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611154#comment-15611154 ] 

Rakesh R commented on HADOOP-13201:
-----------------------------------

Thanks [~tianyin] for reporting this. I've modified the exception message and placed {{src}} and {{dest}} properly, please review this.

> Print the directory paths when ViewFs denies the rename operation on internal dirs
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-13201
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13201
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: viewfs
>    Affects Versions: 2.7.2
>            Reporter: Tianyin Xu
>         Attachments: HADOOP-13201-001.patch, HADOOP-13201.000.patch
>
>
> With ViewFs, the delete and rename operations on internal dirs are denied by throwing {{AccessControlException}}. 
> Unlike the {{delete()}} which notify the internal dir path, rename does not. 
> The attached patch appends the directory path on the logged exception.
> {code:title=ViewFs.java|borderStyle=solid}
>      InodeTree.ResolveResult<AbstractFileSystem> resSrc = 
>        fsState.resolve(getUriPath(src), false); 
>      if (resSrc.isInternalDir()) {
>        throw new AccessControlException(
> -          "Cannot Rename within internal dirs of mount table: it is readOnly");
> +          "Cannot Rename within internal dirs of mount table: it is readOnly"
> +          + src);
>      }
>        
>      InodeTree.ResolveResult<AbstractFileSystem> resDst = 
>                                  fsState.resolve(getUriPath(dst), false);
>      if (resDst.isInternalDir()) {
>        throw new AccessControlException(
> -          "Cannot Rename within internal dirs of mount table: it is readOnly");
> +          "Cannot Rename within internal dirs of mount table: it is readOnly"
> +          + dst);
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org