[jira] [Resolved] (WICKET-5866) Reconsider generics of IConverterLocator#getConverter()

["Sven Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-5866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier resolved WICKET-5866.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 7.5.0

#createConverter() can be overriden instead of #getConverter(), the former without the hassle of a generics parameter

> Reconsider generics of IConverterLocator#getConverter()
> -------------------------------------------------------
>
>                 Key: WICKET-5866
>                 URL: https://issues.apache.org/jira/browse/WICKET-5866
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 7.0.0
>            Reporter: Sven Meier
>            Assignee: Sven Meier
>            Priority: Minor
>             Fix For: 8.0.0-M2, 7.5.0
>
>
> IConverterLocator#getConverter() has a generic parameter <C> currently.
> It seems to me that this is not very useful: almost all code calling #getConverter() does not care for the type parameter.
> From the user perspective it's very common to override Component#getConverter(). With the need for a cast and to suppress the generics warning, providing a custom converter is much too hard currently:
> {code}
>     public <C> IConverter<C> getConverter(Class<C> clazz)
>      {
>          if (Date.class.isAssignableFrom(clazz))
>          {
>              @SuppressWarnings("unchecked")
>              return (IConverter<C>)new DateConverter();
>          }
>          else
>          {
>              return super.getConverter(clazz);
>          }
>      }
> {code}
> I propose to remove the generics parameter from the method:
> {code}
>     public IConverter<?> getConverter(Class<?> clazz)
>      {
>          if (Date.class.isAssignableFrom(clazz))
>          {
>              return new DateConverter();
>          }
>          else
>          {
>              return super.getConverter(clazz);
>          }
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)