[GitHub] [incubator-sdap-nexus] skorper commented on a change in pull request #155: SDAP-367: Updated deletebyquery tool to improve speed

[GitBox <gi...@apache.org>]

skorper commented on a change in pull request #155:
URL: https://github.com/apache/incubator-sdap-nexus/pull/155#discussion_r822232997



##########
File path: tools/deletebyquery/deletebyquery.py
##########
@@ -160,16 +161,15 @@ def do_solr_query(query):
             break
         else:
             next_cursor_mark = solr_response.result.nextCursorMark
-
-        doc_ids.extend([uuid.UUID(doc['id']) for doc in solr_response.result.response.docs])
+        ids = [uuid.UUID(doc['id']) for doc in solr_response.result.response.docs]
+        delete_from_cassandra(ids)

Review comment:
       @frankinspace Whoops, good point. I'll refactor this
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org