[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4018: Fix #3904 increase xslt extension test coverage

[GitBox <gi...@apache.org>]

ppalaga commented on code in PR #4018:
URL: https://github.com/apache/camel-quarkus/pull/4018#discussion_r950036555


##########
integration-tests/xml/pom.xml:
##########
@@ -35,14 +35,30 @@
             <groupId>org.apache.camel.quarkus</groupId>
             <artifactId>camel-quarkus-xslt</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-xslt-saxon</artifactId>
+        </dependency>
         <dependency>
             <groupId>org.apache.camel.quarkus</groupId>
             <artifactId>camel-quarkus-xpath</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-bean</artifactId>
+        </dependency>
         <dependency>
             <groupId>org.apache.camel.quarkus</groupId>
             <artifactId>camel-quarkus-direct</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-file</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-mock</artifactId>
+        </dependency>

Review Comment:
   @zhfeng I have some concerns about adding this many new dependencies to the test. I mean it is generally better to test with as little dependencies as possible, so that it does not happen that an extension that is there just for testing some niche feature brings some build steps that become vital for the execution of some basic functionality.
   
   Wouldn't it perhaps be worthwhile to introduce a new XML testing group like we already have with [Azure, AWS an others](https://github.com/apache/camel-quarkus/tree/main/integration-test-groups)? We could have several XML modules there that would test the use cases coverable with their minimal set of deps and ideally still be able to run them all together on the CI (in the grouped module), so that the exec time does not explode. See also https://camel.apache.org/camel-quarkus/2.11.x/contributor-guide/extension-testing.html#_grouping
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org