You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "xishuaidelin (via GitHub)" <gi...@apache.org> on 2023/08/23 16:09:00 UTC
[GitHub] [flink] xishuaidelin opened a new pull request, #23272: [FLINK-28866] Use DDL instead of legacy method to register the test s…
xishuaidelin opened a new pull request, #23272:
URL: https://github.com/apache/flink/pull/23272
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request aims to use DDL instead of legacy method to register the test source in JoinITCase and relates to FLINK-28866.
## Brief change log
Modified the table.planner.runtime.batch.sql.join.JoinITCase class.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #23272: [FLINK-28866] Use DDL instead of legacy method to register the test s…
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23272:
URL: https://github.com/apache/flink/pull/23272#issuecomment-1690247406
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b163e9bb463514ddf4aa89d82e7c3caa9d77ef86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b163e9bb463514ddf4aa89d82e7c3caa9d77ef86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b163e9bb463514ddf4aa89d82e7c3caa9d77ef86 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lincoln-lil merged pull request #23272: [FLINK-28866] Use DDL instead of legacy method to register the test s…
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil merged PR #23272:
URL: https://github.com/apache/flink/pull/23272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xishuaidelin commented on pull request #23272: [FLINK-28866] Use DDL instead of legacy method to register the test s…
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on PR #23272:
URL: https://github.com/apache/flink/pull/23272#issuecomment-1691658609
> @xishuaidelin We should remember to include the module name information in the commit title (I didn't notice it when I merged just now.. I'll take care of that too)
Thanks for reminding :) I will pay attention next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lincoln-lil commented on a diff in pull request #23272: [FLINK-28866] Use DDL instead of legacy method to register the test s…
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on code in PR #23272:
URL: https://github.com/apache/flink/pull/23272#discussion_r1303682814
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCase.scala:
##########
@@ -52,14 +53,83 @@ class JoinITCase extends BatchTestBase {
@BeforeEach
override def before(): Unit = {
super.before()
- registerCollection("SmallTable3", smallData3, type3, "a, b, c", nullablesOfSmallData3)
- registerCollection("Table3", data3, type3, "a, b, c", nullablesOfData3)
- registerCollection("Table5", data5, type5, "d, e, f, g, h", nullablesOfData5)
- registerCollection("NullTable3", nullData3, type3, "a, b, c", nullablesOfNullData3)
- registerCollection("NullTable5", nullData5, type5, "d, e, f, g, h", nullablesOfNullData5)
- registerCollection("l", data2_1, INT_DOUBLE, "a, b")
- registerCollection("r", data2_2, INT_DOUBLE, "c, d")
- registerCollection("t", data2_3, INT_DOUBLE, "c, d", nullablesOfData2_3)
+ val smallData3Id = TestValuesTableFactory.registerData(smallData3)
+ val data3Id = TestValuesTableFactory.registerData(data3)
+ val nullData3Id = TestValuesTableFactory.registerData(nullData3)
+ val data5Id = TestValuesTableFactory.registerData(data5)
+ val nullData5Id = TestValuesTableFactory.registerData(nullData5)
+ val data21Id = TestValuesTableFactory.registerData(data2_1)
+ val data22Id = TestValuesTableFactory.registerData(data2_2)
+ val data23Id = TestValuesTableFactory.registerData(data2_3)
+
+ var ddl =
+ s"""CREATE TEMPORARY TABLE SmallTable3 (
+ | a int,
+ | b bigint,
+ | c string
+ |)WITH(
+ | 'connector' = 'values',
+ | 'data-id' = '$smallData3Id',
+ | 'bounded' = 'true'
+ |)
+ |""".stripMargin
+ tEnv.executeSql(ddl)
Review Comment:
we can execute ddl directly thus ommiting the local variable and replacement
```
tEnv.executeSql(s"""CREATE TEMPORARY TABLE SmallTable3 (
| a int,
| b bigint,
| c string
|)WITH(
| 'connector' = 'values',
| 'data-id' = '$smallData3Id',
| 'bounded' = 'true'
|)
|""".stripMargin)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lincoln-lil commented on pull request #23272: [FLINK-28866] Use DDL instead of legacy method to register the test s…
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #23272:
URL: https://github.com/apache/flink/pull/23272#issuecomment-1691212926
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lincoln-lil commented on pull request #23272: [FLINK-28866] Use DDL instead of legacy method to register the test s…
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #23272:
URL: https://github.com/apache/flink/pull/23272#issuecomment-1691225506
@xishuaidelin We should remember to include the module name information in the commit title (I didn't notice it when I merged just now.. I'll take care of that too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org