You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by ji...@apache.org on 2022/02/18 12:43:26 UTC

[shardingsphere] branch master updated: Disable scaling enabled check when altering sharding rule for now (#15503)

This is an automated email from the ASF dual-hosted git repository.

jianglongtao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 6d3ff3a  Disable scaling enabled check when altering sharding rule for now (#15503)
6d3ff3a is described below

commit 6d3ff3ab111c0741bc4acb4f235174f4f4238525
Author: Hongsheng Zhong <sa...@126.com>
AuthorDate: Fri Feb 18 20:42:21 2022 +0800

    Disable scaling enabled check when altering sharding rule for now (#15503)
---
 .../backend/text/distsql/rdl/rule/RuleDefinitionBackendHandler.java    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rdl/rule/RuleDefinitionBackendHandler.java b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rdl/rule/RuleDefinitionBackendHandler.java
index 092260a..564c079 100644
--- a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rdl/rule/RuleDefinitionBackendHandler.java
+++ b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rdl/rule/RuleDefinitionBackendHandler.java
@@ -83,7 +83,8 @@ public final class RuleDefinitionBackendHandler<T extends RuleDefinitionStatemen
                 new Properties());
         if (!RuleAlteredJobWorker.isOnRuleAlteredActionEnabled(currentRuleConfig)) {
             if (RULE_ALTERED_ACTION_LIST.contains(sqlStatement.getClass().getCanonicalName())) {
-                throw new RuntimeException("scaling is not enabled");
+                // TODO throw new RuntimeException("scaling is not enabled");
+                log.warn("rule altered and scaling is not enabled.");
             }
         } else if (preprocessor.isPresent()) {
             prepareScaling(shardingSphereMetaData, sqlStatement, (RuleDefinitionAlterUpdater) ruleDefinitionUpdater, currentRuleConfig, preprocessor.get());