You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/31 16:55:03 UTC
[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1164:
[MINOR] String format should use %n rather than \n
lamber-ken opened a new pull request #1164: [MINOR] String format should use %n rather than \n
URL: https://github.com/apache/incubator-hudi/pull/1164
## What is the purpose of the pull request
From Java Tutorials docs, we can learn that String format should use %n rather than \n.
https://docs.oracle.com/javase/tutorial/java/data/numberformat.html
## Brief change log
- Change `\n` to `%n`.
## Verify this pull request
This pull request is a trivial code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken closed pull request #1164: [MINOR]
String format should use %n rather than \n
Posted by GitBox <gi...@apache.org>.
lamber-ken closed pull request #1164: [MINOR] String format should use %n rather than \n
URL: https://github.com/apache/incubator-hudi/pull/1164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1164: [MINOR] String
format should use %n rather than \n
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1164: [MINOR] String format should use %n rather than \n
URL: https://github.com/apache/incubator-hudi/pull/1164#issuecomment-570123953
Hi @lamber-ken thanks for your contribution. Currently, the community is redoing on replacing log4j with slf4j. After this work, the `String.format();` will be removed. Therefore, maybe we do not need this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1164: [MINOR]
String format should use %n rather than \n
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1164: [MINOR] String format should use %n rather than \n
URL: https://github.com/apache/incubator-hudi/pull/1164#issuecomment-570124258
> Hi @lamber-ken thanks for your contribution. Currently, the community is redoing on replacing log4j with slf4j. After this work, the `String.format();` will be removed. Therefore, maybe we do not need this PR?
Okay, I got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services