You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2026/08/19 00:52:57 UTC
[PR] Fix flaky measure schema-merge timestamps [skywalking-banyandb]
hanahmily opened a new pull request, #1288:
URL: https://github.com/apache/skywalking-banyandb/pull/1288
### Fix flaky measure schema-merge test timestamps
- [x] Add a test verification that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
The schema-merge test starts with a millisecond-aligned timestamp, but near midnight it divides the elapsed-since-midnight duration by two and four to keep both batches in the same segment. Duration division can introduce fractional milliseconds, causing BanyanDB to reject the generated writes with `invalid timestamp: time is not millisecond precision`.
Normalize the final batch timestamps to millisecond precision after applying the calculated offsets. This preserves the intended ordering and segment placement while satisfying the write API contract.
#### Validation
```text
go test ./banyand/measure -run TestMeasure -ginkgo.focus='Measure schema with changed tag type after merge' -count=1
```
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix flaky schema-merge tests near midnight [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #1288:
URL: https://github.com/apache/skywalking-banyandb/pull/1288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org