[GitHub] [iceberg] rdblue commented on pull request #2240: Auto promote sorted column metrics to truncate(16)

[GitBox <gi...@apache.org>]

rdblue commented on pull request #2240:
URL: https://github.com/apache/iceberg/pull/2240#issuecomment-786341170


   I don't think I would approach the problem as @aokolnychyi is suggesting. I thought that this would promote when accessing the metrics. So basically `MetricsConfig.fromProperties` becomes `MetricsConfig.forTable` so that it can be based on both the properties and the sort order for a table. I think that would be a reasonably small change.
   
   The advantage of that approach is that the sort order doesn't make changes to table properties. Those are always configured by users.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org