You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/04 03:25:48 UTC
[GitHub] [spark] beliefer opened a new pull request, #39378: [SPARK-41821][CONNECT][PYTHON] Fix doc test for DataFrame.describe
beliefer opened a new pull request, #39378:
URL: https://github.com/apache/spark/pull/39378
### What changes were proposed in this pull request?
Currently, the python doc test failed caused by `DataFrame.describe`
```
File "/Users/s.singh/personal/spark-oss/python/pyspark/sql/connect/dataframe.py", line 898, in pyspark.sql.connect.dataframe.DataFrame.describe
Failed example:
df.describe(['age']).show()
Exception raised:
Traceback (most recent call last):
File "/usr/local/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/doctest.py", line 1350, in __run
exec(compile(example.source, filename, "single",
File "<doctest pyspark.sql.connect.dataframe.DataFrame.describe[1]>", line 1, in <module>
df.describe(['age']).show()
File "/Users/s.singh/personal/spark-oss/python/pyspark/sql/connect/dataframe.py", line 832, in describe
raise TypeError(f"'cols' must be list[str], but got {type(s).__name__}")
TypeError: 'cols' must be list[str], but got list
```
### Why are the changes needed?
Let the python doc test success.
### Does this PR introduce _any_ user-facing change?
'No'.
New feature.
### How was this patch tested?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #39378: [SPARK-41821][CONNECT][PYTHON] Fix doc test for DataFrame.describe
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #39378:
URL: https://github.com/apache/spark/pull/39378#issuecomment-1371606490
ping @zhengruifeng cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #39378: [SPARK-41821][CONNECT][PYTHON] Fix doc test for DataFrame.describe
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #39378:
URL: https://github.com/apache/spark/pull/39378#issuecomment-1371811698
@HyukjinKwon @zhengruifeng Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39378: [SPARK-41821][CONNECT][PYTHON] Fix doc test for DataFrame.describe
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39378:
URL: https://github.com/apache/spark/pull/39378#issuecomment-1371622584
> Shall we fix `TODO(SPARK-41821): Fix DataFrame.describe` below? You can remove:
>
> ```
> # TODO(SPARK-41821): Fix DataFrame.describe
> del pyspark.sql.connect.dataframe.DataFrame.describe.__doc__
> ```
+1, please also enable the doctest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39378: [SPARK-41821][CONNECT][PYTHON] Fix doc test for DataFrame.describe
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39378: [SPARK-41821][CONNECT][PYTHON] Fix doc test for DataFrame.describe
URL: https://github.com/apache/spark/pull/39378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39378: [SPARK-41821][CONNECT][PYTHON] Fix doc test for DataFrame.describe
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39378:
URL: https://github.com/apache/spark/pull/39378#issuecomment-1371806726
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org