You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/06/05 14:52:30 UTC
Review Request 35130: Handle if non-default value is used for
hbase.tmp.dir
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35130/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-11721
https://issues.apache.org/jira/browse/AMBARI-11721
Repository: ambari
Description
-------
tyu, with the changes due to BUG - 37006, now there is no logic in the HBase
stack definition to process the value of `hbase.tmp.dir`.
If user changes the value from the default (it is possible to change it using
UI or blueprint) then we will run into the same problem when UI was using the
value `/grid/0/...`. HBase master will fail to start if the root folder does
not have proper permissions.
I think the fix needed here is to have HBase scripts parse the folder path and
if it does not start with "/tmp" then it needs to process it and
create/chmod/chown folders as needed.
FYI, ddas/sgupta.
Diffs
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 65f72a7
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 1bfa7e4
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py e8585cd
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py afe3de6
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py da0d624
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 47e8ef3
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py c6ab01d
ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2c09011
ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json e7a516f
ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 83120eb
ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json 0b09520
ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 349a1cf
ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 1d40121
ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json f5a4487
ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 39f91c0
Diff: https://reviews.apache.org/r/35130/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 35130: Handle if non-default value is used for
hbase.tmp.dir
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35130/#review86794
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Червень 5, 2015, 12:52 після полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35130/
> -----------------------------------------------------------
>
> (Updated Червень 5, 2015, 12:52 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-11721
> https://issues.apache.org/jira/browse/AMBARI-11721
>
>
> Repository: ambari
>
>
> Description
> -------
>
> tyu, with the changes due to BUG - 37006, now there is no logic in the HBase
> stack definition to process the value of `hbase.tmp.dir`.
>
> If user changes the value from the default (it is possible to change it using
> UI or blueprint) then we will run into the same problem when UI was using the
> value `/grid/0/...`. HBase master will fail to start if the root folder does
> not have proper permissions.
>
> I think the fix needed here is to have HBase scripts parse the folder path and
> if it does not start with "/tmp" then it needs to process it and
> create/chmod/chown folders as needed.
>
> FYI, ddas/sgupta.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 65f72a7
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 1bfa7e4
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py e8585cd
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py afe3de6
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py da0d624
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 47e8ef3
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py c6ab01d
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2c09011
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json e7a516f
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 83120eb
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json 0b09520
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 349a1cf
> ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 1d40121
> ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json f5a4487
> ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 39f91c0
>
> Diff: https://reviews.apache.org/r/35130/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 35130: Handle if non-default value is used for
hbase.tmp.dir
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35130/#review87913
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Червень 11, 2015, 2:35 після полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35130/
> -----------------------------------------------------------
>
> (Updated Червень 11, 2015, 2:35 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-11721
> https://issues.apache.org/jira/browse/AMBARI-11721
>
>
> Repository: ambari
>
>
> Description
> -------
>
> tyu, with the changes due to BUG - 37006, now there is no logic in the HBase
> stack definition to process the value of `hbase.tmp.dir`.
>
> If user changes the value from the default (it is possible to change it using
> UI or blueprint) then we will run into the same problem when UI was using the
> value `/grid/0/...`. HBase master will fail to start if the root folder does
> not have proper permissions.
>
> I think the fix needed here is to have HBase scripts parse the folder path and
> if it does not start with "/tmp" then it needs to process it and
> create/chmod/chown folders as needed.
>
> FYI, ddas/sgupta.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 1bfa7e4
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py e8585cd
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py 97cdd32
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py afe3de6
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py da0d624
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 47e8ef3
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_service_check.py a5a360a
>
> Diff: https://reviews.apache.org/r/35130/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 35130: Handle if non-default value is used for
hbase.tmp.dir
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35130/
-----------------------------------------------------------
(Updated June 11, 2015, 2:35 p.m.)
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-11721
https://issues.apache.org/jira/browse/AMBARI-11721
Repository: ambari
Description
-------
tyu, with the changes due to BUG - 37006, now there is no logic in the HBase
stack definition to process the value of `hbase.tmp.dir`.
If user changes the value from the default (it is possible to change it using
UI or blueprint) then we will run into the same problem when UI was using the
value `/grid/0/...`. HBase master will fail to start if the root folder does
not have proper permissions.
I think the fix needed here is to have HBase scripts parse the folder path and
if it does not start with "/tmp" then it needs to process it and
create/chmod/chown folders as needed.
FYI, ddas/sgupta.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 1bfa7e4
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py e8585cd
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py 97cdd32
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py afe3de6
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py da0d624
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 47e8ef3
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_service_check.py a5a360a
Diff: https://reviews.apache.org/r/35130/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk