You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Igor Galić <i....@brainsware.org> on 2013/06/25 12:57:41 UTC

Re: [1/2] git commit: TS-1960 Decouple stacksize config from core


----- Original Message -----
> Updated Branches:
>   refs/heads/master b3fd17694 -> b1f0300f7
> 
> 
> TS-1960 Decouple stacksize config from core

There's a couple of instances here where you hard-code the stacksize
in function calls to 1MiB -- what's the reasoning behind this?

-- i
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Re: [1/2] git commit: TS-1960 Decouple stacksize config from core

Posted by Leif Hedstrom <zw...@apache.org>.
On 6/25/13 4:57 AM, Igor Galić wrote:
>
> ----- Original Message -----
>> Updated Branches:
>>    refs/heads/master b3fd17694 -> b1f0300f7
>>
>>
>> TS-1960 Decouple stacksize config from core
> There's a couple of instances here where you hard-code the stacksize
> in function calls to 1MiB -- what's the reasoning behind this?

Those are in unit tests, and I don't want us to fail the unit tests by 
someone or something changing the records.config settings. I know that they 
work with 1MB, hence the hardcoded value. It also avoids calling that config 
"getter" in the Unit tests :).

-- Leif