[jira] [Commented] (STORM-2338) Subprocess exception handling is broken in storm.py on Windows environment

["Tibor Kiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855348#comment-15855348 ] 

Tibor Kiss commented on STORM-2338:
-----------------------------------

Thanks for merging, [~kabhwan]!

> Subprocess exception handling is broken in storm.py on Windows environment
> --------------------------------------------------------------------------
>
>                 Key: STORM-2338
>                 URL: https://issues.apache.org/jira/browse/STORM-2338
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 2.0.0, 1.x, 0.10.3
>            Reporter: Tibor Kiss
>            Assignee: Tibor Kiss
>            Priority: Minor
>             Fix For: 2.0.0, 1.1.0, 1.0.3
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There is typo in the exception handling branch in {{storm.py:: exec_storm_class()}}:
> {code}
>         try:
>             ret = sub.check_output(all_args, stderr=sub.STDOUT)
>             print(ret)
>         except sub.CalledProcessor as e:
>             sys.exit(e.returncode)
> {code}
> There is no "CalledProcessor" type of exception exists in subprocess module.
> The correct exception name is CalledProcessError.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)