[GitHub] [echarts] 100pah edited a comment on pull request #14571: feature: geo component and map series support SVG format source

[GitBox <gi...@apache.org>]

100pah edited a comment on pull request #14571:
URL: https://github.com/apache/echarts/pull/14571#issuecomment-1007530184


   [memento] Some historical discussion about: 
   + A. "all use `itemStyle`" 
       + cons, 
           + If `<line>` uses `itemStyle`, `itemStyle.color` means `stoke`, it might be weird to use `color` and `borderWidth` on line.
   + B. "`<line>` and `<polyline>` use `lineStyle` while others use `itemStyle`".
       + cons, 
           + Some SVG uses `fill` on `<polyline>`, if `<polyline>` uses `lineStyle`, `fill` can not be specified. **[major factor]**
           + not easy to realize this special settings. If users intent to set opacity, it may be wried to set some opacity on `lineStyle` and some on `itemStyle`.
           + most of SVG uses `<path>`, which seems can only use `itemStyle` even it used to draws a line.
      
   
   At present, the implementation is "all use `itemStyle`".
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org