You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2015/04/08 16:16:12 UTC
[GitHub] storm pull request: [STORM-483] extlib for external, extlib-daemon...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/516
[STORM-483] extlib for external, extlib-daemon for daemo-only external
1. Packaging creates two new directories named "extlib" and "extlib-daemon" for holding external jars, and daemons-only external jars, respectively.
2. "bin/storm" takes the jars from the above two directories and optional external classpaths, and puts into classpath for launching exec_storm_class (for daemons).
3. In supervisor, when launching a worker, worker-classpath is built from scratch (include extlib but not include extlib-daemon), rather than inherited from supervisor's current-classpath . This is for avoiding classpath leakage from daemons to workers.
Thanks Robert and Naga's comments and proposal.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/516.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #516
----
commit 05306d5053ff91bd323c4b54cd246c9f928ca339
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-04-08T13:57:31Z
Deal with STORM-483 exlib issue
commit c106f1337f84cf7f46be0a133b3bd17b57412d3f
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-04-08T14:03:42Z
Merge remote-tracking branch 'apache/master'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-483] extlib for external, extlib-daemon...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/516#issuecomment-95337405
+1 (and I assume @revans2 feels the same and just forgot to comment as such :) ).
I would suggest that we open a ticket to document this for end users since it is a departure from how things worked in the past, and might trip up some users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-483] extlib for external, extlib-daemon...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/516#issuecomment-95345159
Yes +1 thanks @ptgoetz I had the comment written but didn't hit the button. Boy I feel dumb, and I agree on the documentation as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-483] extlib for external, extlib-daemon...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/516#discussion_r28283336
--- Diff: bin/storm.py ---
@@ -85,6 +85,10 @@ def init_storm_env():
JAR_JVM_OPTS = shlex.split(os.getenv('STORM_JAR_JVM_OPTS', ''))
JAVA_HOME = os.getenv('JAVA_HOME', None)
JAVA_CMD = 'java' if not JAVA_HOME else os.path.join(JAVA_HOME, 'bin', 'java')
+NIMBUS_EXTRA_CLASSPATHS = os.getenv('NIMBUS_EXTRA_CLASSPATHS', None)
+SUPERVISOR_EXTRA_CLASSPATHS = os.getenv('SUPERVISOR_EXTRA_CLASSPATHS', None)
--- End diff --
I don't see a reason to have NIMBUS and SUPERVISOR specific class paths options. If you have a good use case, please let me know otherwise I would like to see them removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-483] extlib for external, extlib-daemon...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/516
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---