You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/10/30 12:51:52 UTC
[Bug 55724] New: [PATCH] Implementation of Excel PERCENTILE function
https://issues.apache.org/bugzilla/show_bug.cgi?id=55724
Bug ID: 55724
Summary: [PATCH] Implementation of Excel PERCENTILE function
Product: POI
Version: 3.9
Hardware: PC
Status: NEW
Severity: enhancement
Priority: P2
Component: POI Overall
Assignee: dev@poi.apache.org
Reporter: tenielg@live.com
Created attachment 30985
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30985&action=edit
patch
Attached is an implementation of Excel PERCENTILE function.
This is my first ever submission to the Apache POI project, so please advise me
if I have done anything wrong.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 55724] [PATCH] Implementation of Excel PERCENTILE function
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55724
tenielg@live.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from tenielg@live.com ---
Thank you Cédric for your fixing and comments on my code. (I did not think of
looking up the official Excel documentation - thank you, and I know for next
time.) Please see test case as requested.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 55724] [PATCH] Implementation of Excel PERCENTILE function
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55724
Nick Burch <ap...@gagravarr.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
Thanks for this!
Any chance you could work up a unit test for the function? That will let us
check that it's working right now, and also ensure it doesn't get broken in
future
Also, if possible, and update to the overall formula evaluation checking tests
in FormulaEvalTestData would be great. Bug #54469 has quite a bit on that in
it, if you want to see how people have helped with that in the past
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 55724] [PATCH] Implementation of Excel PERCENTILE function
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55724
Cédric Walter <ce...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #3 from Cédric Walter <ce...@gmail.com> ---
Thanks for your contribution! I did:
1. Just add a missing error handling in percentile:
if array is empty or contains more than 8,191 data points, PERCENTILE returns
the #NUM! error value.
2. Added tests in overall formula evaluation checking in
FormulaEvalTestData.xls. I found no differences between your code and excel
evaluation of PERCENTILE.
But please provide a unit test TestPercentile.java so i can close the issue
revision 1539154
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 55724] [PATCH] Implementation of Excel PERCENTILE function
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55724
--- Comment #2 from tenielg@live.com ---
When you say unit test do you mean to write
\testcases\org\apache\poi\ss\formula\functions\TestPercentile.java?
And do you mean to update the Excel FormulaEvalTestData.xls? Where is the
latest version I can download?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 55724] [PATCH] Implementation of Excel PERCENTILE function
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55724
--- Comment #4 from tenielg@live.com ---
Created attachment 31017
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31017&action=edit
Testcase for Percentile
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 55724] [PATCH] Implementation of Excel PERCENTILE function
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55724
Cédric Walter <ce...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #6 from Cédric Walter <ce...@gmail.com> ---
Thanks you, your unit has been merged in revision 1539401 to trunk
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org