[GitHub] [spark] huaxingao commented on a change in pull request #35070: [SPARK-37789][SQL] Add a class to represent general aggregate functions in DS V2

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #35070:
URL: https://github.com/apache/spark/pull/35070#discussion_r777292801



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -209,6 +210,11 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] with PredicateHelper {
       }
   }
 
+  private def supportPartialAggPushDown(agg: Aggregation): Boolean = {
+    // We don't know the agg buffer of `GeneralAggregateFunc`, so can't do partial agg push down.
+    agg.aggregateExpressions().exists(_.isInstanceOf[GeneralAggregateFunc])

Review comment:
       The original code was correct. 
   We probably want to add a test that has `avg` and multiple partitions to cover the case of `!supportPartialAggPushDown`  and `!supportCompletePushDown`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org