You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/14 12:12:29 UTC

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #5183: UnconfiguredSchemaMetaData is NPE.

yu199195 opened a new pull request #5183: UnconfiguredSchemaMetaData is NPE.
URL: https://github.com/apache/incubator-shardingsphere/pull/5183
 
 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #5183: UnconfiguredSchemaMetaData is NPE.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5183: UnconfiguredSchemaMetaData is NPE.
URL: https://github.com/apache/incubator-shardingsphere/pull/5183#issuecomment-613430236
 
 
   ## Pull Request Test Coverage Report for [Build 11046](https://coveralls.io/builds/30067890)
   
   * **2** of **2**   **(100.0%)**  changed or added relevant lines in **1** file are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage decreased (**-0.004%**) to **57.524%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-namespace/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/namespace/parser/ShardingStrategyBeanDefinition.java](https://coveralls.io/builds/30067890/source?filename=sharding-spring%2Fsharding-jdbc-spring%2Fsharding-jdbc-spring-namespace%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fspring%2Fnamespace%2Fparser%2FShardingStrategyBeanDefinition.java#L53) | 1 | 95.83% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30067890/badge)](https://coveralls.io/builds/30067890) |
   | :-- | --: |
   | Change from base [Build 11039](https://coveralls.io/builds/30063880): |  -0.004% |
   | Covered Lines: | 11835 |
   | Relevant Lines: | 20574 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 commented on a change in pull request #5183: UnconfiguredSchemaMetaData is NPE.

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #5183: UnconfiguredSchemaMetaData is NPE.
URL: https://github.com/apache/incubator-shardingsphere/pull/5183#discussion_r408133657
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/yaml/RuleSchemaMetaDataYamlSwapper.java
 ##########
 @@ -47,8 +47,8 @@ public YamlRuleSchemaMetaData swap(final RuleSchemaMetaData metaData) {
     @Override
     public RuleSchemaMetaData swap(final YamlRuleSchemaMetaData yaml) {
         SchemaMetaData configured = convertSchema(yaml.getConfiguredSchemaMetaData());
-        Map<String, SchemaMetaData> unconfigured = yaml.getUnconfiguredSchemaMetaDataMap().entrySet().stream()
-                .collect(Collectors.toMap(entry -> entry.getKey(), entry -> convertSchema(entry.getValue())));
+        Map<String, SchemaMetaData> unconfigured = yaml.getUnconfiguredSchemaMetaDataMap() == null ? Collections.emptyMap() : yaml.getUnconfiguredSchemaMetaDataMap().entrySet().stream()
 
 Review comment:
   ok，fix it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #5183: UnconfiguredSchemaMetaData is NPE.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5183: UnconfiguredSchemaMetaData is NPE.
URL: https://github.com/apache/incubator-shardingsphere/pull/5183#discussion_r408124381
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/yaml/RuleSchemaMetaDataYamlSwapper.java
 ##########
 @@ -47,8 +47,8 @@ public YamlRuleSchemaMetaData swap(final RuleSchemaMetaData metaData) {
     @Override
     public RuleSchemaMetaData swap(final YamlRuleSchemaMetaData yaml) {
         SchemaMetaData configured = convertSchema(yaml.getConfiguredSchemaMetaData());
-        Map<String, SchemaMetaData> unconfigured = yaml.getUnconfiguredSchemaMetaDataMap().entrySet().stream()
-                .collect(Collectors.toMap(entry -> entry.getKey(), entry -> convertSchema(entry.getValue())));
+        Map<String, SchemaMetaData> unconfigured = yaml.getUnconfiguredSchemaMetaDataMap() == null ? Collections.emptyMap() : yaml.getUnconfiguredSchemaMetaDataMap().entrySet().stream()
 
 Review comment:
   We prefer use `null == xxx`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5183: UnconfiguredSchemaMetaData is NPE.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5183: UnconfiguredSchemaMetaData is NPE.
URL: https://github.com/apache/incubator-shardingsphere/pull/5183#issuecomment-613477905
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183?src=pr&el=h1) Report
   > Merging [#5183](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f00955686375eb2708e94ed6f573c4992fffe9cd&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5183      +/-   ##
   ============================================
   - Coverage     54.15%   54.07%   -0.08%     
   + Complexity      406      402       -4     
   ============================================
     Files          1158     1158              
     Lines         20568    20574       +6     
     Branches       3707     3712       +5     
   ============================================
   - Hits          11138    11126      -12     
   - Misses         8737     8753      +16     
   - Partials        693      695       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...datacenter/yaml/RuleSchemaMetaDataYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLW1ldGFkYXRhY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvbWV0YWRhdGFjZW50ZXIveWFtbC9SdWxlU2NoZW1hTWV0YURhdGFZYW1sU3dhcHBlci5qYXZh) | `94.73% <50.00%> (-2.64%)` | `0.00 <0.00> (ø)` | |
   | [.../core/strategy/route/ShardingAlgorithmFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9TaGFyZGluZ0FsZ29yaXRobUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ategy/route/standard/StandardShardingStrategy.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9zdGFuZGFyZC9TdGFuZGFyZFNoYXJkaW5nU3RyYXRlZ3kuamF2YQ==) | `50.00% <0.00%> (-12.97%)` | `0.00% <0.00%> (ø%)` | |
   | [...pper/ShardingStrategyConfigurationYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL3N3YXBwZXIvU2hhcmRpbmdTdHJhdGVneUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `82.43% <0.00%> (-5.24%)` | `0.00% <0.00%> (ø%)` | |
   | [...command/query/text/PostgreSQLComQueryExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9mcm9udGVuZC9wb3N0Z3Jlc3FsL2NvbW1hbmQvcXVlcnkvdGV4dC9Qb3N0Z3JlU1FMQ29tUXVlcnlFeGVjdXRvci5qYXZh) | `22.58% <0.00%> (-3.23%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ry/binary/execute/MySQLComStmtExecuteExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5ncHJveHkvZnJvbnRlbmQvbXlzcWwvY29tbWFuZC9xdWVyeS9iaW5hcnkvZXhlY3V0ZS9NeVNRTENvbVN0bXRFeGVjdXRlRXhlY3V0b3IuamF2YQ==) | `22.85% <0.00%> (-2.86%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../query/text/query/MySQLComQueryPacketExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5ncHJveHkvZnJvbnRlbmQvbXlzcWwvY29tbWFuZC9xdWVyeS90ZXh0L3F1ZXJ5L015U1FMQ29tUXVlcnlQYWNrZXRFeGVjdXRvci5qYXZh) | `17.94% <0.00%> (-2.57%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...d/query/binary/bind/PostgreSQLComBindExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9mcm9udGVuZC9wb3N0Z3Jlc3FsL2NvbW1hbmQvcXVlcnkvYmluYXJ5L2JpbmQvUG9zdGdyZVNRTENvbUJpbmRFeGVjdXRvci5qYXZh) | `25.58% <0.00%> (-2.33%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...mespace/parser/ShardingStrategyBeanDefinition.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL1NoYXJkaW5nU3RyYXRlZ3lCZWFuRGVmaW5pdGlvbi5qYXZh) | `91.66% <0.00%> (-0.65%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183?src=pr&el=footer). Last update [f009556...0b058ff](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5183?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5183: UnconfiguredSchemaMetaData is NPE.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5183: UnconfiguredSchemaMetaData is NPE.
URL: https://github.com/apache/incubator-shardingsphere/pull/5183#issuecomment-613430236
 
 
   ## Pull Request Test Coverage Report for [Build 11043](https://coveralls.io/builds/30065456)
   
   * **2** of **2**   **(100.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.528%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30065456/badge)](https://coveralls.io/builds/30065456) |
   | :-- | --: |
   | Change from base [Build 11039](https://coveralls.io/builds/30063880): |  0.0% |
   | Covered Lines: | 11837 |
   | Relevant Lines: | 20576 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking merged pull request #5183: UnconfiguredSchemaMetaData is NPE.

Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #5183: UnconfiguredSchemaMetaData is NPE.
URL: https://github.com/apache/incubator-shardingsphere/pull/5183
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services