You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2014/01/16 05:29:30 UTC

Review Request 16945: AURORA-41: Fix broken test in client.cli.job

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16945/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.


Bugs: AURORA-41
    https://issues.apache.org/jira/browse/AURORA-41


Repository: aurora


Description
-------

AURORA-41: Fix broken test in client.cli.job

Fixes broken test runs introduced in commit a49d94c 'Fix bad merge commit'


Diffs
-----

  src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 

Diff: https://reviews.apache.org/r/16945/diff/


Testing
-------

Test suite passes again as expected

src.test.python.apache.aurora.admin.mesos_maintenance                           .....   SUCCESS
src.test.python.apache.aurora.client.api.disambiguator                          .....   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher                       .....   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor                            .....   SUCCESS
src.test.python.apache.aurora.client.api.quota_check                            .....   SUCCESS
src.test.python.apache.aurora.client.api.restarter                              .....   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client                       .....   SUCCESS
src.test.python.apache.aurora.client.api.updater                                .....   SUCCESS
src.test.python.apache.aurora.client.binding_helper                             .....   SUCCESS
src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
src.test.python.apache.aurora.client.commands.core                              .....   SUCCESS
src.test.python.apache.aurora.client.commands.run                               .....   SUCCESS
src.test.python.apache.aurora.client.commands.ssh                               .....   SUCCESS
src.test.python.apache.aurora.client.config                                     .....   SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api                           .....   SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api                       .....   SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key                        .....   SUCCESS
src.test.python.apache.aurora.common.test_cluster                               .....   SUCCESS
src.test.python.apache.aurora.common.test_cluster_option                        .....   SUCCESS
src.test.python.apache.aurora.common.test_clusters                              .....   SUCCESS
src.test.python.apache.aurora.common.test_http_signaler                         .....   SUCCESS
src.test.python.apache.aurora.config.test_base                                  .....   SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing                    .....   SUCCESS
src.test.python.apache.aurora.config.test_loader                                .....   SUCCESS
src.test.python.apache.aurora.config.test_thrift                                .....   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox                 .....   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker                    .....   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker                    .....   SUCCESS
src.test.python.apache.aurora.executor.common.task_info                         .....   SUCCESS
src.test.python.apache.aurora.executor.executor_detector                        .....   SUCCESS
src.test.python.apache.aurora.executor.executor_vars                            .....   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner                      .....   SUCCESS
src.test.python.apache.thermos.bin.test_thermos                                 .....   SUCCESS
src.test.python.apache.thermos.common.test_pathspec                             .....   SUCCESS
src.test.python.apache.thermos.common.test_planner                              .....   SUCCESS
src.test.python.apache.thermos.common.test_task_planner                         .....   SUCCESS
src.test.python.apache.thermos.config.test_schema                               .....   SUCCESS
src.test.python.apache.thermos.core.test_angry                                  .....   SUCCESS
src.test.python.apache.thermos.core.test_ephemerals                             .....   SUCCESS
src.test.python.apache.thermos.core.test_failing_runner                         .....   SUCCESS
src.test.python.apache.thermos.core.test_failure_limit                          .....   SUCCESS
src.test.python.apache.thermos.core.test_finalization                           .....   SUCCESS
src.test.python.apache.thermos.core.test_helper                                 .....   SUCCESS
src.test.python.apache.thermos.core.test_process                                .....   SUCCESS
src.test.python.apache.thermos.core.test_runner_integration                     .....   SUCCESS
src.test.python.apache.thermos.core.test_staged_kill                            .....   SUCCESS
src.test.python.apache.thermos.monitoring.test_disk                             .....   SUCCESS


Thanks,

Jake Farrell


Re: Review Request 16945: AURORA-41: Fix broken test in client.cli.job

Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16945/#review32019
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Chu-Carroll


On Jan. 15, 2014, 11:29 p.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16945/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2014, 11:29 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-41
>     https://issues.apache.org/jira/browse/AURORA-41
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-41: Fix broken test in client.cli.job
> 
> Fixes broken test runs introduced in commit a49d94c 'Fix bad merge commit'
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 
> 
> Diff: https://reviews.apache.org/r/16945/diff/
> 
> 
> Testing
> -------
> 
> Test suite passes again as expected
> 
> src.test.python.apache.aurora.admin.mesos_maintenance                           .....   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator                          .....   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher                       .....   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor                            .....   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check                            .....   SUCCESS
> src.test.python.apache.aurora.client.api.restarter                              .....   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client                       .....   SUCCESS
> src.test.python.apache.aurora.client.api.updater                                .....   SUCCESS
> src.test.python.apache.aurora.client.binding_helper                             .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
> src.test.python.apache.aurora.client.commands.core                              .....   SUCCESS
> src.test.python.apache.aurora.client.commands.run                               .....   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh                               .....   SUCCESS
> src.test.python.apache.aurora.client.config                                     .....   SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api                           .....   SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api                       .....   SUCCESS
> src.test.python.apache.aurora.common.test_aurora_job_key                        .....   SUCCESS
> src.test.python.apache.aurora.common.test_cluster                               .....   SUCCESS
> src.test.python.apache.aurora.common.test_cluster_option                        .....   SUCCESS
> src.test.python.apache.aurora.common.test_clusters                              .....   SUCCESS
> src.test.python.apache.aurora.common.test_http_signaler                         .....   SUCCESS
> src.test.python.apache.aurora.config.test_base                                  .....   SUCCESS
> src.test.python.apache.aurora.config.test_constraint_parsing                    .....   SUCCESS
> src.test.python.apache.aurora.config.test_loader                                .....   SUCCESS
> src.test.python.apache.aurora.config.test_thrift                                .....   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox                 .....   SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker                    .....   SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker                    .....   SUCCESS
> src.test.python.apache.aurora.executor.common.task_info                         .....   SUCCESS
> src.test.python.apache.aurora.executor.executor_detector                        .....   SUCCESS
> src.test.python.apache.aurora.executor.executor_vars                            .....   SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner                      .....   SUCCESS
> src.test.python.apache.thermos.bin.test_thermos                                 .....   SUCCESS
> src.test.python.apache.thermos.common.test_pathspec                             .....   SUCCESS
> src.test.python.apache.thermos.common.test_planner                              .....   SUCCESS
> src.test.python.apache.thermos.common.test_task_planner                         .....   SUCCESS
> src.test.python.apache.thermos.config.test_schema                               .....   SUCCESS
> src.test.python.apache.thermos.core.test_angry                                  .....   SUCCESS
> src.test.python.apache.thermos.core.test_ephemerals                             .....   SUCCESS
> src.test.python.apache.thermos.core.test_failing_runner                         .....   SUCCESS
> src.test.python.apache.thermos.core.test_failure_limit                          .....   SUCCESS
> src.test.python.apache.thermos.core.test_finalization                           .....   SUCCESS
> src.test.python.apache.thermos.core.test_helper                                 .....   SUCCESS
> src.test.python.apache.thermos.core.test_process                                .....   SUCCESS
> src.test.python.apache.thermos.core.test_runner_integration                     .....   SUCCESS
> src.test.python.apache.thermos.core.test_staged_kill                            .....   SUCCESS
> src.test.python.apache.thermos.monitoring.test_disk                             .....   SUCCESS
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


Re: Review Request 16945: AURORA-41: Fix broken test in client.cli.job

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16945/#review32041
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Jan. 16, 2014, 4:29 a.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16945/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 4:29 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-41
>     https://issues.apache.org/jira/browse/AURORA-41
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-41: Fix broken test in client.cli.job
> 
> Fixes broken test runs introduced in commit a49d94c 'Fix bad merge commit'
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 
> 
> Diff: https://reviews.apache.org/r/16945/diff/
> 
> 
> Testing
> -------
> 
> Test suite passes again as expected
> 
> src.test.python.apache.aurora.admin.mesos_maintenance                           .....   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator                          .....   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher                       .....   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor                            .....   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check                            .....   SUCCESS
> src.test.python.apache.aurora.client.api.restarter                              .....   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client                       .....   SUCCESS
> src.test.python.apache.aurora.client.api.updater                                .....   SUCCESS
> src.test.python.apache.aurora.client.binding_helper                             .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
> src.test.python.apache.aurora.client.commands.core                              .....   SUCCESS
> src.test.python.apache.aurora.client.commands.run                               .....   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh                               .....   SUCCESS
> src.test.python.apache.aurora.client.config                                     .....   SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api                           .....   SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api                       .....   SUCCESS
> src.test.python.apache.aurora.common.test_aurora_job_key                        .....   SUCCESS
> src.test.python.apache.aurora.common.test_cluster                               .....   SUCCESS
> src.test.python.apache.aurora.common.test_cluster_option                        .....   SUCCESS
> src.test.python.apache.aurora.common.test_clusters                              .....   SUCCESS
> src.test.python.apache.aurora.common.test_http_signaler                         .....   SUCCESS
> src.test.python.apache.aurora.config.test_base                                  .....   SUCCESS
> src.test.python.apache.aurora.config.test_constraint_parsing                    .....   SUCCESS
> src.test.python.apache.aurora.config.test_loader                                .....   SUCCESS
> src.test.python.apache.aurora.config.test_thrift                                .....   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox                 .....   SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker                    .....   SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker                    .....   SUCCESS
> src.test.python.apache.aurora.executor.common.task_info                         .....   SUCCESS
> src.test.python.apache.aurora.executor.executor_detector                        .....   SUCCESS
> src.test.python.apache.aurora.executor.executor_vars                            .....   SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner                      .....   SUCCESS
> src.test.python.apache.thermos.bin.test_thermos                                 .....   SUCCESS
> src.test.python.apache.thermos.common.test_pathspec                             .....   SUCCESS
> src.test.python.apache.thermos.common.test_planner                              .....   SUCCESS
> src.test.python.apache.thermos.common.test_task_planner                         .....   SUCCESS
> src.test.python.apache.thermos.config.test_schema                               .....   SUCCESS
> src.test.python.apache.thermos.core.test_angry                                  .....   SUCCESS
> src.test.python.apache.thermos.core.test_ephemerals                             .....   SUCCESS
> src.test.python.apache.thermos.core.test_failing_runner                         .....   SUCCESS
> src.test.python.apache.thermos.core.test_failure_limit                          .....   SUCCESS
> src.test.python.apache.thermos.core.test_finalization                           .....   SUCCESS
> src.test.python.apache.thermos.core.test_helper                                 .....   SUCCESS
> src.test.python.apache.thermos.core.test_process                                .....   SUCCESS
> src.test.python.apache.thermos.core.test_runner_integration                     .....   SUCCESS
> src.test.python.apache.thermos.core.test_staged_kill                            .....   SUCCESS
> src.test.python.apache.thermos.monitoring.test_disk                             .....   SUCCESS
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>