You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "JoaoJandre (via GitHub)" <gi...@apache.org> on 2023/08/24 19:56:01 UTC
[GitHub] [cloudstack] JoaoJandre opened a new pull request, #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
JoaoJandre opened a new pull request, #7131:
URL: https://github.com/apache/cloudstack/pull/7131
### Description
This PR normalizes ACS's loggers and upgrades log4j 1.2 to log4j 2.19. Back in 2015, PR #714 tried to normalize the loggers but, because that normalization caused some issues with the VMware module, it ended up being reverted. This PR intends to follow that PR's footsteps and normalize all of the loggers in ACS. The objective of reducing unnecessary logger declarations, and reduce the area of impact to upgrade ACS's logger framework from log4j 1.2 to log4 2.19.
The log4j upgrade was done similarly to the proposed here https://github.com/apache/cloudstack/pull/2992#issuecomment-439132311, and is more detailed ahead.
The logger normalization includes:
- Classes that could have their loggers inherited from their ancestors had their own loggers deleted;
- Most loggers didn't have to be static, thus most of them were normalized so that they wouldn't be;
- loggers are protected now;
- Static logger's names are now 'LOGGER';
- Non-static logger's names are now 'logger';
- New class DbUpgradeAbstractImpl created so that all Upgraders extend it and inherit its logger;
- The following classes now have loggers (so that all their children can inherit their loggers):
`BaseElement`, `PipelineImpl`, `AbstractRect`, `AbstractSmartLifeCycle`, `ManagedContextRunnable`, `Command`, `RuleApplier`, `VmWork`, `ModelObjectBase`, `SnapshotStrategyBase`, `VifDriver`.
To normalize all the loggers in ACS, the following steps were performed:
1. The DbUpgradeAbstractImpl class was created;
2. This script https://pastebin.pl/view/6ff71b26 was used to make all the Upgraders extend the DbUpgradeAbstractImpl class (I manually had to correct some of them afterward);
3. I ran this script https://pastebin.pl/view/89931790 for all ACS java classes; the, I checked if classes can inherit the logger from their ancestor*; if they can, then remove their current logger instantiation. If they cannot then leave the instantiation, but make it non-static. And in some cases, rename the logger references to `logger`;
4. I tried to build ACS many times and manually fixed the errors, most of them were because some loggers did indeed have to be static.
*The ancestor list I created came from a previous iteration of this process, where I tried to simply remove logger instantiation from any class that extended any other class, the list was created while manually fixing the errors.
For the log4j upgrade, the following steps were performed:
1. The relevant pom.xml files were updated;
2. This script https://pastebin.pl/view/0b6b77f9 was used to update all the logger imports;
3. I tried to build ACS many times and manually fixed the errors.
About the log4j upgrade:
- The DOMConfigurator does not exist in log4j2, its functionality was moved to the Configurator class;
- Both NDC and MDC were merged into the ThreadContext class;
Disclaimers:
- The new log4j2 configuration file format is not backwards compatible with the old one, users must update their configuration files to match with the new format. I used the official apache documentation to upgrade the default configurations, available [here](https://logging.apache.org/log4j/2.x/manual/migration.html#Log4j2ConfigurationFormat).
- If you call EncryptorCLI manually, you must also pass the log4j2 jar path (which should be in the same directory as cloud-utils).
The are still some points to address/discuss in order to make this PR ready:
- ~~Refactor the following classes so that they can be used in log4j2:`SnmpTrapAppender`, `AlertsSyslogAppender`, `TestAppender`, `SnmpEnhancedPatternLayout`~~;
- ~~Convert CglibThrowableRenderer functionality to log4j2;~~
- The log4j 1.2 dependency could not be completely removed because juniper contrail has log4j as a dependency.
- ~~Test logging for management, agent, usage, SSVMs and CPVMs~~
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [X] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
I tested if both the console and the file appenders were logging correctly in the management server, agents, and system VMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1608283729
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1603327103
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1506820924
@DaanHoogland, can we do another round of tests on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1568939992
> > Instead what I did was change where EncryptionCLI was called (cloud-setup-databases for example) to also pass the log4j2 jar files in the classpath. If you have a script that is calling the EncryptorCLI manually, you also have to pass the log4j2 jar path (which should be in the same directory as cloud-utils).
>
> ok, make sure this ends up in documentation somewhere, please. I will most certainly not be the only one that runs into this ;)
Sure, I've added it to the PR description for now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1634370631
@DaanHoogland a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1580197202
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1583151550
> This needs manual testing wrt log syntax/format and upgrade tests for supported matrix of env, for example:
>
> * Management and usage server host distros: EL7, EL8, EL9, Ubuntu 20.04, 22.04
>
> * Hypervisors: KVM (EL7, EL8, EL9, Ubuntu 22.04, 22.04), VMware (6.5, 6.7, 7.0, 8.0), XenServer 7.1, XCP-ng 8.2
>
> * Upgrade testing from ACS versions: 4.16 but atleast both 4.17, 4.18
>
>
> If anybody have done these, pl share details on your testing.
>
> @blueorangutan package
- I've tested upgrading from 4.16 and from 4.18, using KVM on ubuntu 20.04;
- I've tested env deploy in EL8 and EL7, using KVM;
- I've tested that logs were being logged and had the expected formats in mgmt, usage, system vms and agents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1634392114
<b>[SF] Trillian Build Failed (tid-7067)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1551021564
close-reopen to rekick Github Actions
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1669229379
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1672695819
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692311437
> > @JoaoJandre cloudstack-utils.jar should work without any other dependency. log4j should be included in the cloudstack-utils.jar
> > What Daan made, is a workaround, not a the final solution.
>
> @JoaoJandre could you please apply the changes below ?
>
> ```
> diff --git a/utils/pom.xml b/utils/pom.xml
> index 46897031d14..14b05c8706b 100755
> --- a/utils/pom.xml
> +++ b/utils/pom.xml
> @@ -269,6 +269,8 @@
> <include>commons-codec:commons-codec</include>
> <include>org.apache.commons:commons-lang3</include>
> <include>org.jasypt:jasypt</include>
> + <include>org.apache.logging.log4j:log4j-core</include>
> + <include>org.apache.logging.log4j:log4j-api</include>
> </includes>
> </artifactSet>
> </configuration>
> ```
>
> it looks good in my testing
>
> ```
> [INFO] --- maven-shade-plugin:3.0.0:shade (rebuild-war) @ cloud-utils ---
> [INFO] Excluding org.apache.cloudstack:cloud-framework-managed-context:jar:4.19.0.0-SNAPSHOT from the shaded jar.
> [INFO] Excluding org.apache.cloudstack:cloud-framework-ca:jar:4.19.0.0-SNAPSHOT from the shaded jar.
> [INFO] Excluding org.springframework:spring-context:jar:5.3.26 from the shaded jar.
> [INFO] Excluding org.springframework:spring-aop:jar:5.3.26 from the shaded jar.
> [INFO] Excluding org.springframework:spring-beans:jar:5.3.26 from the shaded jar.
> [INFO] Excluding org.springframework:spring-core:jar:5.3.26 from the shaded jar.
> [INFO] Excluding org.springframework:spring-jcl:jar:5.3.26 from the shaded jar.
> [INFO] Excluding org.springframework:spring-expression:jar:5.3.26 from the shaded jar.
> [INFO] Excluding org.aspectj:aspectjweaver:jar:1.8.13 from the shaded jar.
> [INFO] Including org.apache.logging.log4j:log4j-core:jar:2.19.0 in the shaded jar.
> [INFO] Including org.apache.logging.log4j:log4j-api:jar:2.19.0 in the shaded jar.
> ......
> ```
@weizhouapache
The tests will run, but if you read the comment I pointed out, you will find that the system VMs will stop logging. Please, do try it, log into the system VMs with this change you proposed, and see if there is any logging. If there is, I'll be happy to comply.
Moreover, ACS is working perfectly without this change. The only thing that broke is the CI, and only because the CI is "manually" calling the EncriptorCLI without passing the proper classpath. This was already discussed and solved with @DaanHoogland.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692337906
@JoaoJandre
Can you please merge latest main and fix build errors ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692389383
@weizhouapache sure, fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1693368489
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1701796495
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1727937789
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1748196003
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1744070690
<b>[SF] Trillian test result (tid-7796)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 71916 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t7796-vmware-70u3.zip
Smoke tests completed. 109 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_10_vpc_tier_kubernetes_cluster | `Failure` | 3714.08 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Error` | 3714.20 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 124.58 | test_kubernetes_clusters.py
test_list_volumes_metrics_history | `Error` | 3617.49 | test_metrics_api.py
test_01_deploy_vm_on_specific_host | `Error` | 18.73 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 3604.46 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 1.37 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.39 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.29 | test_vm_deployment_planner.py
test_09_expunge_vm | `Failure` | 426.66 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1734244152
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1499075939
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12028 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1588211887
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1625791745
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1625980554
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1558554551
Thanks for trying and testing against main @JoaoJandre I'm able to deploy a mbx env with 4.18 and main packages (tested with el8 kvm and el8 mgmt server) but not this PR yet with mbx. I wouldn't rule out why storage pools aren't working for your env, perhaps look at your NFS configuration (allow ports if there are strict firewall rules)?
Let me help build packages from this PR and upload them on http://download.cloudstack.org/testing/ so different folks can help test against the same builds. @DaanHoogland could you help investigate why BO is failing upon testing?
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1559964983
@JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1533365081
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1882985480
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1930049830
> @rohityadavcloud @DaanHoogland @weizhouapache @shwstppr @JoaoJandre
>
> What do you guys think about a little freeze between today and tomorrow, to re-run the CI and manual tests (just for sake) and finally merge this PR? This PR touches a lot of files and might conflict with the merge of almost any other PR, which might lead us to an endless cycle here (this PR is already 1 year old ๐ง).
1 year old is still young ๐
let's wait for the testing results. If all are ok, I am ok with merging it.
@JoaoJandre
Do you have a script or command to update the Java files to work with 2.x?
We will face a lot of conflicts or compilation issues when merge forward 4.18/4.19 to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1930051125
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1926903210
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1404675274
> > > SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
> > > [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [28 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [6 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [11993 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
> > > [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% D
uplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
> >
> >
> > auch, I checked the security issues and marked them safe. @JoaoJandre can you go through the vulnerabilities and bugs, please. I think we must ignore the code smells for this PR. We can sample them but this is going to be a manyear of work to clear them all, even the more serious ones.
>
> @DaanHoogland, as this PR touched a lot of lines, any "bugs" or "vulnerabilities" that already existed are now being reported by Sonarcloud. I fixed one of them that I deemed relevant to this PR; however, in order to avoid raising the complexity of this PR, I think it would be better to create another PR to fix the other bugs and vulnerabilities. What do you think?
> > > SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
> > > [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [28 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [6 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [11993 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
> > > [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% D
uplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
> >
> >
> > auch, I checked the security issues and marked them safe. @JoaoJandre can you go through the vulnerabilities and bugs, please. I think we must ignore the code smells for this PR. We can sample them but this is going to be a manyear of work to clear them all, even the more serious ones.
>
> @DaanHoogland, as this PR touched a lot of lines, any "bugs" or "vulnerabilities" that already existed are now being reported by Sonarcloud. I fixed one of them that I deemed relevant to this PR; however, in order to avoid raising the complexity of this PR, I think it would be better to create another PR to fix the other bugs and vulnerabilities. What do you think?
Where it comes to code smells i would agree, but I would rather assess all bugs and vulnerabilities maybe even before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1403971178
> > SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
> > [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [28 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [6 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [11993 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
> > [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Dup
lication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
>
> auch, I checked the security issues and marked them safe. @JoaoJandre can you go through the vulnerabilities and bugs, please. I think we must ignore the code smells for this PR. We can sample them but this is going to be a manyear of work to clear them all, even the more serious ones.
@DaanHoogland, as this PR touched a lot of lines, any "bugs" or "vulnerabilities" that already existed are now being reported by Sonarcloud. I fixed one of them that I deemed relevant to this PR; however, in order to avoid raising the complexity of this PR, I think it would be better to create another PR to fix the other bugs and vulnerabilities. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1415249420
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1427562964
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1484603115
<b>Trillian Build Failed (tid-6323)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1741437876
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1742440775
@blueorangutan test rocky8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1740853930
> @weizhouapache @DaanHoogland can we run another round of tests?
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1754356594
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1931574263
<b>[SF] Trillian test result (tid-9104)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42873 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t9104-kvm-centos7.zip
Smoke tests completed. 122 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1929395780
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1934038551
<b>[SF] Trillian test result (tid-9126)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46966 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t9126-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1924608969
> @DaanHoogland @weizhouapache could you check why BO is failing please?
it might be because I merged #8293 early today. @JoaoJandre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1567345640
@JoaoJandre `mbx` assumes you'll use packages with systemvmtemplates, which is by default as in all pkgs on http://download.cloudstack.org/ etc have them bundled in. If you're building custom packages with no systemvmtemplates then that's a specific case - I can add a note on mbx's README.
I'm using the latest mbx as from https://github.com/shapeblue/mbx there is no private fork/version that I'm using. I did a quick test against 4.19/main EL8 packages from latest main branch from today and they're deploying okay for me. I'm using mbx on a NUC9 i7 based mini-pc server with Ubuntu 22.04 + KVM. Btw, the mbx's smoketests.sh isn't fully optimized with test_data.py, so it doesn't pass all smoketests (yet) like BO/trillian does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1558760207
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1500336585
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1497577720
> @GutoVeronezi I was able to fix all the mentioned issues, except for the `UsageManagerImpl_EnhancerByCloudStack_6c3dfde5` problem. This happens because we use the `getClass()` method to instantiate the logger, and for enhanced classes, this is what is returned. As we do this enhancement manually, we most likely would need to change the process of enhancement and create a method to return the original class, but this is out of scope of this PR.
I see; thanks for the fixes and the reply, @JoaoJandre.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GaOrtiga commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GaOrtiga (via GitHub)" <gi...@apache.org>.
GaOrtiga commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1609581997
My tests were ran using this env:
Management and usage server host: Ubuntu 20.04.2 LTS kernel 5.4.0-150-generic
Hypervisor: KVM Ubuntu 20.04.2 LTS kernel 5.4.0-150-generic
I upgraded from 4.18.0.0 (from main) using the packages from this PR and executed the following procedures:
create, stop, start and destroy VM.
Create, delete network
Acquire public IP, create load balancer and port forwarding rules
After checking the management logs, usage logs, agent logs and the systemvm logs, I verified that everything was being logged as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1687686988
I have nothing with this PR @JoaoJandre as long as it doesn't break anything I'm fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1688028427
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1623386541
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1688599216
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1738086663
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1739804227
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1482666801
> @JoaoJandre I see the envs failing to setup with
>
> ```
> 10:09:34 stderr: Traceback (most recent call last):
> 10:09:34 File "/usr/bin/cloudstack-setup-databases", line 636, in <module>
> 10:09:34 o.run()
> 10:09:34 File "/usr/bin/cloudstack-setup-databases", line 625, in run
> 10:09:34 self.processEncryptionStuff()
> 10:09:34 File "/usr/bin/cloudstack-setup-databases", line 427, in processEncryptionStuff
> 10:09:34 encryptDBSecretKey()
> 10:09:34 File "/usr/bin/cloudstack-setup-databases", line 410, in encryptDBSecretKey
> 10:09:34 self.putDbProperty('db.cloud.encrypt.secret', formatEncryptResult(encrypt(self.dbsecretkey)))
> 10:09:34 File "/usr/bin/cloudstack-setup-databases", line 396, in encrypt
> 10:09:34 return str(runCmd(cmd)).strip('\r
> 10:09:34 ')
> 10:09:34 File "/usr/bin/cloudstack-setup-databases", line 51, in runCmd
> 10:09:34 raise Exception(stderr)
> 10:09:34 Exception: b'Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/logging/log4j/LogManager
> 10:09:34 \tat com.cloud.utils.crypt.CloudStackEncryptor.<init>(CloudStackEncryptor.java:33)
> 10:09:34 \tat com.cloud.utils.crypt.EncryptionCLI.main(EncryptionCLI.java:63)
> 10:09:34 Caused by: java.lang.ClassNotFoundException: org.apache.logging.log4j.LogManager
> 10:09:34 \tat java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
> 10:09:34 \tat java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
> 10:09:34 \tat java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
> 10:09:34 \t... 2 more
> ```
>
> I imagine this is due to some merge conflict?
I'll check and fix it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1484605838
<b>Trillian Build Failed (tid-6322)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1513618184
> > @DaanHoogland, can we do another round of tests on this one?
>
> yes of course. but I get a bit worried about the unfinished discussions on the subject. Also extensive multi platform testing by as many setups as possible , not just the test matrix, will be needed.
@DaanHoogland, I agree more evidence will help us on guaranteeing the platform's functionality; if someone else could test this patch to generate more evidence, it would be great.
Regarding the subjects @rohityadavcloud raised, IMHO @JoaoJandre's answers are coherent; however, if there are any points missing, let's discuss them. Let me know what is missing, and then we can coordinate on how to improve them to you guys.
> @GutoVeronezi @JoaoJandre I think we are far from done with this one. There are so many ways this can go wrong in so many envireonments. I hope you have the stamina to see it through.
We have been farther :smile:. The community has been discussing this topic for about 8 years now (since 2015); therefore, it is interesting to finally get it off the drawing and discussing, and that is what we are doing here. We have been putting months of effort towards this end. The goal is to finally upgrade ACS log library and to move on to use energy with more and better things in ACS. From my experience with Log4j2, I can say it will help us a lot while coding and troubleshooting.
@DaanHoogland do you have any clues on why the Trillian builds are failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692321393
@JoaoJandre
Thanks for the info
Inwill
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1693113063
<b>[SF] Trillian test result (tid-7547)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48855 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t7547-kvm-centos7.zip
Smoke tests completed. 106 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:setup | `Error` | 0.00 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesSupportedVersion>:setup | `Error` | 0.00 | test_kubernetes_supported_versions.py
test_list_vms_metrics_admin | `Error` | 3609.16 | test_metrics_api.py
test_list_vms_metrics_history | `Error` | 7.44 | test_metrics_api.py
test_list_volumes_metrics_history | `Error` | 4.33 | test_metrics_api.py
ContextSuite context=TestVmAutoScaling>:setup | `Error` | 0.00 | test_vm_autoscaling.py
test_05_vmschedule_test_e2e | `Failure` | 269.86 | test_vm_schedule.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.36 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.39 | test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Failure` | 11.35 | test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Failure` | 20.42 | test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Failure` | 32.46 | test_host_maintenance.py
test_disable_oobm_ha_state_ineligible | `Error` | 1512.77 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1608192984
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by github-actions.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1403568124
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by github-actions.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1408278619
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1403901773
> shall we keep count @JoaoJandre ? first conflict. (/me joking, let's not!) I suggest we merge this as soon after 4.18 is out as we can.
I think it's best we don't keep :D. Sounds great, I'll try to be as fast as possible in completing this PR and addressing any reviews and conflicts.
> > SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
> > [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [28 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [6 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [11993 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
> > [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Dup
lication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
>
> auch, I checked the security issues and marked them safe. @JoaoJandre can you go through the vulnerabilities and bugs, please. I think we must ignore the code smells for this PR. We can sample them but this is going to be a manyear of work to clear them all, even the more serious ones.
Sure, I'll go through them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by sonarcloud.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1404094330
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [27 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [7 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [11993 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1409919828
> XML
@JoaoJandre , are you saying that
- the syslog appenders can not be configured using spring configuration? If so that is ok because we would like to give the operator the possibility to configure it and spring is comile time
- they cannot be configured using log4j xml? this would be a (grave?) lack of feature. but not really a serious bug. I'd say create a backlog issue and solve later.
In any way, I think it is not impeding your work here, or is it? The current work is to port existing log functionality to log4j2 and not to exploit log4j2 fully. If file -, snmp - and console appenders work we should be mostly done. (hope I am not overlooking something)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1477928472
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1479680872
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1478078137
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1924423390
@DaanHoogland @weizhouapache could you check why BO is failing please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1932344697
> Seems that packaging got stuck on this one; running again:
might have been just the github api @GutoVeronezi (but rebuilding works;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1933088681
@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1929396617
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1930000959
@rohityadavcloud @DaanHoogland @weizhouapache @shwstppr @JoaoJandre
What do you guys think about a little freeze between today and tomorrow, to re-run the CI and manual tests (just for sake) and finally merge this PR? This PR touches a lot of files and might conflict with the merge of almost any other PR, which might lead us to an endless cycle here (this PR is already 1 year old ๐ง).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1930053862
@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1727204137
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1738592273
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1589231155
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1639605429
the test_vpc_vpn errors are due tolack of rebasing on master in the test suite. The others are known issues that should be addressed in other PRs here.
restarting the kvm test in the backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1690541400
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1842668982
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1570738769
@rohityadavcloud @DaanHoogland I tried to use the packages that daan linked in https://github.com/apache/cloudstack/pull/7131#issuecomment-1561159460 to test with EL8. **They have the exact same problem I reported earlier**, they do not have the system templates, I had to manually ssh into the VM, download the template etc... That explains the problem you were having @rohityadavcloud. I'll try to build myself the packages with system templates and make some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1568940404
> @JoaoJandre `mbx` assumes you'll use packages with systemvmtemplates, which is by default as in all pkgs on http://download.cloudstack.org/ etc have them bundled in. If you're building custom packages with no systemvmtemplates then that's a specific case - I can add a note on mbx's README.
>
> I'm using the latest mbx as from https://github.com/shapeblue/mbx there is no private fork/version that I'm using. I did a quick test against 4.19/main EL8 packages from latest main branch from today and they're deploying okay for me. I'm using mbx on a NUC9 i7 based mini-pc server with Ubuntu 22.04 + KVM. Btw, the mbx's smoketests.sh isn't fully optimized with test_data.py, so it doesn't pass all smoketests (yet) like BO/trillian does.
I have made all my tests using el7, I'll try to reproduce them with el8, but it would also be good to see what BO outputs after the fix I mentioned earlier to daan is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1608195392
@JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1580898953
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1697756005
I looked through the errors on the tests, and none of the errors seem related to this PR:
test_vm_lifecycle_unmanage_import.py:
```
marvin.cloudstackException.CloudstackAPIException: Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Unable to deploy VM as UserData is provided while deploying the VM, but there is no support for UserData service in the default network Test L2 Network/1e22f7d0-a41b-4c89-b50f-8b688f8b52e3.\n']
```
test_volumes.py:
```
AssertionError: 'FAILED' != 'SUCCESS'\n- FAILED\n+ SUCCESS\n : b'Check if promised disk size actually available'\n"
```
test_host_maintenance.py:
```
deployvirtualmachine failed, due to: errorCode: 431, errorText:Unable to deploy VM as UserData is provided while deploying the VM, but there is no support for UserData service in the default network Test L2 Network/7d554e3b-a2d6-4bc5-ab72-e82374555059.\n']
```
test_metrics_api.py:
```
errorcode : 530, errortext : 'Unable to start a VM [9db40464-835e-4e9a-8494-e95b98f9b3b6] due to [Unable to create a deployment for VM instance {"id":255,"instanceName":"i-2-255-VM","type":"User","uuid":"9db40464-835e-4e9a-8494-e95b98f9b3b6"
```
test_vm_autoscaling.py:
```
marvin.cloudstackException.CloudstackAPIException: Execute cmd: autoscalevmprofile failed, due to: errorCode: 530, errorText:Internal error executing command, please contact your system administrator\n'
```
test_vm_schedule.py:
```
'AssertionError: True is not false : VM did not switch states after schedule time\n'
```
test_host_maintenance.py:
```
Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Unable to deploy VM as UserData is provided while deploying the VM, but there is no support for UserData service in the default network Test L2 Network/00c6366e-8af5-47c8-82ee-73ead3e28c1c.\n']
```
test_hostha_kvm.py:
```
Exception: Template download failed exception
```
About #7912, it might fix the CI problem (whether it's the best approach or not, we can discuss there). However, I don't think that this PR should depend on #7912, everything is already working and delaying it is very costly, I have already spend hours and hours fixing conflicts. This PR has been ready for a long time, it has passed all the projects requirements to be accepted. If the CI implemented by Trillian is calling inner packages of the application directly, it should adapt to changes in dependencies, not the other way around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1672763732
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1705692149
@blueorangutan LLtest matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1509003493
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1499568442
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1497653379
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1503920419
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12021 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1505326994
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12027 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1522965174
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by sonarcloud.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1402619421
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [28 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [6 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [11993 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1402477798
@JoaoJandre , I didnยดt yet review 2000 files, but on first sight it looks good. I hope you have scripts to regenerate the changes, because this PR will be a conflict magnet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1410911191
> * the syslog appenders can not be configured using spring configuration? If so that is ok because we would like to give the operator the possibility to configure it and spring is comile time
We might be able to configure them via spring as you suggested; I am not sure how though.
> In any way, I think it is not impeding your work here, or is it? The current work is to port existing log functionality to log4j2 and not to exploit log4j2 fully. If file -, snmp - and console appenders work we should be mostly done. (hope I am not overlooking something)
I will mark this as PR ready, as all the log functionality should have been ported already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1414211307
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [24 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12045 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by sonarcloud.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1405650959
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [27 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [7 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [11994 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.2% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1412667352
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [24 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12032 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1479695764
<b>Trillian Build Failed (tid-6307)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1482832082
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12014 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1487134649
I see reload4j actively maintained and developed with commercial backers such as Spotify and Exoscale - https://reload4j.qos.ch - @JoaoJandre what benefits do we get from moving to log4j 2.x? Also are there any risks? (it would be challenging to review and validate all the 19-22k changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1560014918
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1560567193
<b>Trillian Build Failed (tid-6574)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1560946152
Closing/reopening PR to rekick github actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1932336232
@GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi merged PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1814502442
> > > > moving this to 4.20
> > >
> > >
> > > @DaanHoogland aren't we going to merge this ?
> >
> >
> > I thought we agreed to move it to 4.20 (or 4.19.1 which makes more sense to me) See [#7131 (comment)](https://github.com/apache/cloudstack/pull/7131#issuecomment-1765202106)
> > I am violently neutral on this PR.
>
> Sorry I missed the comment. If the authors agree, it looks good to me.
I believe moving to 4.20 is best course of action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1672088545
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1544542182
@JoaoJandre a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1543926021
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1544441353
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1509004124
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1511654183
<b>Trillian Build Failed (tid-6418)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1552730514
@JoaoJandre are you able to test CloudStack env and zone deployment using (rpm) packages against mbx https://github.com/shapeblue/mbx? (I and some of my colleagues are unavailable this week, we can assist to debug why the smoketests are failing in the next week onwards)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud closed pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
URL: https://github.com/apache/cloudstack/pull/7131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1754445108
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692063427
<b>[SF] Trillian Build Failed (tid-7542)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692260341
>
> @JoaoJandre cloudstack-utils.jar should work without any other dependency. log4j should be included in the cloudstack-utils.jar
>
> What Daan made, is a workaround, not a the final solution.
@JoaoJandre
could you please apply the changes below ?
```
diff --git a/utils/pom.xml b/utils/pom.xml
index 46897031d14..14b05c8706b 100755
--- a/utils/pom.xml
+++ b/utils/pom.xml
@@ -269,6 +269,8 @@
<include>commons-codec:commons-codec</include>
<include>org.apache.commons:commons-lang3</include>
<include>org.jasypt:jasypt</include>
+ <include>org.apache.logging.log4j:log4j-core</include>
+ <include>org.apache.logging.log4j:log4j-api</include>
</includes>
</artifactSet>
</configuration>
```
it looks good in my testing
```
[INFO] --- maven-shade-plugin:3.0.0:shade (rebuild-war) @ cloud-utils ---
[INFO] Excluding org.apache.cloudstack:cloud-framework-managed-context:jar:4.19.0.0-SNAPSHOT from the shaded jar.
[INFO] Excluding org.apache.cloudstack:cloud-framework-ca:jar:4.19.0.0-SNAPSHOT from the shaded jar.
[INFO] Excluding org.springframework:spring-context:jar:5.3.26 from the shaded jar.
[INFO] Excluding org.springframework:spring-aop:jar:5.3.26 from the shaded jar.
[INFO] Excluding org.springframework:spring-beans:jar:5.3.26 from the shaded jar.
[INFO] Excluding org.springframework:spring-core:jar:5.3.26 from the shaded jar.
[INFO] Excluding org.springframework:spring-jcl:jar:5.3.26 from the shaded jar.
[INFO] Excluding org.springframework:spring-expression:jar:5.3.26 from the shaded jar.
[INFO] Excluding org.aspectj:aspectjweaver:jar:1.8.13 from the shaded jar.
[INFO] Including org.apache.logging.log4j:log4j-core:jar:2.19.0 in the shaded jar.
[INFO] Including org.apache.logging.log4j:log4j-api:jar:2.19.0 in the shaded jar.
......
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1734246504
@JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1734326090
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1736831081
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1697973681
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1739881558
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1748647938
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1588152641
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1584615012
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1495880942
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1537921507
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1599217640
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1560074305
> Thanks for trying and testing against main @JoaoJandre I'm able to deploy a mbx env with 4.18 and main packages (tested with el8 kvm and el8 mgmt server) but not this PR yet with mbx. I wouldn't rule out why storage pools aren't working for your env, perhaps look at your NFS configuration (allow ports if there are strict firewall rules)?
>
> Let me help build packages from this PR and upload them on http://download.cloudstack.org/testing/ so different folks can help test against the same builds. @DaanHoogland could you help investigate why BO is failing upon testing?
>
> @blueorangutan package
I did some testing and the NFS configuration is fine, I have found that the problem is that the system template is not being correctly seeded. I'll look further into it later and report about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1629659832
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692054076
<b>[SF] Trillian Build Failed (tid-7541)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1706534680
> > As the CI tests passed, manual tests were done and we already have the necessary approvals, I propose merging this PR by the end of the day. Before that, I will notify dev and user mailing list about the merging, the conflicts some PRs may suffer, and instructions on how to solve them.
> > cc: @DaanHoogland @JoaoJandre @rohityadavcloud @weizhouapache
>
> @GutoVeronezi considering this is a huge change, please hold on there were lots of changes since last testing by @vladimirpetrov
@weizhouapache if you take a look at the commit tree, you will see that the recent changes are mostly regarding conflict solving; we can ask the community to do another round of manual tests in the next days, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1706271428
<b>[LL]Trillian test result (tid-6735)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44333 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t6735-vmware-67u3.zip
Smoke tests completed. 113 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1564280597
Hey @rohityadavcloud,
I managed to find the problem with mbx, during the deployment of the zone, ACS would try to get the system template from a directory and put in its right place, but the template was not there. So what I had to do was do the mbx deploy, then log into the mgmt VM, download the template and place it correctly, and then do the mbx launch. There wasn't any mention of this in mbx's readme (unless I missed it) and honestly I expected mbx to do that for me (maybe it was supposed to do it but there's a bug somewhere?).
I was able to run the smoke tests using mbx with my changes, and had a few failures (but none of them related to log4j2):
These failed because of timeouts:
test_attach_and_distribute_multiple_volumes | `Error` | 32.642 | test_attach_multiple_volumes.py
test_attach_multiple_volumes | `Failure` | 18.087 | test_attach_multiple_volumes.py
test_attach_multiple_volumes | `Error` | 18.090 | test_attach_multiple_volumes.py
All of these failed because the python module OpenSSL was not installed in the VM (after installing it with pip the tests passed):
test_certauthority_root.py
test_vm_life_cycle.py
test_vm_snapshots.py
test_volumes.py
test_vpc_ipv6.py
test_vpc_redundant.py
test_vpc_router_nics.py
test_vpc_vpn.py
test_host_maintenance.py
---
test_deploy_vm_extra_config_data.py failed because the module lxml was not installed in the VM (after installing it, the test passed)
test_deploy_vm_iso_uefi.py
Fails with exception, Says that host is not kvm because 'kvm' != 'KVM', when changed to check if string is 'KVM' throws another exception:
```
CSLog: CRITICAL: EXCEPTION: None: ['Traceback (most recent call last):\n', ' File "/usr/local/lib/python3.6/site-packages/nose/suite.py", line 210, in run\n self.setUp()\n', ' File "/usr/local/lib/python3.6/site-packages/nose/suite.py", line 293, in setUp\n self.setupContext(ancestor)\n', ' File "/usr/local/lib/python3.6/site-packages/nose/suite.py", line 316, in setupContext\n try_run(context, names)\n', ' File "/usr/local/lib/python3.6/site-packages/nose/util.py", line 471, in try_run\n return func()\n', ' File "/marvin/tests/smoke/test_deploy_vm_iso_uefi.py", line 60, in setUpClass\n raise unittest.SkipTest("At least one host should support UEFI")\n', 'unittest.case.SkipTest: At least one host should support UEFI\n']
--------------------- >> end captured logging << ---------------------]]></skipped><system-out><![CDATA[=== TestName: None | Status : EXCEPTION ===
```
Unrelated to log4j.
test_gateway_on_shared_networks.py
Error:
```
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 376, in marvinRequest
raise self.__lastError
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 310, in __parseAndGetResponse
response_cls)
File "/usr/local/lib/python3.6/site-packages/marvin/jsonHelper.py", line 155, in getResultObj
raise cloudstackException.CloudstackAPIException(respname, errMsg)
marvin.cloudstackException.CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:The VLAN tag to use for new guest network, 111 is already being used for dynamic vlan allocation for the guest network in zone DC
```
Caused by physical network dynamic VLAN allocation range being 100 to 199. Unrelated to log4j2.
test_07_list_default_iso | `Failure` | 0.028 | test_iso.py
Error:
```
File "/usr/lib64/python3.6/unittest/case.py", line 622, in run
testMethod()
File "/marvin/tests/smoke/test_iso.py", line 615, in test_07_list_default_iso
self.get_iso_details("vmware-tools.iso")
File "/marvin/tests/smoke/test_iso.py", line 267, in get_iso_details
"Check if ISO exists in ListIsos")
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackTestCase.py", line 94, in assertEqual
super(cloudstackTestCase,self).assertEqual(first,second,msg)
File "/usr/lib64/python3.6/unittest/case.py", line 846, in assertEqual
assertion_func(first, second, msg=msg)
File "/usr/lib64/python3.6/unittest/case.py", line 839, in _baseAssertEqual
raise self.failureException(msg)
1 != 0 : b'Check if ISO exists in ListIsos'
```
Fails because env does not have vmware-tools.iso. Unrelated to log4j2.
test_01_isolated_persistent_network | `Failure` | 73.776 | test_persistent_network.py
Error:
```
CRITICAL: FAILED: test_01_isolated_persistent_network: ['Traceback (most recent call last):\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 60, in testPartExecutor\n yield\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 622, in run\n testMethod()\n', ' File "/marvin/tests/smoke/test_persistent_network.py", line 317, in test_01_isolated_persistent_network\n "Failed to find bridge on the breth1$-{networkVlan}")\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackTestCase.py", line 94, in assertEqual\n super(cloudstackTestCase,self).assertEqual(first,second,msg)\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 846, in assertEqual\n assertion_func(first, second, msg=msg)\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 839, in _baseAssertEqual\n raise self.failureException(msg)\n', "AssertionError: 1 != 0 : b'Failed to find bridge on the breth1$-{networkVlan}'\n"] `
```
Unrelated to Log4j2.
test_02_L2_persistent_network | `Failure` | 3.200 | test_persistent_network.py
Error:
```
CRITICAL: FAILED: test_02_L2_persistent_network: ['Traceback (most recent call last):\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 60, in testPartExecutor\n yield\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 622, in run\n testMethod()\n', ' File "/marvin/tests/smoke/test_persistent_network.py", line 349, in test_02_L2_persistent_network\n self.validate_persistent_network_resources_created_on_host(network_vlan)\n', ' File "/marvin/tests/smoke/test_persistent_network.py", line 399, in validate_persistent_network_resources_created_on_host\n "Failed to find bridge on the breth1-" + str(network_vlan))\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackTestCase.py", line 94, in assertEqual\n super(cloudstackTestCase,self).assertEqual(first,second,msg)\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 846, in assertEqual\n assertion_func(first, second, msg=msg)\n', ' File "/usr/lib64/python3.6/unittest/case.py", li
ne 839, in _baseAssertEqual\n raise self.failureException(msg)\n', "AssertionError: 1 != 0 : b'Failed to find bridge on the breth1-90'\n"]
```
Unrelated to Log4j2.
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Failure` | 44.881 | test_persistent_network.py
Error:
```
CRITICAL: FAILED: test_03_deploy_and_destroy_VM_and_verify_network_resources_persist: ['Traceback (most recent call last):\n', ' File "/marvin/tests/smoke/test_persistent_network.py", line 385, in test_03_deploy_and_destroy_VM_and_verify_network_resources_persist\n self.validate_persistent_network_resources_created_on_host(network_vlan)\n', ' File "/marvin/tests/smoke/test_persistent_network.py", line 399, in validate_persistent_network_resources_created_on_host\n "Failed to find bridge on the breth1-" + str(network_vlan))\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackTestCase.py", line 94, in assertEqual\n super(cloudstackTestCase,self).assertEqual(first,second,msg)\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 846, in assertEqual\n assertion_func(first, second, msg=msg)\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 839, in _baseAssertEqual\n raise self.failureException(msg)\n', "AssertionError: 1 != 0 : b'Failed to
find bridge on the breth1-99'\n", '\nDuring handling of the above exception, another exception occurred:\n\n', 'Traceback (most recent call last):\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 60, in testPartExecutor\n yield\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 622, in run\n testMethod()\n', ' File "/marvin/tests/smoke/test_persistent_network.py", line 387, in test_03_deploy_and_destroy_VM_and_verify_network_resources_persist\n self.fail("Exception occurred: %s" % e)\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 687, in fail\n raise self.failureException(msg)\n', "AssertionError: Exception occurred: 1 != 0 : b'Failed to find bridge on the breth1-99'\n"]
```
Unrelated to Log4j2.
test_01_add_primary_storage_disabled_host | `Error` | 0.824 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.471 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 1.903 | test_primary_storage.py
Error:
```
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 3805, in createStoragePool
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 381, in marvinRequest
raise e
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 376, in marvinRequest
raise self.__lastError
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 310, in __parseAndGetResponse
response_cls)
File "/usr/local/lib/python3.6/site-packages/marvin/jsonHelper.py", line 155, in getResultObj
raise cloudstackException.CloudstackAPIException(respname, errMsg)
Execute cmd: createstoragepool failed, due to: errorCode: 530, errorText:Failed to add data store: Failed to access storage pool
```
Same error for the three above. Unrelated to Log4j2.
test_02_list_snapshots_with_removed_data_store | `Error` | 130.389 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 130.399 | test_snapshots.py
```
test_02_list_snapshots_with_removed_data_store (tests.smoke.test_snapshots.TestSnapshotRootDisk): ERROR: Exception:['Traceback (most recent call last):\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 310, in __parseAndGetResponse\n response_cls)\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/jsonHelper.py", line 155, in getResultObj\n raise cloudstackException.CloudstackAPIException(respname, errMsg)\n', 'marvin.cloudstackException.CloudstackAPIException: Execute cmd: createstoragepool failed, due to: errorCode: 530, errorText:Failed to add data store: Failed to access storage pool\n']
```
Same error for the two above. Unrelated to log4j2.
runTest | `Error` | 0.002 | test_storage_policy.py
Error:
```
File "/usr/lib64/python3.6/unittest/case.py", line 622, in run
testMethod()
File "/usr/local/lib/python3.6/site-packages/nose/failure.py", line 39, in runTest
raise self.exc_val.with_traceback(self.tb)
File "/usr/local/lib/python3.6/site-packages/nose/loader.py", line 418, in loadTestsFromName
addr.filename, addr.module)
File "/usr/local/lib/python3.6/site-packages/nose/importer.py", line 47, in importFromPath
return self.importFromDir(dir_path, fqname)
File "/usr/local/lib/python3.6/site-packages/nose/importer.py", line 94, in importFromDir
mod = load_module(part_fqname, fh, filename, desc)
File "/usr/lib64/python3.6/imp.py", line 235, in load_module
return load_source(name, filename, file)
File "/usr/lib64/python3.6/imp.py", line 172, in load_source
module = _load(spec)
File "<frozen importlib._bootstrap>", line 684, in _load
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/marvin/tests/smoke/test_storage_policy.py", line 34, in <module>
from marvin.cloudstackAPI import (importVsphereStoragePolicies,
cannot import name 'importVsphereStoragePolicies'
```
Unrelated to log4j2.
These failed because another test disabled a host previously, after the host was enabled the tests passed.
test_01_deploy_vm_on_specific_host | `Error` | 0.147 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 0.121 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 0.174 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 0.189 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 0.142 | test_vm_deployment_planner.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1502167777
@GutoVeronezi done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1416260257
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [24 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12044 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1478097294
<b>Trillian Build Failed (tid-6299)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1478098089
<b>Trillian Build Failed (tid-6301)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1478077740
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [24 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12038 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1483243520
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1488671229
@JoaoJandre thanks for the reply.
We use dependencies from other opensource communities and organisations all the time - any organisation behind a dependency shouldn't be the only criteria for choosing it. [Reload4j](https://reload4j.qos.ch/) is backed by supporters and used by at least half-a-dozen other Apache projects and appears to be maintained and released (I see a new release last week, that reminds me we need to upgrade the reload4j dependency for 4.18.1.0 milestone).
Thinking about our community and users, if we're undertaking such a big task - I would have explored an agnostic approach like a logging framework where the underlying library is easily swappable (sl4j comes to my mind, or even our own logging manager).
I appreciate all the hard work you've put in, however, I wasn't aware of this until Daan and Wei discussed this PR on the dev@ ML. I don't have any objections if the community wants to go this route but I suggest we consider the following concerns and suggestions:
- We need to validate packaging and smoketests across all hypervisor (and permutations on zone types, storage etc), was there any done? Does changing logging library has side-effects for existing codebase?
- I think we would also need to do upgrade tests for all supported hypervisors. Have we done any testing on this, could you share all such details of testing you may have done?
- I see some 120+ PRs, would merging this cause conflicts on them? Is there a way to minimise conflicts and side-effects on rest of the community PRs?
- Do we need an advisory for users, on how this would affect their current logging config, affect their plugins and any other integrations? (a lot of plugins aren't in the upstream repo but managed/shipped by users in the community)
- If we're considering this, should we also look at upgrading related dependencies such as gson?
- Speculating here - if only the parent classes has logger, has anybody tested if logging by a child-class prints the right class name in the logs (for example, [c.c.c.ClusterManagerImpl] in the log file)?
Could you also discuss your initiative on the dev@ and users@ mailing lists, it's possible my list above isn't exhaustive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1403716338
shall we keep count @JoaoJandre ? first conflict. (/me joking, let's not!)
I suggest we merge this as soon after 4.18 is out as we can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1561159460
> Let me help build packages from this PR and upload them on http://download.cloudstack.org/testing/ so different folks can help test against the same builds.
see https://download.cloudstack.org/testing/7131/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#discussion_r1204036134
##########
utils/pom.xml:
##########
@@ -259,7 +258,6 @@
<createDependencyReducedPom>false</createDependencyReducedPom>
<artifactSet>
<includes>
- <include>ch.qos.reload4j</include>
Review Comment:
@JoaoJandre , I think we need an implementation of log4j2 here to be able to use the command line tools (see https://github.com/apache/cloudstack/pull/7131#issuecomment-1560970916 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1560970916
@JoaoJandre I see the following in our test env builds:
```
09:08:11 cmd: java -classpath /usr/share/cloudstack-common/lib/cloudstack-utils.jar com.cloud.utils.crypt.EncryptionCLI -p password -i R6QPwRUz09TVXBjXNwZk7grTjcPtsFRphH6xhN1oPvnc12YUk296t4KHytg8zRLczDA0X5NsLVi4d8rfMMx3yg
09:08:11
09:08:11 start: 2023-05-24 07:08:10.931599
09:08:11
09:08:11 end: 2023-05-24 07:08:11.014625
09:08:11
09:08:11 delta: 0:00:00.083026
09:08:11
09:08:11 stderr: Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/logging/log4j/LogManager
09:08:11 at com.cloud.utils.crypt.CloudStackEncryptor.<init>(CloudStackEncryptor.java:33)
09:08:11 at com.cloud.utils.crypt.EncryptionCLI.main(EncryptionCLI.java:63)
09:08:11 Caused by: java.lang.ClassNotFoundException: org.apache.logging.log4j.LogManager
09:08:11 at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
09:08:11 at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
09:08:11 at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
09:08:11 ... 2 more
```
I'm doing a code inspection to see if that is an ommision in code or somewhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1551099785
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1551185973
<b>Trillian Build Failed (tid-6510)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1570110284
<b>[SF] Trillian Build Failed (tid-6630)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1571158079
<b>[SF] Trillian test result (tid-6631)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43071 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t6631-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1481418401
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1484590446
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1492109084
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1603264103
@JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1599132366
@JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1584856792
@SadiJr a [LL] Jenkins job has been kicked to build packages. It will be bundled with
@rohityadavcloud my tests are executed in the following env:
* Management and usage server host distros: Ubuntu 20.04.2 LT, kernel 5.4.0-137-generic
* Hypervisors:
- KVM: Ubuntu 20.04.2 LTS, kernel 5.4.0-149-generic;
- VMware:
- Hosts ESXi: 6.5.0 Update 3 (Build 14320405) <image here>;
- vCenter: vSphere Client version 6.5.0.41000 <image here>
* Tested primary storages: Tested primary storages: local storages and shared storage via NFS at cluster level in both KVM and VMware.
* Veeam: Build 11.0.1.1261 P20211211 Enterprise Plus Edition <image here>
* Versions tested:
- 4.16.0.0 upgrading to 4.18.0.0, using this PR -> working fine
- 4.18.0.0 (from main) and then installing the packages from this PR -> working fine
* Performed operations:
- Basic VM operations:
- create, stop, start, destroy, migrate, make snapshot and backup (VMWare only), all resulting in sucess, plus I made this same tests in the local primary storage and in the shared primary local storage;
* Basic network operations:
- creation, deletion, applying firewall rules, all working fine.
* Basic backup operations (VMware only):
- Create backups (manual or scheduled), restore the entire VM or only one volume, all working fine
When doing all these operations, I checked the logs, and it as all ok too.
@rohityadavcloud please let me know if there is something missing. The only point I cannot share with you is the license keys from VMware and Veeam :) SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1609088350
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1572365314
@rohityadavcloud I managed to package this PR in EL8 with systemvm templates. I tested the packages against mbx and they worked as expected, without any problems with system VMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1405535256
I updated the SnpmTrapAppender to work with log4j2 and have already tested if it gets created, and if its append method is called; however I did not test the SNMP functionality as it was not changed.
I removed the TestAppender, as it was only being used in a single test in a single class, and have rewritten the test.
About the AlertSyslogAppender, I have spent some time analyzing it, and it just does not seem to work at all. It will only append if _syslogAppenders is not empty nor null, but as far as I know this attribute cannot be configured via XML, and it is not being set anywhere else in the code, aside from a test class. @DaanHoogland, do you know how to configure and use this appender? If indeed it has never worked properly, could we remove it entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by sonarcloud.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1409238888
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [24 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [11993 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by github-actions.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1410017202
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1625780200
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1636382072
<b>[SF] Trillian test result (tid-7074)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 41887 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t7074-vmware-67u3.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1634396713
<b>[SF] Trillian Build Failed (tid-7066)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1635370850
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1635386314
<b>[SF] Trillian Build Failed (tid-7069)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692228686
> > @JoaoJandre see the errors below
> > ```
> > 18:44:16 stderr: Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/logging/log4j/LogManager
> > 18:44:16 at com.cloud.utils.crypt.CloudStackEncryptor.<init>(CloudStackEncryptor.java:33)
> > 18:44:16 at com.cloud.utils.crypt.EncryptionCLI.main(EncryptionCLI.java:63)
> > 18:44:16 Caused by: java.lang.ClassNotFoundException: org.apache.logging.log4j.LogManager
> > 18:44:16 at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
> > 18:44:16 at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
> > 18:44:16 at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
> > 18:44:16 ... 2 more
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > I think you need to replace `ch.qos.reload4j` with `org.apache.logging.log4j` in the list below
> > https://github.com/apache/cloudstack/blob/3b05797344c15a9fbd6bee4ecd38281b677f24a2/utils/pom.xml#L266-L274
>
> @weizhouapache Thank you for sharing, this situation has already been discussed, see [#7131 (comment)](https://github.com/apache/cloudstack/pull/7131#issuecomment-1564282630). The problem is with Trillian calling the EncriptionCLI and not passing log4j2 on the classpath. This is the reason why @DaanHoogland made a special branch on Trillian to run tests on this PR.
@JoaoJandre
cloudstack-utils.jar should work without any other dependency.
log4j should be included in the cloudstack-utils.jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692333614
@JoaoJandre
Kicked jobs manually with Daan's branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692145470
@JoaoJandre
see the errors below
```
18:44:16 stderr: Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/logging/log4j/LogManager
18:44:16 at com.cloud.utils.crypt.CloudStackEncryptor.<init>(CloudStackEncryptor.java:33)
18:44:16 at com.cloud.utils.crypt.EncryptionCLI.main(EncryptionCLI.java:63)
18:44:16 Caused by: java.lang.ClassNotFoundException: org.apache.logging.log4j.LogManager
18:44:16 at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
18:44:16 at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
18:44:16 at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
18:44:16 ... 2 more
```
I think you need to replace `ch.qos.reload4j` with `org.apache.logging.log4j` in the list below
https://github.com/apache/cloudstack/blob/3b05797344c15a9fbd6bee4ecd38281b677f24a2/utils/pom.xml#L266-L274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1580771823
@rohityadavcloud a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1594644693
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1621826910
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1764744808
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "SadiJr (via GitHub)" <gi...@apache.org>.
SadiJr commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1725536815
LGTM, tested in the following environment:
- Ubuntu Server 20.04.2 LTS, kernel 5.4.0-162-generic
- KVM hypervisor
Doing the following operations:
- Creation/deletion of new VMs, including VRs, SSVM and CPVM;
- Creation/deletion of networks, isolated networks and VPCs included;
- Creation of volume snapshot, restore of this snapshot and creation of a template using the snapshot;
- Moving user VMs between hosts and pools;
- Creation/deletion of new accounts/domains/users;
All working fine, tailing the agents and management logs, I haven't found any error or anomaly.
[snippets.zip](https://github.com/apache/cloudstack/files/12660762/snippets.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1723235288
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1726399498
@JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1724958419
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1731309352
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1926524797
@JoaoJandre can you address the conflicts? If we want this, let's try to get into main in the early cycle on 4.20.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1738007056
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1741658556
<b>[SF] Trillian test result (tid-7777)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52588 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t7777-xenserver-71.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3613.00 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3612.66 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Failure` | 50.69 | test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle | `Error` | 1.22 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 72.68 | test_kubernetes_clusters.py
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 308.06 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 1613.89 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1706482997
As the CI tests passed, manual tests were done and we already have the necessary approvals, I propose merging this PR by the end of the day. Before that, I will notify dev and user mailing list about the merging, the conflicts some PRs may suffer, and instructions on how to solve them.
cc: @DaanHoogland @JoaoJandre @rohityadavcloud @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1706506727
> As the CI tests passed, manual tests were done and we already have the necessary approvals, I propose merging this PR by the end of the day. Before that, I will notify dev and user mailing list about the merging, the conflicts some PRs may suffer, and instructions on how to solve them.
>
> cc: @DaanHoogland @JoaoJandre @rohityadavcloud @weizhouapache
@GutoVeronezi
considering this is a huge change, please hold on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1812845318
> > > moving this to 4.20
> >
> > @DaanHoogland aren't we going to merge this ?
>
> I thought we agreed to move it to 4.20 (or 4.19.1 which makes more sense to me) See https://github.com/apache/cloudstack/pull/7131#issuecomment-1765202106
>
> I am violently neutral on this PR.
Sorry I missed the comment.
If the authors agree, it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1930033560
Packaging result [SF]: โ๏ธ el7 โ๏ธ el8 โ๏ธ el9 โ๏ธ debian โ๏ธ suse15. SL-JID 8550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1931211928
<b>[SF] Trillian test result (tid-9102)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41774 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t9102-xenserver-71.zip
Smoke tests completed. 122 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1933868160
<b>[SF] Trillian test result (tid-9124)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42129 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t9124-xenserver-71.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 308.53 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1509015628
<b>Trillian Build Failed (tid-6409)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1589136544
@JoaoJandre a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1617373803
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1619826454
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by codecov.
codecov[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1402613375
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7131](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0973f7b) into [main](https://codecov.io/gh/apache/cloudstack/commit/10c77c88c8a929238e755f24682dd0c0e2aea28c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (10c77c8) will **decrease** coverage by `0.24%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #7131 +/- ##
============================================
- Coverage 11.77% 11.53% -0.24%
+ Complexity 7662 7209 -453
============================================
Files 2505 2502 -3
Lines 246172 245065 -1107
Branches 38388 38319 -69
============================================
- Hits 28985 28271 -714
+ Misses 213414 213064 -350
+ Partials 3773 3730 -43
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage ฮ | |
|---|---|---|
| [...org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zbm1wLWFsZXJ0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9hbGVydC9zbm1wL1NubXBUcmFwSW5mby5qYXZh) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [...oudstack/ca/provider/RootCACustomTrustManager.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9jYS9yb290LWNhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2NhL3Byb3ZpZGVyL1Jvb3RDQUN1c3RvbVRydXN0TWFuYWdlci5qYXZh) | `60.52% <0.00%> (-27.64%)` | :arrow_down: |
| [...a/org/apache/cloudstack/alert/snmp/SnmpHelper.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zbm1wLWFsZXJ0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9hbGVydC9zbm1wL1NubXBIZWxwZXIuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...esource/wrapper/LibvirtCheckSshCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0Q2hlY2tTc2hDb21tYW5kV3JhcHBlci5qYXZh) | `66.66% <0.00%> (-17.95%)` | :arrow_down: |
| [.../wrapper/xenbase/CitrixCheckSshCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy94ZW5zZXJ2ZXIvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci94ZW5zZXJ2ZXIvcmVzb3VyY2Uvd3JhcHBlci94ZW5iYXNlL0NpdHJpeENoZWNrU3NoQ29tbWFuZFdyYXBwZXIuamF2YQ==) | `50.00% <0.00%> (-14.71%)` | :arrow_down: |
| [...stack/affinity/NonStrictHostAffinityProcessor.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hZmZpbml0eS1ncm91cC1wcm9jZXNzb3JzL25vbi1zdHJpY3QtaG9zdC1hZmZpbml0eS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9hZmZpbml0eS9Ob25TdHJpY3RIb3N0QWZmaW5pdHlQcm9jZXNzb3IuamF2YQ==) | `57.89% <0.00%> (-13.91%)` | :arrow_down: |
| [...e/CitrixCoppyToSecondaryStorageCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy94ZW5zZXJ2ZXIvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci94ZW5zZXJ2ZXIvcmVzb3VyY2Uvd3JhcHBlci94ZW5iYXNlL0NpdHJpeENvcHB5VG9TZWNvbmRhcnlTdG9yYWdlQ29tbWFuZFdyYXBwZXIuamF2YQ==) | `20.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...leanupPersistentNetworkResourceCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0Q2xlYW51cFBlcnNpc3RlbnROZXR3b3JrUmVzb3VyY2VDb21tYW5kV3JhcHBlci5qYXZh) | `16.66% <0.00%> (-11.91%)` | :arrow_down: |
| [...r/LibvirtSetupPersistentNetworkCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0U2V0dXBQZXJzaXN0ZW50TmV0d29ya0NvbW1hbmRXcmFwcGVyLmphdmE=) | `12.50% <0.00%> (-9.73%)` | :arrow_down: |
| [...apache/cloudstack/saml/SAML2UserAuthenticator.java](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL3NhbWwyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3NhbWwvU0FNTDJVc2VyQXV0aGVudGljYXRvci5qYXZh) | `46.66% <0.00%> (-9.59%)` | :arrow_down: |
| ... and [1062 more](https://codecov.io/gh/apache/cloudstack/pull/7131?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Weโre building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1407026663
@GutoVeronezi , @DaanHoogland , I created the aforementioned PR (https://github.com/apache/cloudstack/pull/7140) to fix the SonarCloud's bugs and vulnerabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1486457406
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1483244114
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1438932970
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [24 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12037 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1625857300
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1635393757
<b>[SF] Trillian Build Failed (tid-7070)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1636458852
<b>[SF] Trillian test result (tid-7075)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45648 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t7075-kvm-centos7.zip
Smoke tests completed. 110 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 85.07 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 58.61 | test_vm_life_cycle.py
test_05_vmschedule_test_e2e | `Failure` | 165.81 | test_vm_schedule.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1558724216
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1560131274
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1603262209
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692909119
>
> @weizhouapache The tests will run, but if you read the comment I pointed out, you will find that the system VMs will stop logging. Please, try accessing the system VMs with the change you proposed, and see if there is any logging. Last time I checked, it was not working; however, if it is, I'll be happy to comply.
>
> Moreover, ACS is working perfectly without this change. The only thing that broke is the CI, and only because the CI is "manually" calling the EncriptorCLI without passing the proper classpath. This was already discussed and solved with @DaanHoogland.
@JoaoJandre
this PR should help: https://github.com/apache/cloudstack/pull/7912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1703118509
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692034238
@weizhouapache a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692055264
<b>[SF] Trillian Build Failed (tid-7543)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1726397521
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1723938988
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1740846314
@weizhouapache @DaanHoogland can we run another round of tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1723782773
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1743421977
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1491937421
> he setup error still occurs:
@DaanHoogland Now it should be actually fixed, I tested manually the script. The jar file that was being used for a command inside the `cloudstack-setup-databases` did not have log4j2. Now it has.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1496408084
@JoaoJandre, can you look at the conflicts as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1498574685
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1499523239
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12021 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1499569686
@GutoVeronezi a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1538291223
As requested in the devs mailing list, the following script is the one that I'm using to regenerate changes after merging them with the main branch: https://pastebin.com/zzbyhRNG
It is a really simple script that I created to fix the most common cases: it will remove all imports for log4j1, then rename all loggers named `s_logger` to `logger`; after that, if it finds that a static logger has been renamed to `logger` it will rename it to `LOGGER`.
As a convention for loggers' names does not exist, this script leaves some cases that have to be corrected manually, such as loggers that are named `LOG`, for instance, which cannot be searched easily as it is also a substring of `LOGGER` (if we would search and replace that string, we would ending up with a lot of loggers named `LOGGERGER`). The main case should be fixed using the script, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1478080682
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1444482361
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7131)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG) [24 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7131&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL) [12038 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7131&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list) [4.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list) [5.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7131&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1479159518
<b>Trillian Build Failed (tid-6302)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1479350676
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1479679574
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1931647102
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1924351036
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1808078837
> > moving this to 4.20
>
> @DaanHoogland aren't we going to merge this ?
I thought we agreed to move it to 4.20 (or 4.19.1 which makes more sense to me) See https://github.com/apache/cloudstack/pull/7131#issuecomment-1765202106
I am violently neutral on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1749534178
<b>[SF] Trillian test result (tid-7858)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44060 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t7858-kvm-centos7.zip
Smoke tests completed. 110 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_trigger_shutdown | `Failure` | 337.05 | test_safe_shutdown.py
test_02_upgrade_kubernetes_cluster | `Failure` | 579.27 | test_kubernetes_clusters.py
test_05_vmschedule_test_e2e | `Failure` | 361.74 | test_vm_schedule.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1829339272
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1934056636
<b>[SF] Trillian test result (tid-9125)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 47402 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t9125-vmware-67u3.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1669121601
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1672010091
@JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1812111061
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1705680770
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1706109394
<b>[LL]Trillian test result (tid-6734)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37968 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t6734-xenserver-71.zip
Smoke tests completed. 113 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1706270487
<b>[LL]Trillian test result (tid-6736)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44291 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t6736-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_reboot_cpvm | `Error` | 909.20 | test_ssvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1688635914
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692033527
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692211705
> @JoaoJandre see the errors below
>
> ```
> 18:44:16 stderr: Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/logging/log4j/LogManager
> 18:44:16 at com.cloud.utils.crypt.CloudStackEncryptor.<init>(CloudStackEncryptor.java:33)
> 18:44:16 at com.cloud.utils.crypt.EncryptionCLI.main(EncryptionCLI.java:63)
> 18:44:16 Caused by: java.lang.ClassNotFoundException: org.apache.logging.log4j.LogManager
> 18:44:16 at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
> 18:44:16 at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
> 18:44:16 at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
> 18:44:16 ... 2 more
> ```
>
> I think you need to replace `ch.qos.reload4j` with `org.apache.logging.log4j` in the list below
>
> https://github.com/apache/cloudstack/blob/3b05797344c15a9fbd6bee4ecd38281b677f24a2/utils/pom.xml#L266-L274
@weizhouapache
Thank you for sharing, this situation has already been discussed, see https://github.com/apache/cloudstack/pull/7131#issuecomment-1564282630.
The problem is with Trillian calling the EncriptionCLI and not passing log4j2 on the classpath.
This is the reason why @DaanHoogland made a special branch on Trillian to run tests on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1748205977
@DaanHoogland a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1739805355
@JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1759336221
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1755972631
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1755895537
@JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1755895231
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1765762215
Sounds good. I would say merge right after 4.19.0 release so we have all the time to work on any regression/issue and hopefully fewer conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1723787159
@GutoVeronezi a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1865809457
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1636379467
<b>[SF] Trillian test result (tid-7073)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41881 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7131-t7073-xenserver-71.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1924257003
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org