You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/31 08:42:17 UTC

[GitHub] [dubbo-samples] AlbumenJ commented on a change in pull request #202: Add dubbo-samples-spi-compatible module IT support

AlbumenJ commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202#discussion_r550430231



##########
File path: dubbo-samples-spi-compatible/case-configuration.yml
##########
@@ -14,11 +14,33 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from: app-builtin-zookeeper.yml
-
 props:
   project_name: dubbo-samples-spi-compatible
   main_class: org.apache.dubbo.samples.basic.SpiCompatibleProvider
   zookeeper_port: 2181
-  dubbo_port: 20880
 
+services:
+  ${project_name}:

Review comment:
       目的是为了解决dubbo端口检测机制,`dubbo-samples-spi-compatible` 实际上并没有对外暴露端口




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org