[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41717: [SPARK-44165] Add support for TIME columns in Parquet files

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #41717:
URL: https://github.com/apache/spark/pull/41717#discussion_r1242962155


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala:
##########
@@ -391,6 +390,22 @@ private[parquet] class ParquetRowConverter(
             updater.setLong(timestampRebaseFunc(value))
           }
         }
+      case t: DayTimeIntervalType =>

Review Comment:
   Hm, I don't think `DayTimeIntervalType` is matched with Parquet's `TIME` type (https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#time) because `DayTimeIntervalType` contains days? For the similar reasons, we don't support unsigned types too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org