[jira] [Comment Edited] (CLOUDSTACK-9616) KVM iSCSI adaptor: alllow other adaptors to disconnect disks

["Sateesh Chodapuneedi (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036629#comment-17036629 ] 

Sateesh Chodapuneedi edited comment on CLOUDSTACK-9616 at 2/14/20 1:34 AM:
---------------------------------------------------------------------------

Fixed in https://github.com/apache/cloudstack/commit/bf209405e7d60b6a5abf87677d368c429359d98a#diff-0c33aaec8a8fe2523c316f5e34485a87R352

PR - [https://github.com/apache/cloudstack/pull/2997]

 


was (Author: sateeshc):
Fixed in [https://github.com/apache/cloudstack/commit/bf209405e7d60b6a5abf87677d368c429359d98a]

PR - https://github.com/apache/cloudstack/pull/2997

> KVM iSCSI adaptor: alllow other adaptors to disconnect disks
> ------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9616
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9616
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>         Environment: KVM hypervisor, more than one storage adaptor
>            Reporter: Peter Pentchev
>            Priority: Major
>              Labels: patch
>             Fix For: 4.12
>
>
> Hi,
> Thanks for developing CloudStack!
> If the following conditions are met:
> - more than one storage adaptor is defined for a KVM storage pool
> - a disconnectPhysicalDiskByPath() request comes in for the pool (the KVMStoragePoolManager.disconnectPhysicalDiskByPath() method is invoked)
> - the loop in that method finds the iSCSI adaptor first
> - the disk being disconnected is *not* managed by the iSCSI adaptor
> ....then the IscsiAdmStorageAdaptor.disconnectPhysicalDiskByPath() will return a "true" value, signalling that the request has been handled, while it has actually been silently ignored.
> A patch making the iSCSI storage adaptor return "false" (thus allowing other storage adaptors to process the request and actually disconnect the disk) is available as a GitHub pull request at https://github.com/apache/cloudstack/pull/1780
> Thanks in advance for your time and consideration!
> Best regards,
> Peter



--
This message was sent by Atlassian Jira
(v8.3.4#803005)