You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dramaticlly (via GitHub)" <gi...@apache.org> on 2026/10/02 19:09:16 UTC
[PR] API, Core: improve toString in struct implementations [iceberg]
dramaticlly opened a new pull request, #18353:
URL: https://github.com/apache/iceberg/pull/18353
After reviewing #18342, apply the same forms to the remaining struct toString implementations:
- StructTransform: join the transformed tuple with Collectors.joining, following `StructLikeUtil.StructCopy`. Used/Inherited by `PartitionKey` and `SortKey`.
- PartitionData: build the field list with StringJoiner, following `StructProjection`.
- StaticDataTask.Row: add toString instead of `org.apache.iceberg.StaticDataTask$Row@7db0565c`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: improve toString in struct implementations [iceberg]
Posted by "dramaticlly (via GitHub) via issues" <is...@iceberg.apache.org>.
dramaticlly commented on PR #18353:
URL: https://github.com/apache/iceberg/pull/18353#issuecomment-6664188899
@nastra @huaxingao if you can take a look? Already have 2 non committer approvals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: improve toString in struct implementations [iceberg]
Posted by "dramaticlly (via GitHub) via issues" <is...@iceberg.apache.org>.
dramaticlly commented on PR #18353:
URL: https://github.com/apache/iceberg/pull/18353#issuecomment-6755106727
Thanks everyone for the review and @nastra for the merge of the change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: improve toString in struct implementations [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #18353:
URL: https://github.com/apache/iceberg/pull/18353#issuecomment-5997228832
Nice, thank you @dramaticlly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: improve toString in struct implementations [iceberg]
Posted by "github-actions[bot] (via GitHub) via issues" <is...@iceberg.apache.org>.
github-actions[bot] commented on PR #18353:
URL: https://github.com/apache/iceberg/pull/18353#issuecomment-6645939027
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: improve toString in struct implementations [iceberg]
Posted by "dramaticlly (via GitHub)" <gi...@apache.org>.
dramaticlly commented on PR #18353:
URL: https://github.com/apache/iceberg/pull/18353#issuecomment-5963255515
@amogh-jahagirdar @anoopj can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: improve toString in struct implementations [iceberg]
Posted by "nastra (via GitHub) via issues" <is...@iceberg.apache.org>.
nastra merged PR #18353:
URL: https://github.com/apache/iceberg/pull/18353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org