You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ki...@apache.org on 2022/08/05 04:15:07 UTC

[incubator-seatunnel] branch dev updated: [Imporve][Connector-V2] Remove redundant type judge logic because of pr #2315 (#2370)

This is an automated email from the ASF dual-hosted git repository.

kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 42e8c25e5 [Imporve][Connector-V2] Remove redundant type judge logic because of pr #2315 (#2370)
42e8c25e5 is described below

commit 42e8c25e50d66496da2de6a5ab927a322b9fcacf
Author: TyrantLucifer <Ty...@gmail.com>
AuthorDate: Fri Aug 5 12:15:02 2022 +0800

    [Imporve][Connector-V2] Remove redundant type judge logic because of pr #2315 (#2370)
---
 .../file/sink/hdfs/HdfsParquetTransactionStateFileWriter.java     | 8 +-------
 .../file/sink/local/LocalParquetTransactionStateFileWriter.java   | 8 +-------
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/seatunnel-connectors-v2/connector-file/connector-file-hadoop/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/hdfs/HdfsParquetTransactionStateFileWriter.java b/seatunnel-connectors-v2/connector-file/connector-file-hadoop/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/hdfs/HdfsParquetTransactionStateFileWriter.java
index b309bef7a..2b3afda39 100644
--- a/seatunnel-connectors-v2/connector-file/connector-file-hadoop/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/hdfs/HdfsParquetTransactionStateFileWriter.java
+++ b/seatunnel-connectors-v2/connector-file/connector-file-hadoop/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/hdfs/HdfsParquetTransactionStateFileWriter.java
@@ -69,13 +69,7 @@ public class HdfsParquetTransactionStateFileWriter extends AbstractTransactionSt
         ParquetWriter<GenericRecord> writer = getOrCreateWriter(filePath);
         Schema schema = buildSchemaWithRowType();
         GenericRecordBuilder recordBuilder = new GenericRecordBuilder(schema);
-        sinkColumnsIndexInRow.forEach(index -> {
-            if (seaTunnelRowTypeInfo.getFieldType(index).equals(BasicType.STRING_TYPE)) {
-                recordBuilder.set(seaTunnelRowTypeInfo.getFieldName(index), seaTunnelRow.getField(index).toString());
-            } else {
-                recordBuilder.set(seaTunnelRowTypeInfo.getFieldName(index), seaTunnelRow.getField(index));
-            }
-        });
+        sinkColumnsIndexInRow.forEach(index -> recordBuilder.set(seaTunnelRowTypeInfo.getFieldName(index), seaTunnelRow.getField(index)));
         GenericData.Record record = recordBuilder.build();
         try {
             writer.write(record);
diff --git a/seatunnel-connectors-v2/connector-file/connector-file-local/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/local/LocalParquetTransactionStateFileWriter.java b/seatunnel-connectors-v2/connector-file/connector-file-local/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/local/LocalParquetTransactionStateFileWriter.java
index ec5833e4a..94a9a0882 100644
--- a/seatunnel-connectors-v2/connector-file/connector-file-local/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/local/LocalParquetTransactionStateFileWriter.java
+++ b/seatunnel-connectors-v2/connector-file/connector-file-local/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/local/LocalParquetTransactionStateFileWriter.java
@@ -71,13 +71,7 @@ public class LocalParquetTransactionStateFileWriter extends AbstractTransactionS
         ParquetWriter<GenericRecord> writer = getOrCreateWriter(filePath);
         Schema schema = buildSchemaWithRowType();
         GenericRecordBuilder recordBuilder = new GenericRecordBuilder(schema);
-        sinkColumnsIndexInRow.forEach(index -> {
-            if (seaTunnelRowTypeInfo.getFieldType(index).equals(BasicType.STRING_TYPE)) {
-                recordBuilder.set(seaTunnelRowTypeInfo.getFieldName(index), seaTunnelRow.getField(index).toString());
-            } else {
-                recordBuilder.set(seaTunnelRowTypeInfo.getFieldName(index), seaTunnelRow.getField(index));
-            }
-        });
+        sinkColumnsIndexInRow.forEach(index -> recordBuilder.set(seaTunnelRowTypeInfo.getFieldName(index), seaTunnelRow.getField(index)));
         GenericData.Record record = recordBuilder.build();
         try {
             writer.write(record);