You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tez.apache.org by GitBox <gi...@apache.org> on 2021/05/17 11:36:01 UTC

[GitHub] [tez] harishjp commented on pull request #120: TEZ-4305: Invoke hflush, only if the stream supports it

harishjp commented on pull request #120:
URL: https://github.com/apache/tez/pull/120#issuecomment-842251967


   > nit: I was wondering if we can place a DEBUG message if hflush is skipped because it's not supported
   > this codepath is only called from finishCurrentDag, so once per dag, it won't spam the logs...
   
   > other than this nit, the patch looks good to me
   > cc: @harishjp if you have any comments
   
   This is fine in tez, we use the same code in hive (It has to be copied to hive). And there we write one event per file on s3 since s3 does not support reading a file in which data is still being written. It will write 2 log lines per query there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org