You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:54 UTC
[Impala-CR] IMPALA-3952: Clear scratch batch mem pool if Open() failed.
Hello Internal Jenkins, Alex Behm,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4236
to review the following change.
Change subject: IMPALA-3952: Clear scratch batch mem pool if Open() failed.
......................................................................
IMPALA-3952: Clear scratch batch mem pool if Open() failed.
We used to be able to hit a DCHECK in HdfsParquetScanner::Close()
when using the legacy aggs/joins if HdfsParquetScanner::Open() failed.
With the legacy aggs/joins the tuple ptrs of the scratch batch are
allocated from the scratch batch's mem pool, and if Open() failed we
never freed or transferred the scratch batch's mem pool.
Testing: I tested this patch together with the fix for IMPALA-3964
on core/hdfs with the legacy aggs and joins enabled.
Change-Id: I55f32ed698a5b6fed8c28af1391aa07e1560e782
Reviewed-on: http://gerrit.cloudera.org:8080/3953
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 3a630a5d6871db6afe9ca343aea80b14c6525f3d)
---
M be/src/exec/hdfs-parquet-scanner.cc
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/36/4236/1
--
To view, visit http://gerrit.cloudera.org:8080/4236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55f32ed698a5b6fed8c28af1391aa07e1560e782
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-CR] IMPALA-3952: Clear scratch batch mem pool if Open() failed.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.
Change subject: IMPALA-3952: Clear scratch batch mem pool if Open() failed.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I55f32ed698a5b6fed8c28af1391aa07e1560e782
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>