[jira] [Comment Edited] (CASSANDRA-17913) Nested selection of reversed collections fails

["Maciej Sokol (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629721#comment-17629721 ] 

Maciej Sokol edited comment on CASSANDRA-17913 at 11/7/22 2:26 PM:
-------------------------------------------------------------------

[PR for 4.0|https://github.com/apache/cassandra/pull/1978]

I'm kinda new to this part of the code, i've added unittests for these changes to test different scenarios.

All tests in CollectionsTest are running green for me.

I've run circleCI but by the looks of it i don't have enough resources. I get similar failures for this PR and 4.0 branch. If someone could run CI that would be great.


was (Author: JIRAUSER285315):
[PR for 4.0|https://github.com/apache/cassandra/pull/1978]

I'm kinda new to this part of the code, i've added unittests for these changes to test different scenarios.

All tests in CollectionsTest are running green for me. If someone can run CI that would be great :)

> Nested selection of reversed collections fails
> ----------------------------------------------
>
>                 Key: CASSANDRA-17913
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17913
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Coordination, CQL/Semantics, Legacy/Local Write-Read Paths
>            Reporter: David Capwell
>            Assignee: Maciej Sokol
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x
>
>
> The following test fails caused by the fact we make reversed a type that wraps the underline type
> {code:java}
> @Test
>     public void testMapsReversed() throws Throwable
>     {
>         createTable("CREATE TABLE %s (" +
>                     "   k int, " +
>                     "   c frozen<map<text, int>>, " +
>                     "   v int, " +
>                     "   PRIMARY KEY(k, c)" +
>                     ") WITH CLUSTERING ORDER BY (c DESC)");
>         execute("SELECT c['testing'] FROM %s");
>     }
> {code}
> With the error
> {code:java}
> org.apache.cassandra.exceptions.InvalidRequestException: Invalid element selection: c is of type frozen<map<text, int>> is not a collection
> {code}
> When you look in a debugger you see that the real type is ReversedType(MapType(…)), so the current checks fail.
> {+}Additional information for newcomers{+}:
>  * The problem impact element selection as well as range selection that where introduced in CASSANDRA-7396 as part of 4.0. So the patch will need to be done for 4.0.
>  * The checks that needs to be modified is in {{Selectable.WithElementSelection}} and {{Selectable.WithSliceSelection}}
>  * The unit tests should be added to {{CollectionsTest}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org