You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/02/08 05:15:53 UTC
[GitHub] [hbase] YutSean opened a new pull request #2935: HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1
YutSean opened a new pull request #2935:
URL: https://github.com/apache/hbase/pull/2935
https://issues.apache.org/jira/browse/HBASE-21674
The DDL part of thrift2 is not implemented. These will be implemented in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] YutSean closed pull request #2935: HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1
Posted by GitBox <gi...@apache.org>.
YutSean closed pull request #2935:
URL: https://github.com/apache/hbase/pull/2935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2935: HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2935:
URL: https://github.com/apache/hbase/pull/2935#issuecomment-774898535
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 15m 18s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | jshint | 0m 0s | jshint was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 8 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 14s | branch-1 passed |
| +1 :green_heart: | compile | 0m 46s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | compile | 1m 0s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +1 :green_heart: | checkstyle | 1m 15s | branch-1 passed |
| +1 :green_heart: | shadedjars | 4m 4s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 8s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | javadoc | 2m 40s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +0 :ok: | spotbugs | 2m 14s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 51s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 49s | root in the patch failed. |
| -1 :x: | compile | 0m 32s | hbase-thrift in the patch failed with JDK Azul Systems, Inc.-1.8.0_262-b19. |
| -1 :x: | javac | 0m 32s | hbase-thrift in the patch failed with JDK Azul Systems, Inc.-1.8.0_262-b19. |
| -1 :x: | compile | 0m 26s | hbase-common in the patch failed with JDK Azul Systems, Inc.-1.7.0_272-b10. |
| -1 :x: | compile | 0m 39s | hbase-thrift in the patch failed with JDK Azul Systems, Inc.-1.7.0_272-b10. |
| -1 :x: | javac | 0m 26s | hbase-common in the patch failed with JDK Azul Systems, Inc.-1.7.0_272-b10. |
| -1 :x: | javac | 0m 39s | hbase-thrift in the patch failed with JDK Azul Systems, Inc.-1.7.0_272-b10. |
| -1 :x: | checkstyle | 0m 43s | hbase-thrift: The patch generated 355 new + 82 unchanged - 73 fixed = 437 total (was 155) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| -1 :x: | shadedjars | 0m 59s | patch has 26 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 0m 49s | The patch causes 26 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 1m 55s | The patch causes 26 errors with Hadoop v2.9.2. |
| -1 :x: | javadoc | 0m 33s | hbase-thrift-jdkAzulSystems,Inc.-1.8.0_262-b19 with JDK Azul Systems, Inc.-1.8.0_262-b19 generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0) |
| -1 :x: | javadoc | 3m 26s | hbase-thrift-jdkAzulSystems,Inc.-1.7.0_272-b10 with JDK Azul Systems, Inc.-1.7.0_272-b10 generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0) |
| -1 :x: | findbugs | 0m 23s | hbase-common in the patch failed. |
| -1 :x: | findbugs | 0m 36s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 25s | hbase-common in the patch failed. |
| -1 :x: | unit | 0m 39s | hbase-thrift in the patch failed. |
| +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. |
| | | 58m 29s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2935 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile jshint |
| uname | Linux 1f6c6d0fd185 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2935/out/precommit/personality/provided.sh |
| git revision | branch-1 / 7d80d99 |
| Default Java | Azul Systems, Inc.-1.7.0_272-b10 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-compile-hbase-thrift-jdkAzulSystems,Inc.-1.8.0_262-b19.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-compile-hbase-thrift-jdkAzulSystems,Inc.-1.8.0_262-b19.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-compile-hbase-common-jdkAzulSystems,Inc.-1.7.0_272-b10.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-compile-hbase-thrift-jdkAzulSystems,Inc.-1.7.0_272-b10.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-compile-hbase-common-jdkAzulSystems,Inc.-1.7.0_272-b10.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-compile-hbase-thrift-jdkAzulSystems,Inc.-1.7.0_272-b10.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/diff-checkstyle-hbase-thrift.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-javac-2.9.2.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/diff-javadoc-javadoc-hbase-thrift-jdkAzulSystems,Inc.-1.8.0_262-b19.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/diff-javadoc-javadoc-hbase-thrift-jdkAzulSystems,Inc.-1.7.0_272-b10.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-findbugs-hbase-common.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-findbugs-hbase-thrift.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-unit-hbase-common.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/artifact/out/patch-unit-hbase-thrift.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/testReport/ |
| Max. process+thread count | 77 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-thrift U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2935/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org