You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2026/05/22 22:32:52 UTC
[PR] HDDS-15322. Add tests for ScmInvoker subclasses. [ozone]
szetszwo opened a new pull request, #10336:
URL: https://github.com/apache/ozone/pull/10336
## What changes were proposed in this pull request?
See HDDS-15322
## What is the link to the Apache JIRA
HDDS-15322
## How was this patch tested?
Added new tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15322. Add tests for ScmInvoker subclasses. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #10336:
URL: https://github.com/apache/ozone/pull/10336#issuecomment-4530548788
@Russole , thanks for reviewing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15322. Add tests for ScmInvoker subclasses. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #10336:
URL: https://github.com/apache/ozone/pull/10336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15322. Add tests for ScmInvoker subclasses. [ozone]
Posted by "Russole (via GitHub)" <gi...@apache.org>.
Russole commented on code in PR #10336:
URL: https://github.com/apache/ozone/pull/10336#discussion_r3294992507
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/invoker/ScmInvokerCodeGenerator.java:
##########
@@ -607,15 +611,17 @@ public String generateClass() {
return out.toString();
}
- File updateFile(String classString) throws IOException {
- final File java = new File(DIR, invokerClassName + ".java");
+ File updateFile(String classString, String dir, boolean overwrite) throws IOException {
+ final File java = new File(dir, invokerClassName + ".java");
if (!java.isFile()) {
throw new FileNotFoundException("Not found: " + java.getAbsolutePath());
}
- final File tmp = new File(DIR, invokerClassName + "_tmp.java");
+ final File tmp = new File(dir, invokerClassName + "_tmp.java");
if (tmp.exists()) {
throw new IOException("Already exist: " + java.getAbsolutePath());
Review Comment:
Although this was not introduced in this PR, since this method is being touched, should this error message use `tmp.getAbsolutePath()` instead of `java.getAbsolutePath()` ? The file that already exists here is tmp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15322. Add tests for ScmInvoker subclasses. [ozone]
Posted by "Russole (via GitHub)" <gi...@apache.org>.
Russole commented on PR #10336:
URL: https://github.com/apache/ozone/pull/10336#issuecomment-4529388468
Thanks @szetszwo for working on this. Overall LGTM, just one minor comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org